From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio Date: Mon, 9 May 2016 11:34:42 +0300 Message-ID: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> References: <1462474581-13865-1-git-send-email-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1462474581-13865-1-git-send-email-tony@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren , linux-omap@vger.kernel.org Cc: =?UTF-8?Q?Agust=c3=ad_Fontquerni?= , Enric Balletbo i Serra , Eduard Gavin , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gMDUvMDUvMTYgMjE6NTYsIFRvbnkgTGluZGdyZW4gd3JvdGU6Cj4gUGxheWluZyBhdWRpbyB3 b3JrcyBvbiBvbWFwNS11ZXZtLCBidXQgcHJvZHVjZXMgYW4gIlVuaGFuZGxlZCBmYXVsdDoKPiBp bXByZWNpc2UgZXh0ZXJuYWwgYWJvcnQgKDB4MTQwNikgYXQgMHgwMDAwMDAwMCIgZXJyb3Igb24g aWdlcHY1Lgo+IAo+IExvb2tzIGxpa2UgdGhlIHR3bDYwNDAgYXVkcHdyb24gR1BJTyBwaW4gaXMg ZGlmZmVyZW50IGZvciB0aGVzZQo+IGJvYXJkcy4gTGV0J3MgZml4IHRoZSBpc3N1ZSBieSBjb25m aWd1cmluZyB0aGUgYXVkcHdyb24gaW4gdGhlCj4gYm9hcmQgc3BlY2lmaWMgZHRzIGZpbGUuCj4g Cj4gQ2M6IEFndXN0w60gRm9udHF1ZXJuaSA8YWZAaXNlZWJjbi5jb20+Cj4gQ2M6IEVkdWFyZCBH YXZpbiA8ZWdhdmluQGlzZWViY24uY29tPgo+IENjOiBFbnJpYyBCYWxsZXRibyBpIFNlcnJhIDxl YmFsbGV0Ym9AaXNlZWJjbi5jb20+Cj4gQ2M6IFBldGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVz aUB0aS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNv bT4KPiAtLS0KPiAgYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtYm9hcmQtY29tbW9uLmR0c2kgfCAg MyArKy0KPiAgYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtaWdlcDAwNTAuZHRzICAgICAgfCAxMCAr KysrKysrKysrCj4gIGFyY2gvYXJtL2Jvb3QvZHRzL29tYXA1LXVldm0uZHRzICAgICAgICAgIHwg MTAgKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtYm9hcmQt Y29tbW9uLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9vbWFwNS1ib2FyZC1jb21tb24uZHRzaQo+ IGluZGV4IDJlZWEyNmMuLjIzYjFkN2MgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMv b21hcDUtYm9hcmQtY29tbW9uLmR0c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9vbWFwNS1i b2FyZC1jb21tb24uZHRzaQo+IEBAIC02NDIsNyArNjQyLDggQEAKPiAgCQlwaW5jdHJsLTAgPSA8 JnR3bDYwNDBfcGlucz47Cj4gIAo+ICAJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxMTkgSVJRX1RZ UEVfTk9ORT47IC8qIElSUV9TWVNfMk4gY2FzY2FkZWQgdG8gZ2ljICovCj4gLQkJdGksYXVkcHdy b24tZ3BpbyA9IDwmZ3BpbzUgMTMgR1BJT19BQ1RJVkVfSElHSD47ICAvKiBncGlvIGxpbmUgMTQx ICovCj4gKwo+ICsJCS8qIGF1ZHB3cm9uIGdwaW8gZGVmaW5lZCBpbiB0aGUgYm9hcmQgc3BlY2lm aWMgZHRzICovCj4gIAo+ICAJCXZpby1zdXBwbHkgPSA8JnNtcHM3X3JlZz47Cj4gIAkJdjJ2MS1z dXBwbHkgPSA8JnNtcHM5X3JlZz47Cj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL29t YXA1LWlnZXAwMDUwLmR0cyBiL2FyY2gvYXJtL2Jvb3QvZHRzL29tYXA1LWlnZXAwMDUwLmR0cwo+ IGluZGV4IDcyZmY2YTQuLjY3M2NkZmEgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMv b21hcDUtaWdlcDAwNTAuZHRzCj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtaWdlcDAw NTAuZHRzCj4gQEAgLTU4LDMgKzU4LDEzIEBACj4gIAkJPCZncGlvNyAzIDA+OwkJLyogMTk1LCBT REEgKi8KPiAgfTsKPiAgCj4gKyZ0d2w2MDQwIHsKPiArCXRpLGF1ZHB3cm9uLWdwaW8gPSA8Jmdw aW81IDE2IEdQSU9fQUNUSVZFX0hJR0g+OyAgLyogZ3BpbyBsaW5lIDE0NCAqLwoKQlRXOiBob3cg ZG8geW91IGtub3cgdGhhdCBncGlvMTQ0IGlzIHVzZWQgYXMgYXVkcHdyb24gR1BJTyBvbiBpZ2Vw djU/Cgo+ICt9Owo+ICsKPiArJnR3bDYwNDBfcGlucyB7Cj4gKwlwaW5jdHJsLXNpbmdsZSxwaW5z ID0gPAo+ICsJCU9NQVA1X0lPUEFEKDB4MWM0LCBQSU5fT1VUUFVUIHwgTVVYX01PREU2KQkvKiBt Y3NwaTFfc29taS5ncGlvNV8xNDQgKi8KPiArCQlPTUFQNV9JT1BBRCgweDFjYSwgUElOX09VVFBV VCB8IE1VWF9NT0RFNikJLyogcGVyc2xpbWJ1czJfY2xvY2suZ3BpbzVfMTQ1ICovCgpXaGF0IGRv ZXMgdGhlIGdwaW8xNDUgaXMgdXNlZCBmb3I/Cgo+ICsJPjsKPiArfTsKPiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm0vYm9vdC9kdHMvb21hcDUtdWV2bS5kdHMgYi9hcmNoL2FybS9ib290L2R0cy9vbWFw NS11ZXZtLmR0cwo+IGluZGV4IDYwYjNmYmIuLmE1MWU2MDUgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9h cm0vYm9vdC9kdHMvb21hcDUtdWV2bS5kdHMKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9vbWFw NS11ZXZtLmR0cwo+IEBAIC01MSwzICs1MSwxMyBAQAo+ICAJCTwmZ3BpbzkgMSBHUElPX0FDVElW RV9ISUdIPiwJLyogVENBNjQyNEEgUDAwLCBMUyBPRSAqLwo+ICAJCTwmZ3BpbzcgMSBHUElPX0FD VElWRV9ISUdIPjsJLyogR1BJTyAxOTMsIEhQRCAqLwo+ICB9Owo+ICsKPiArJnR3bDYwNDAgewo+ ICsJdGksYXVkcHdyb24tZ3BpbyA9IDwmZ3BpbzUgMTMgR1BJT19BQ1RJVkVfSElHSD47ICAvKiBn cGlvIGxpbmUgMTQxICovCj4gK307Cj4gKwo+ICsmdHdsNjA0MF9waW5zIHsKPiArCXBpbmN0cmwt c2luZ2xlLHBpbnMgPSA8Cj4gKwkJT01BUDVfSU9QQUQoMHgxYmUsIFBJTl9PVVRQVVQgfCBNVVhf TU9ERTYpCS8qIG1jc3BpMV9zb21pLmdwaW81XzE0MSAqLwo+ICsJPjsKPiArfTsKPiAKCgotLSAK UMOpdGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Mon, 9 May 2016 11:34:42 +0300 Subject: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio In-Reply-To: <1462474581-13865-1-git-send-email-tony@atomide.com> References: <1462474581-13865-1-git-send-email-tony@atomide.com> Message-ID: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/05/16 21:56, Tony Lindgren wrote: > Playing audio works on omap5-uevm, but produces an "Unhandled fault: > imprecise external abort (0x1406) at 0x00000000" error on igepv5. > > Looks like the twl6040 audpwron GPIO pin is different for these > boards. Let's fix the issue by configuring the audpwron in the > board specific dts file. > > Cc: Agust? Fontquerni > Cc: Eduard Gavin > Cc: Enric Balletbo i Serra > Cc: Peter Ujfalusi > Signed-off-by: Tony Lindgren > --- > arch/arm/boot/dts/omap5-board-common.dtsi | 3 ++- > arch/arm/boot/dts/omap5-igep0050.dts | 10 ++++++++++ > arch/arm/boot/dts/omap5-uevm.dts | 10 ++++++++++ > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > index 2eea26c..23b1d7c 100644 > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > @@ -642,7 +642,8 @@ > pinctrl-0 = <&twl6040_pins>; > > interrupts = ; /* IRQ_SYS_2N cascaded to gic */ > - ti,audpwron-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>; /* gpio line 141 */ > + > + /* audpwron gpio defined in the board specific dts */ > > vio-supply = <&smps7_reg>; > v2v1-supply = <&smps9_reg>; > diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts > index 72ff6a4..673cdfa 100644 > --- a/arch/arm/boot/dts/omap5-igep0050.dts > +++ b/arch/arm/boot/dts/omap5-igep0050.dts > @@ -58,3 +58,13 @@ > <&gpio7 3 0>; /* 195, SDA */ > }; > > +&twl6040 { > + ti,audpwron-gpio = <&gpio5 16 GPIO_ACTIVE_HIGH>; /* gpio line 144 */ BTW: how do you know that gpio144 is used as audpwron GPIO on igepv5? > +}; > + > +&twl6040_pins { > + pinctrl-single,pins = < > + OMAP5_IOPAD(0x1c4, PIN_OUTPUT | MUX_MODE6) /* mcspi1_somi.gpio5_144 */ > + OMAP5_IOPAD(0x1ca, PIN_OUTPUT | MUX_MODE6) /* perslimbus2_clock.gpio5_145 */ What does the gpio145 is used for? > + >; > +}; > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts > index 60b3fbb..a51e605 100644 > --- a/arch/arm/boot/dts/omap5-uevm.dts > +++ b/arch/arm/boot/dts/omap5-uevm.dts > @@ -51,3 +51,13 @@ > <&gpio9 1 GPIO_ACTIVE_HIGH>, /* TCA6424A P00, LS OE */ > <&gpio7 1 GPIO_ACTIVE_HIGH>; /* GPIO 193, HPD */ > }; > + > +&twl6040 { > + ti,audpwron-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>; /* gpio line 141 */ > +}; > + > +&twl6040_pins { > + pinctrl-single,pins = < > + OMAP5_IOPAD(0x1be, PIN_OUTPUT | MUX_MODE6) /* mcspi1_somi.gpio5_141 */ > + >; > +}; > -- P?ter