All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Joelle van Dyne <j@getutm.app>,
	qemu-devel@nongnu.org, slirp@lists.freedesktop.org,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v6 6/7] slirp: update build flags for iOS resolv fix
Date: Tue, 12 Jan 2021 12:52:28 +0100	[thread overview]
Message-ID: <1b4c4f34-8b27-3b45-7de8-19eed100f6f8@redhat.com> (raw)
In-Reply-To: <20210105022055.12113-7-j@getutm.app>

Hi Joelle,

On 1/5/21 3:20 AM, Joelle van Dyne wrote:
> A future libslirp update will use libresolv on Darwin systems, so we add the
> flags in QEMU build now.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
>  meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 900dbc36c8..d8951d4d6c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1205,6 +1205,8 @@ if have_system
>      slirp_deps = []
>      if targetos == 'windows'
>        slirp_deps = cc.find_library('iphlpapi')
> +    elif targetos == 'darwin'
> +      slirp_deps = cc.find_library('resolv')

This is done in libSLiRP commit 9f82a47 ("Add DNS resolving for iOS").

Maybe this commit need to be backported in the stable branch,
or QEMU should use a newer commit. Cc'ing Samuel and Marc-André
who maintain the project (and the SLiRP list).

>      endif
>      slirp_conf = configuration_data()
>      slirp_conf.set('SLIRP_MAJOR_VERSION', meson.project_version().split('.')[0])
> 



  reply	other threads:[~2021-01-12 11:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  2:20 [PATCH v6 0/7] iOS and Apple Silicon host support Joelle van Dyne
2021-01-05  2:20 ` [PATCH v6 1/7] configure: option to disable host block devices Joelle van Dyne
2021-01-05  2:20 ` [PATCH v6 2/7] configure: cross-compiling with empty cross_prefix Joelle van Dyne
2021-01-05  2:20 ` [PATCH v6 3/7] qemu: add support for iOS host Joelle van Dyne
2021-01-12 11:56   ` Philippe Mathieu-Daudé
2021-01-12 22:18     ` Joelle van Dyne
2021-01-12 15:03   ` Peter Maydell
2021-01-12 22:37     ` Joelle van Dyne
2021-01-21 18:53   ` Peter Maydell
2023-11-28 15:12     ` Philippe Mathieu-Daudé
2021-01-05  2:20 ` [PATCH v6 4/7] coroutine: add libucontext as external library Joelle van Dyne
2021-01-21 16:17   ` Daniel P. Berrangé
2021-01-21 17:11     ` Joelle van Dyne
2021-01-05  2:20 ` [PATCH v6 5/7] configure: cross compile should use x86_64 cpu_family Joelle van Dyne
2021-01-12 11:46   ` Philippe Mathieu-Daudé
2021-01-05  2:20 ` [PATCH v6 6/7] slirp: update build flags for iOS resolv fix Joelle van Dyne
2021-01-12 11:52   ` Philippe Mathieu-Daudé [this message]
2021-01-14 11:07     ` [Slirp] " Marc-André Lureau
2021-01-05  2:20 ` [PATCH v6 7/7] block: check availablity for preadv/pwritev on mac Joelle van Dyne
2021-01-12 11:01 ` [PATCH v6 0/7] iOS and Apple Silicon host support Peter Maydell
2021-01-12 22:05   ` Joelle van Dyne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b4c4f34-8b27-3b45-7de8-19eed100f6f8@redhat.com \
    --to=philmd@redhat.com \
    --cc=j@getutm.app \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=slirp@lists.freedesktop.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.