From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F3CEC433EF for ; Wed, 29 Sep 2021 16:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B5C461381 for ; Wed, 29 Sep 2021 16:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345472AbhI2Q2c (ORCPT ); Wed, 29 Sep 2021 12:28:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344370AbhI2Q2c (ORCPT ); Wed, 29 Sep 2021 12:28:32 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A6B4C06161C for ; Wed, 29 Sep 2021 09:26:51 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id i13so3508451ilm.4 for ; Wed, 29 Sep 2021 09:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nvuL53GG4ZKcbarpu9fgiT4nxY3Ya+EWac650T7Wl+I=; b=XcSO1sDId1+SHHk+UyucSVrt5zUeR7axtjojlaAXN0DgbbzXMhXDnUFvckaPx0VvMZ cujcoUirOyn/2fIBsEQRz3vJQM3mEGu6yHNJGY8JjQZ27Iae6AzJmf43K6+cCXS+gLZT jUcX3vab4MGz4Wr8bVEgG9ArDSyHd24GEMtvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nvuL53GG4ZKcbarpu9fgiT4nxY3Ya+EWac650T7Wl+I=; b=eIDHd5zLnOVPGl8jcugEmR3nUJq4Ylj/FpyD3NKBhC4TMBPRU12JAsAclcIQS1nvWh uCZAAr04zV8jkbW5d/AeBhH3HzIffQvSXgdo0kiFn1i0LdZ1O1U/ECGYTbIWdp/Qtm3v vXjfrfUCGDsXxjwWEYCt6aDnEW5rtHr4mCVntoQe4WcgTOYSJdSkIRFZ76dM2vA/g/NJ XjXn4hxSXrgCnGHkVyovgW2RF/+vh8ewPasbiD5eCgPGvkvUMVdIbbIv8kfMiZwneLW6 wKU71Qb68zy436QqqnilGBoWE5uqtcKByGI9IeyJ9GHZOFc2xIXO3nUv5wBu/VnM5g1A 1tmw== X-Gm-Message-State: AOAM532MfqqytDXLqknq5ZLsM+wSMBIYUpc2E6ouH7ZhAhDeM9EQosHg 1++CQHM0/Ynn2N38RfTFM7KMyQ== X-Google-Smtp-Source: ABdhPJwYGVu9LWWLKU5+zt5Dh26Qzuzn6kc/7fVZKzaYWO+hcZEhSaUyZdGsYCovA+0FCET8IyJEHQ== X-Received: by 2002:a05:6e02:1caa:: with SMTP id x10mr425573ill.280.1632932810795; Wed, 29 Sep 2021 09:26:50 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id q17sm133023iod.51.2021.09.29.09.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 09:26:50 -0700 (PDT) Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates To: Will Deacon , Mark Brown Cc: Catalin Marinas , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com, Shuah Khan References: <20210917120855.13858-1-broonie@kernel.org> <20210929143113.GA22029@willie-the-truck> <20210929144323.GQ4199@sirena.org.uk> <20210929153511.GB22029@willie-the-truck> From: Shuah Khan Message-ID: <1b573881-ef9f-c7ae-c08b-8079f63f66ec@linuxfoundation.org> Date: Wed, 29 Sep 2021 10:26:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210929153511.GB22029@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 9/29/21 9:35 AM, Will Deacon wrote: > On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote: >> On Wed, Sep 29, 2021 at 03:31:14PM +0100, Will Deacon wrote: >> >>> With this series applied, I see a test failing under qemu with: >> >>> # selftests: arm64: vec-syscfg >>> # TAP version 13 >>> # 1..10 >>> # ok 1 SVE default vector length 64 >>> # ok 2 # SKIP Need to be root to write to /proc >>> # ok 3 # SKIP Need to be root to write to /proc >> >> AFAICT this is due to running as a non-root user, the testsuite was >> already having serious issues before then... >> >>> # ok 4 SVE current VL is 64 >>> # ok 5 SVE set VL 64 and have VL 64 >>> # ok 6 # SKIP SVE only one VL supported >>> # ok 7 # SKIP SVE only one VL supported >>> # ok 8 # SKIP SVE only one VL supported >>> # ok 9 # SKIP SVE only one VL supported >>> # # SVE VL 272 returned 256 not maximum 0 >> >> ...as it's starting off by testing an interface that's only writable by >> root and then relying on that information, the existing tests were also >> not working usefully. qemu by default supports way more than one vector >> length. In any case it's just the test added by the last patch that's >> causing the output here, the first four patches should be fine and fix >> issues. >> >> I'm not sure it's a particularly good idea to run kselftest as a >> non-root user TBH, it's going to cause you to skip a lot of tests. > We don't want Kselftest default run to be as root. Users can choose to run as root which would be an explicit choice so they expect and plan for the impact. Example panic test. > Ah, thanks for pointing that out. It would probably be better to skip the > tests rather than fail them if they're not running with sufficient > permissions, but I'll go ahead and queue your v3 for now. > Correct. I would like to see tests skipped not failed if either config or permissions are lacking to run the tests. thanks, -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADEFC433EF for ; Wed, 29 Sep 2021 16:29:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 480A1613DA for ; Wed, 29 Sep 2021 16:29:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 480A1613DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WY1vVt69d3XLhOjDHCvNeyCG6y9Q0x3Eu0ITOa14goc=; b=ZQFzBjvKZrTwQYbdgAt5slyJTv TRFWDDfMLtYmSzFwh/pcV3Uk6e8fGyfnGk3Hgd0HVh5rl8f9XF1vZX33LpcAUUpcGDKOZFP9rvnvI zi26gnbWdU/Zj/ENaRBnXZdFMJegppcggIG/TZy4lDkTFp/t7r/anqz2Jb0fRrqHI3wCf/vbPob1z a/t9XvjSswK6Y0wtqk8gt4qqEG3ZBCgz6lRwhaVIyMMhoH839ixTziJEntcgh1GPacX62qnd2I0f2 7Q6Qi9JcycUaEQ4qkpLD4Xf+H7dNPw8XtfGAt5QUnsgsIA2boIb31FjYZOHcPMPn07tWAJkewlRxH BxQXEm/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcQ5-00BoIQ-Ru; Wed, 29 Sep 2021 16:26:58 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcQ1-00BoH9-9w for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 16:26:54 +0000 Received: by mail-il1-x134.google.com with SMTP id d11so3490394ilc.8 for ; Wed, 29 Sep 2021 09:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nvuL53GG4ZKcbarpu9fgiT4nxY3Ya+EWac650T7Wl+I=; b=XcSO1sDId1+SHHk+UyucSVrt5zUeR7axtjojlaAXN0DgbbzXMhXDnUFvckaPx0VvMZ cujcoUirOyn/2fIBsEQRz3vJQM3mEGu6yHNJGY8JjQZ27Iae6AzJmf43K6+cCXS+gLZT jUcX3vab4MGz4Wr8bVEgG9ArDSyHd24GEMtvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nvuL53GG4ZKcbarpu9fgiT4nxY3Ya+EWac650T7Wl+I=; b=zkx5vSf23E7A5QHgHrETeipbiyKQskTagYn5/rmSePqpC9zbH35Bwm4lU+c4F1g74y ByLMuYNjsVaNykc2/E7rICorLAaWSPOe43vCRX9OEhnTH00yEA4Dc/+lv6D0b5ymxvo9 pVk+EEtgF+vAWNS88j5fOXIesBQFtnb5BNGVRUIe631bBcH45tcPbHjU1cjIwj9C15jS HfjP2eX3XNBQSLMxtfALovvRE+Y2fDtL3x43g6NkYefxDB8QjNRT92DKyspma1h6vXb6 UVldaRN+350ir9mpR1U2unxz/H+zFJf1v/Wlz+DZSjIp39KE3/uJW20EsebgucZTrCKE UZlg== X-Gm-Message-State: AOAM533H7wvHyHpGuhcvcD6gJwql0FZKYapeb9oNOco2VLIH+xptp3fP AflbtXOek/+AA3iCRXdK+479NQ== X-Google-Smtp-Source: ABdhPJwYGVu9LWWLKU5+zt5Dh26Qzuzn6kc/7fVZKzaYWO+hcZEhSaUyZdGsYCovA+0FCET8IyJEHQ== X-Received: by 2002:a05:6e02:1caa:: with SMTP id x10mr425573ill.280.1632932810795; Wed, 29 Sep 2021 09:26:50 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id q17sm133023iod.51.2021.09.29.09.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Sep 2021 09:26:50 -0700 (PDT) Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates To: Will Deacon , Mark Brown Cc: Catalin Marinas , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com, Shuah Khan References: <20210917120855.13858-1-broonie@kernel.org> <20210929143113.GA22029@willie-the-truck> <20210929144323.GQ4199@sirena.org.uk> <20210929153511.GB22029@willie-the-truck> From: Shuah Khan Message-ID: <1b573881-ef9f-c7ae-c08b-8079f63f66ec@linuxfoundation.org> Date: Wed, 29 Sep 2021 10:26:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210929153511.GB22029@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_092653_383104_DFD17981 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/29/21 9:35 AM, Will Deacon wrote: > On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote: >> On Wed, Sep 29, 2021 at 03:31:14PM +0100, Will Deacon wrote: >> >>> With this series applied, I see a test failing under qemu with: >> >>> # selftests: arm64: vec-syscfg >>> # TAP version 13 >>> # 1..10 >>> # ok 1 SVE default vector length 64 >>> # ok 2 # SKIP Need to be root to write to /proc >>> # ok 3 # SKIP Need to be root to write to /proc >> >> AFAICT this is due to running as a non-root user, the testsuite was >> already having serious issues before then... >> >>> # ok 4 SVE current VL is 64 >>> # ok 5 SVE set VL 64 and have VL 64 >>> # ok 6 # SKIP SVE only one VL supported >>> # ok 7 # SKIP SVE only one VL supported >>> # ok 8 # SKIP SVE only one VL supported >>> # ok 9 # SKIP SVE only one VL supported >>> # # SVE VL 272 returned 256 not maximum 0 >> >> ...as it's starting off by testing an interface that's only writable by >> root and then relying on that information, the existing tests were also >> not working usefully. qemu by default supports way more than one vector >> length. In any case it's just the test added by the last patch that's >> causing the output here, the first four patches should be fine and fix >> issues. >> >> I'm not sure it's a particularly good idea to run kselftest as a >> non-root user TBH, it's going to cause you to skip a lot of tests. > We don't want Kselftest default run to be as root. Users can choose to run as root which would be an explicit choice so they expect and plan for the impact. Example panic test. > Ah, thanks for pointing that out. It would probably be better to skip the > tests rather than fail them if they're not running with sufficient > permissions, but I'll go ahead and queue your v3 for now. > Correct. I would like to see tests skipped not failed if either config or permissions are lacking to run the tests. thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel