On 03/16/2017 09:17 PM, Fam Zheng wrote: > BDRVReplicationState.replication_state is a name with a bit of > duplication, plus it could be an enum like BDRVReplicationState.mode, > which is be more readable and also more straightforward in a debuuger. With the followup commit message cleanups, Reviewed-by: Eric Blake > > Rename it, and improve the type while at it. > > Signed-off-by: Fam Zheng > --- > block/replication.c | 44 ++++++++++++++++++++++---------------------- > 1 file changed, 22 insertions(+), 22 deletions(-) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org