Re: [PATCH] usb: usb-acpi: Fix oops due to freeing uninitialized pld pointer

[Mathias Nyman <mathias.nyman@linux.intel.com>]

On 18.3.2024 15.30, Aishwarya TCV wrote:
> 
> 
> On 08/03/2024 11:34, Mathias Nyman wrote:
>> If reading the ACPI _PLD port location object fails, or the port
>> doesn't have a _PLD ACPI object then the *pld pointer will remain
>> uninitialized and oops when freed.
>>
>> The patch that caused this is currently in next, on its way to v6.9.
>> So no need to add this to stable or current 6.8 kernel.
>>
>> Reported-by: Klara Modin <klarasmodin@gmail.com>
>> Closes: https://lore.kernel.org/linux-usb/7e92369a-3197-4883-9988-3c93452704f5@gmail.com/
>> Tested-by: Klara Modin <klarasmodin@gmail.com>
>> Fixes: f3ac348e6e04 ("usb: usb-acpi: Set port connect type of not connectable ports correctly")
>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>> ---
> 
> Hi Mathias,
> 
> When booting the kernel against next-master(next-20240318) with Arm64 on
> JUNO using ACPI, the kernel is resulting in boot failures for our CI.
> 
> A bisect identified f3ac348e6e04 ("usb: usb-acpi: Set port connect type
> of not connectable ports correctly") as introducing the failure.
> Bisected it on the tag "next-20240308" at repo
> "https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git".
> 
> I believe this is the patch to fix the issue. Kindly note that the
> failure is seen on next-master runs from the past week. Any chance that
> you could get this merged into next-master sooner?

Hi

We are already mid merge window.
Not sure if there's some way Greg can still get this in, otherwise I'm
afraid we need wait for rc1, and try to get this into rc2.

Thanks
Mathias