All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, MkfsSion <mkfssion@mkfssion.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] vl: Add -set options to device opts dict when using JSON syntax for -device
Date: Tue, 21 Dec 2021 15:47:41 +0100	[thread overview]
Message-ID: <1b8249e6-ffe1-86e4-a2e8-c85c794438e0@redhat.com> (raw)
In-Reply-To: <87h7b2i07h.fsf@dusky.pond.sub.org>

On 12/21/21 13:58, Markus Armbruster wrote:
>> Is this a regression?  I suspect commit 5dacda5167 "vl: Enable JSON
>> syntax for -device" (v6.2.0).
> Obviously not a regression: everything that used to work still works.
> 

FWIW I think -set should be deprecated.  I'm not aware of any 
particularly useful use of it.  There are a couple in the QEMU tests (in 
vhost-user-test and in qemu-iotests 068), but in both cases the code 
would be easier to follow without; patches can be dusted off if desired.

Paolo


  reply	other threads:[~2021-12-21 14:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21  7:18 [PATCH] vl: Add -set options to device opts dict when using JSON syntax for -device MkfsSion
2021-12-21 11:26 ` Markus Armbruster
2021-12-21 12:58   ` Markus Armbruster
2021-12-21 14:47     ` Paolo Bonzini [this message]
2021-12-21 15:40       ` Markus Armbruster
2021-12-21 17:20         ` Damien Hedde
2021-12-21 17:31         ` Damien Hedde
2021-12-22  8:22         ` Gerd Hoffmann
2021-12-22  9:37           ` Damien Hedde
2021-12-22 10:47             ` Gerd Hoffmann
2022-01-04 13:14           ` Daniel P. Berrangé
2021-12-22  5:54   ` MkfsSion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b8249e6-ffe1-86e4-a2e8-c85c794438e0@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mkfssion@mkfssion.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.