From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iwrs=PZ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B6AA1C43387
	for <netdev@archiver.kernel.org>; Thu, 17 Jan 2019 14:57:28 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8733F20851
	for <netdev@archiver.kernel.org>; Thu, 17 Jan 2019 14:57:28 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727777AbfAQO51 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 17 Jan 2019 09:57:27 -0500
Received: from szxga06-in.huawei.com ([45.249.212.32]:56124 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726913AbfAQO51 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 17 Jan 2019 09:57:27 -0500
Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60])
        by Forcepoint Email with ESMTP id E13E48B49EEEF430444E;
        Thu, 17 Jan 2019 22:57:24 +0800 (CST)
Received: from [127.0.0.1] (10.65.91.35) by DGGEMS410-HUB.china.huawei.com
 (10.3.19.210) with Microsoft SMTP Server id 14.3.408.0; Thu, 17 Jan 2019
 22:57:16 +0800
Subject: Re: Question about default m88e1510 LED configuration of marvell phy
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Wang Dongsheng <dongsheng.wang@hxt-semitech.com>,
        Andrew Lunn <andrew@lun>, David Miller <davem@davemloft.net>,
        <netdev@vger.kernel.org>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "lipeng (Y)" <lipeng321@huawei.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        Dengweiwei <dengweiwei@huawei.com>
References: <1a4ecb58-7835-85f9-51b7-88b0cfca7eba@huawei.com>
 <20190115033910.GA11722@lunn.ch>
 <b09f1de8-63ac-79c3-acf8-3533b0ec2e10@huawei.com>
 <20190116160434.GD29244@lunn.ch>
 <b6b8a26c-56ec-b81f-a9ca-ea9a35a24b84@huawei.com>
 <20190117124101.GA31080@lunn.ch>
From:   "shenjian (K)" <shenjian15@huawei.com>
Message-ID: <1b90c3b2-c62d-c268-e75d-00adf66f0ed3@huawei.com>
Date:   Thu, 17 Jan 2019 22:57:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20190117124101.GA31080@lunn.ch>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.65.91.35]
X-CFilter-Loop: Reflected
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org



在 2019/1/17 20:41, Andrew Lunn 写道:
> On Thu, Jan 17, 2019 at 10:58:07AM +0800, shenjian (K) wrote:
>>
>>
>> 在 2019/1/17 0:04, Andrew Lunn 写道:
>>>> Thanks, Andrew.
>>>>
>>>> But we are using acpi mode, is there any ohter way to poke values into registers ?
>>>
>>> You can register a PHY fixup.
>>>
>>> phy_register_fixup_for_uid(), mach-orion5x/dns323-setup.c
>>>
>>>       Andrew
>>>
>>> .
>>>
>> Thanks Andrew!
>>
>> I have tried phy_register_fixup_for_uid(), but it doesn't work .
> 
> Sorry for the brief reply.
> 
> Look closer at mach-orion5x/dns323-setup.c
> 
>       Andrew
> 
> .
> 
Do you mean I can define a  specified dev_flags, and set the default led value
to I wante, based on the flag in config_init() ?
Thanks!