From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3 4/4] net/vhost: add NULL pointer checking Date: Thu, 29 Mar 2018 15:19:43 +0200 Message-ID: <1b93fd09-9802-bff7-bea4-5b4839860983@redhat.com> References: <20180214145330.4679-1-zhiyong.yang@intel.com> <20180321030343.64399-1-zhiyong.yang@intel.com> <20180321030343.64399-5-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jianfeng.tan@intel.com, zhihong.wang@intel.com, thomas@monjalon.net, dong1.wang@intel.com, tiwei.bie@intel.com To: zhiyong.yang@intel.com, dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id A5EE32B82 for ; Thu, 29 Mar 2018 15:19:47 +0200 (CEST) In-Reply-To: <20180321030343.64399-5-zhiyong.yang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 03/21/2018 04:03 AM, zhiyong.yang@intel.com wrote: > When vhost user PMD works in client mode to connect/reconnect virtio-user > with server mode, new thread sometimes may run to new_device before > queue_setup has been done, So have to wait until memory allocation is > done. > > Release note is updated in the patch. > > Signed-off-by: Zhiyong Yang > --- > doc/guides/rel_notes/release_18_05.rst | 7 +++++++ > drivers/net/vhost/rte_eth_vhost.c | 9 +++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst > index 3923dc253..7b301f021 100644 > --- a/doc/guides/rel_notes/release_18_05.rst > +++ b/doc/guides/rel_notes/release_18_05.rst > @@ -41,6 +41,13 @@ New Features > Also, make sure to start the actual text at the margin. > ========================================================= > > +* **Added support for virtio-user server mode.** > + > + In a container environment if the vhost-user backend restarts, there's no way > + for it to reconnect to virtio-user. To address this, support for server mode > + is added. In this mode the socket file is created by virtio-user, which the > + backend then connects to. This means that if the backend restarts, it can > + reconnect to virtio-user and continue communications. I think this shouldn't be part of this patch. > > API Changes > ----------- > diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c > index 3aae01c39..2490bad0b 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -580,6 +580,15 @@ new_device(int vid) > eth_dev->data->numa_node = newnode; > #endif > > + /* The thread may run here before eth_dev->data->rx_queues or > + * eth_dev->data->tx_queues have gotten valid memory, so have to > + * wait until memory allocation is done. > + */ > + while (!eth_dev->data->rx_queues || > + !eth_dev->data->tx_queues) { > + usleep(1); > + } > + > for (i = 0; i < eth_dev->data->nb_rx_queues; i++) { > vq = eth_dev->data->rx_queues[i]; > if (vq == NULL) > I don't like the idea of polling here. It looks like Junjie is addressing the problem in a different way [0], do you confirm it would work in your case? Thanks, Maxime [0]: http://dpdk.org/dev/patchwork/patch/36643/