All of lore.kernel.org
 help / color / mirror / Atom feed
* "resolve_btfids: unresolved" warnings while building v5.16-rc1
@ 2021-11-15 13:34 Pavel Skripkin
  2021-11-15 14:17 ` Kumar Kartikeya Dwivedi
  2022-01-25 20:29 ` "resolve_btfids: unresolved symbol" warnings while building v5.17-rc1 Pavel Skripkin
  0 siblings, 2 replies; 6+ messages in thread
From: Pavel Skripkin @ 2021-11-15 13:34 UTC (permalink / raw)
  To: memxor, ast, Jakub Kicinski, David S. Miller; +Cc: netdev, bpf

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Hi, net/bpf developers!

While building newest kernel for fuzzing I met following warnings:

```
   BTFIDS  vmlinux
WARN: resolve_btfids: unresolved symbol tcp_dctcp_kfunc_ids
WARN: resolve_btfids: unresolved symbol tcp_cubic_kfunc_ids
WARN: resolve_btfids: unresolved symbol tcp_bbr_kfunc_ids
   SORTTAB vmlinux

```

I haven't seen such warnings before and have no idea are they important 
or not. Config is attached.

My host is openSUSE Tumbleweed with gcc (SUSE Linux) 10.3.1 20210707 
[revision 048117e16c77f82598fca9af585500572d46ad73] if it's important :)



With regards,
Pavel Skripkin

[-- Attachment #2: .config --]
[-- Type: application/x-config, Size: 225751 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "resolve_btfids: unresolved" warnings while building v5.16-rc1
  2021-11-15 13:34 "resolve_btfids: unresolved" warnings while building v5.16-rc1 Pavel Skripkin
@ 2021-11-15 14:17 ` Kumar Kartikeya Dwivedi
  2021-11-15 17:27   ` Kumar Kartikeya Dwivedi
  2022-01-25 20:29 ` "resolve_btfids: unresolved symbol" warnings while building v5.17-rc1 Pavel Skripkin
  1 sibling, 1 reply; 6+ messages in thread
From: Kumar Kartikeya Dwivedi @ 2021-11-15 14:17 UTC (permalink / raw)
  To: Pavel Skripkin; +Cc: ast, Jakub Kicinski, David S. Miller, netdev, bpf

On Mon, Nov 15, 2021 at 07:04:51PM IST, Pavel Skripkin wrote:
> Hi, net/bpf developers!
>
> While building newest kernel for fuzzing I met following warnings:
>
> ```
>   BTFIDS  vmlinux
> WARN: resolve_btfids: unresolved symbol tcp_dctcp_kfunc_ids
> WARN: resolve_btfids: unresolved symbol tcp_cubic_kfunc_ids
> WARN: resolve_btfids: unresolved symbol tcp_bbr_kfunc_ids
>   SORTTAB vmlinux
>
> ```
>
> I haven't seen such warnings before and have no idea are they important or
> not. Config is attached.
>
> My host is openSUSE Tumbleweed with gcc (SUSE Linux) 10.3.1 20210707
> [revision 048117e16c77f82598fca9af585500572d46ad73] if it's important :)
>
>

I'll take a look later today.

>
> With regards,
> Pavel Skripkin

--
Kartikeya

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "resolve_btfids: unresolved" warnings while building v5.16-rc1
  2021-11-15 14:17 ` Kumar Kartikeya Dwivedi
@ 2021-11-15 17:27   ` Kumar Kartikeya Dwivedi
  2021-11-16  6:25     ` Andrii Nakryiko
  0 siblings, 1 reply; 6+ messages in thread
From: Kumar Kartikeya Dwivedi @ 2021-11-15 17:27 UTC (permalink / raw)
  To: Pavel Skripkin
  Cc: ast, Jakub Kicinski, David S. Miller, netdev, bpf, Andrii Nakryiko

On Mon, Nov 15, 2021 at 07:47:35PM IST, Kumar Kartikeya Dwivedi wrote:
> On Mon, Nov 15, 2021 at 07:04:51PM IST, Pavel Skripkin wrote:
> > Hi, net/bpf developers!
> >
> > While building newest kernel for fuzzing I met following warnings:
> >
> > ```
> >   BTFIDS  vmlinux
> > WARN: resolve_btfids: unresolved symbol tcp_dctcp_kfunc_ids
> > WARN: resolve_btfids: unresolved symbol tcp_cubic_kfunc_ids
> > WARN: resolve_btfids: unresolved symbol tcp_bbr_kfunc_ids
> >   SORTTAB vmlinux
> >
> > ```

+Cc Andrii

So the reason should be CONFIG_DYNAMIC_FTRACE=n, when that is turned off,
all these three BTF sets should be empty. Earlier they were all part of the
set in bpf_tcp_ca.c, which would never be empty, so there was no warning.

I guess we can demote that warning to debug, but not sure, since it isn't
limited to BTF sets, but also other symbols (e.g. kernel functions referenced in
.BTF_ids).

The other option is to add a dummy function in the set so that set->cnt != 0.

> >
> > I haven't seen such warnings before and have no idea are they important or
> > not. Config is attached.
> >
> > My host is openSUSE Tumbleweed with gcc (SUSE Linux) 10.3.1 20210707
> > [revision 048117e16c77f82598fca9af585500572d46ad73] if it's important :)
> >
> >
>
> I'll take a look later today.
>
> >
> > With regards,
> > Pavel Skripkin
>
> --
> Kartikeya

--
Kartikeya

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "resolve_btfids: unresolved" warnings while building v5.16-rc1
  2021-11-15 17:27   ` Kumar Kartikeya Dwivedi
@ 2021-11-16  6:25     ` Andrii Nakryiko
  0 siblings, 0 replies; 6+ messages in thread
From: Andrii Nakryiko @ 2021-11-16  6:25 UTC (permalink / raw)
  To: Kumar Kartikeya Dwivedi, Jiri Olsa
  Cc: Pavel Skripkin, Alexei Starovoitov, Jakub Kicinski,
	David S. Miller, Networking, bpf, Andrii Nakryiko

On Mon, Nov 15, 2021 at 9:27 AM Kumar Kartikeya Dwivedi
<memxor@gmail.com> wrote:
>
> On Mon, Nov 15, 2021 at 07:47:35PM IST, Kumar Kartikeya Dwivedi wrote:
> > On Mon, Nov 15, 2021 at 07:04:51PM IST, Pavel Skripkin wrote:
> > > Hi, net/bpf developers!
> > >
> > > While building newest kernel for fuzzing I met following warnings:
> > >
> > > ```
> > >   BTFIDS  vmlinux
> > > WARN: resolve_btfids: unresolved symbol tcp_dctcp_kfunc_ids
> > > WARN: resolve_btfids: unresolved symbol tcp_cubic_kfunc_ids
> > > WARN: resolve_btfids: unresolved symbol tcp_bbr_kfunc_ids
> > >   SORTTAB vmlinux
> > >
> > > ```
>
> +Cc Andrii

+Cc Jiri ;)

>
> So the reason should be CONFIG_DYNAMIC_FTRACE=n, when that is turned off,
> all these three BTF sets should be empty. Earlier they were all part of the
> set in bpf_tcp_ca.c, which would never be empty, so there was no warning.
>
> I guess we can demote that warning to debug, but not sure, since it isn't

It's a real warning, since when hiding a warning is the right thing to do?

Jiri, does resolve_btfids emit this warning when we get an empty set?
I'd expect not (empty set is totally reasonable in some cases), but
who knows. Can you please help understand this?

> limited to BTF sets, but also other symbols (e.g. kernel functions referenced in
> .BTF_ids).
>
> The other option is to add a dummy function in the set so that set->cnt != 0.
>
> > >
> > > I haven't seen such warnings before and have no idea are they important or
> > > not. Config is attached.
> > >
> > > My host is openSUSE Tumbleweed with gcc (SUSE Linux) 10.3.1 20210707
> > > [revision 048117e16c77f82598fca9af585500572d46ad73] if it's important :)
> > >
> > >
> >
> > I'll take a look later today.
> >
> > >
> > > With regards,
> > > Pavel Skripkin
> >
> > --
> > Kartikeya
>
> --
> Kartikeya

^ permalink raw reply	[flat|nested] 6+ messages in thread

* "resolve_btfids: unresolved symbol" warnings while building v5.17-rc1
  2021-11-15 13:34 "resolve_btfids: unresolved" warnings while building v5.16-rc1 Pavel Skripkin
  2021-11-15 14:17 ` Kumar Kartikeya Dwivedi
@ 2022-01-25 20:29 ` Pavel Skripkin
  2022-01-25 20:42   ` Alexei Starovoitov
  1 sibling, 1 reply; 6+ messages in thread
From: Pavel Skripkin @ 2022-01-25 20:29 UTC (permalink / raw)
  To: memxor, ast, Jakub Kicinski, David S. Miller; +Cc: netdev, bpf

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On 11/15/21 16:34, Pavel Skripkin wrote:
> Hi, net/bpf developers!
> 
> While building newest kernel for fuzzing I met following warnings:
> 
> ```
>     BTFIDS  vmlinux
> WARN: resolve_btfids: unresolved symbol tcp_dctcp_kfunc_ids
> WARN: resolve_btfids: unresolved symbol tcp_cubic_kfunc_ids
> WARN: resolve_btfids: unresolved symbol tcp_bbr_kfunc_ids
>     SORTTAB vmlinux
> 
> ```
> 
> I haven't seen such warnings before and have no idea are they important
> or not. Config is attached.
> 
> My host is openSUSE Tumbleweed with gcc (SUSE Linux) 10.3.1 20210707
> [revision 048117e16c77f82598fca9af585500572d46ad73] if it's important :)
> 
> 

Hi Kumar and other net/bpf developers!,

while building v5.17-rc1 (0280e3c58f92b2fe0e8fbbdf8d386449168de4a8) with 
mostly random config I met this warning

```
WARN: resolve_btfids: unresolved symbol bpf_lsm_task_getsecid_subj
```

config attached. Thanks!



With regards,
Pavel Skripkin

[-- Attachment #2: .config --]
[-- Type: application/x-config, Size: 227690 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: "resolve_btfids: unresolved symbol" warnings while building v5.17-rc1
  2022-01-25 20:29 ` "resolve_btfids: unresolved symbol" warnings while building v5.17-rc1 Pavel Skripkin
@ 2022-01-25 20:42   ` Alexei Starovoitov
  0 siblings, 0 replies; 6+ messages in thread
From: Alexei Starovoitov @ 2022-01-25 20:42 UTC (permalink / raw)
  To: Pavel Skripkin
  Cc: Kumar Kartikeya Dwivedi, Alexei Starovoitov, Jakub Kicinski,
	David S. Miller, Network Development, bpf

On Tue, Jan 25, 2022 at 12:29 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> On 11/15/21 16:34, Pavel Skripkin wrote:
> > Hi, net/bpf developers!
> >
> > While building newest kernel for fuzzing I met following warnings:
> >
> > ```
> >     BTFIDS  vmlinux
> > WARN: resolve_btfids: unresolved symbol tcp_dctcp_kfunc_ids
> > WARN: resolve_btfids: unresolved symbol tcp_cubic_kfunc_ids
> > WARN: resolve_btfids: unresolved symbol tcp_bbr_kfunc_ids
> >     SORTTAB vmlinux
> >
> > ```
> >
> > I haven't seen such warnings before and have no idea are they important
> > or not. Config is attached.
> >
> > My host is openSUSE Tumbleweed with gcc (SUSE Linux) 10.3.1 20210707
> > [revision 048117e16c77f82598fca9af585500572d46ad73] if it's important :)
> >
> >
>
> Hi Kumar and other net/bpf developers!,
>
> while building v5.17-rc1 (0280e3c58f92b2fe0e8fbbdf8d386449168de4a8) with
> mostly random config I met this warning
>
> ```
> WARN: resolve_btfids: unresolved symbol bpf_lsm_task_getsecid_subj
> ```

Thanks for the report.
It's already fixed in bpf tree.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-25 20:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 13:34 "resolve_btfids: unresolved" warnings while building v5.16-rc1 Pavel Skripkin
2021-11-15 14:17 ` Kumar Kartikeya Dwivedi
2021-11-15 17:27   ` Kumar Kartikeya Dwivedi
2021-11-16  6:25     ` Andrii Nakryiko
2022-01-25 20:29 ` "resolve_btfids: unresolved symbol" warnings while building v5.17-rc1 Pavel Skripkin
2022-01-25 20:42   ` Alexei Starovoitov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.