From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Leon Romanovsky <leon@kernel.org>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>
Cc: Leon Romanovsky <leonro@mellanox.com>,
linux-um <linux-um@lists.infradead.org>
Subject: Re: [PATCH 2/2] um: Delete never executed timer
Date: Thu, 20 Feb 2020 19:36:13 +0000 [thread overview]
Message-ID: <1b9d7916-92b6-c438-274a-4198e97827b2@cambridgegreys.com> (raw)
In-Reply-To: <20200220084014.238768-3-leon@kernel.org>
On 20/02/2020 08:40, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
>
> The "#ifdef undef" construction effectively disabled the timer.
> It causes to the fact that this timer did nothing, so delete it.
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> arch/um/drivers/net_kern.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
> index af07733c2dc8..1802cf4ef5a5 100644
> --- a/arch/um/drivers/net_kern.c
> +++ b/arch/um/drivers/net_kern.c
> @@ -274,17 +274,6 @@ static const struct ethtool_ops uml_net_ethtool_ops = {
> .get_ts_info = ethtool_op_get_ts_info,
> };
>
> -static void uml_net_user_timer_expire(struct timer_list *t)
> -{
> -#ifdef undef
> - struct uml_net_private *lp = from_timer(lp, t, tl);
> - struct connection *conn = &lp->user;
> -
> - dprintk(KERN_INFO "uml_net_user_timer_expire [%p]\n", conn);
> - do_connect(conn);
> -#endif
> -}
> -
> void uml_net_setup_etheraddr(struct net_device *dev, char *str)
> {
> unsigned char *addr = dev->dev_addr;
> @@ -455,7 +444,6 @@ static void eth_configure(int n, void *init, char *mac,
> .add_address = transport->user->add_address,
> .delete_address = transport->user->delete_address });
>
> - timer_setup(&lp->tl, uml_net_user_timer_expire, 0);
> spin_lock_init(&lp->lock);
> memcpy(lp->mac, dev->dev_addr, sizeof(lp->mac));
>
> --
> 2.24.1
>
>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2020-02-20 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 8:40 [PATCH 0/2] Remove dead code and driver version Leon Romanovsky
2020-02-20 8:40 ` [PATCH 1/2] um: Don't overwrite ethtool " Leon Romanovsky
2020-02-20 19:35 ` Anton Ivanov
2020-03-29 21:38 ` Richard Weinberger
2020-03-30 7:22 ` Leon Romanovsky
2020-02-20 8:40 ` [PATCH 2/2] um: Delete never executed timer Leon Romanovsky
2020-02-20 19:36 ` Anton Ivanov [this message]
2020-02-20 19:35 ` [PATCH 0/2] Remove dead code and driver version Anton Ivanov
2020-02-23 10:51 ` Leon Romanovsky
2020-02-23 19:58 ` Anton Ivanov
2020-02-24 16:45 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9d7916-92b6-c438-274a-4198e97827b2@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=jdike@addtoit.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.