From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A147CC433EF for ; Thu, 2 Dec 2021 14:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358389AbhLBOHm (ORCPT ); Thu, 2 Dec 2021 09:07:42 -0500 Received: from sin.source.kernel.org ([145.40.73.55]:53644 "EHLO sin.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346972AbhLBOHl (ORCPT ); Thu, 2 Dec 2021 09:07:41 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 63898CE22F9 for ; Thu, 2 Dec 2021 14:04:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B80C2C00446; Thu, 2 Dec 2021 14:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638453855; bh=5v11wuwoWmcBaHc5VRNqR3MfF8jXLA5MgIqvuA5C/UM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tgSj4VgQZ8YFojjMD128a/fjnqh4u4zKL6lc+xauUDAYNp3p1p6ZfBfjoCRvYWUif sya/XFZ52eFnLz5qhdLGqoToZ7W8j2CUDPGbUmcjo4mRaSSk9OH3Zfpb3vkvHTEVUt 0ZkKawR/S97teDiKIVbR/IoADenvFkeRFDOBf5Uu4PRoimS3rLyvXIFiDN8jMkRg7o JNDo05Z1sHfukPbMiofWgcowXu0HfFc8QQdZ2oQbVB4X60e4u36SoIhEC6Y1HDrzx6 HwkMOhTt/WkQt45ma6GZjI2Bj6WnNuhNy27ZeaAoSQRXrDFkYibJmNm56Y1Dq+bLOV 5l+BKzAjSPVyA== Message-ID: <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> Date: Thu, 2 Dec 2021 22:04:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations Content-Language: en-US To: Eric Biggers Cc: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-5-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/12/2 12:15, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: >> Why not relocating this check before f2fs_map_blocks()? Wait, it supports DIO in multi-device image after commit 71f2c8206202 ("f2fs: multidevice: support direct IO"), how about checking with f2fs_allow_multi_device_dio()? Thanks, >> >> Thanks, >> >>> + iomap->bdev = inode->i_sb->s_bdev; > > Are you talking about the check for !f2fs_is_multi_device()? It could go in > either location, but I think it makes the most sense to have it right before the > line that uses 'inode->i_sb->s_bdev', since that is the place which makes the > assumption that the filesystem has only one block device. > > - Eric > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6BADC433F5 for ; Thu, 2 Dec 2021 14:04:36 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1msmhP-0007n1-7X; Thu, 02 Dec 2021 14:04:35 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1msmhO-0007mv-E5 for linux-f2fs-devel@lists.sourceforge.net; Thu, 02 Dec 2021 14:04:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=elcFJP4tShqU1xBgHrUQB6kdWN2w+uj0gsTKiDnTgUc=; b=FE+cGJ9DSe21Q6NW73lwbhYrrE KLTTx0sX3v2DRJ4v5WndJFRc1toMWg8nhtFYseq6jWpe9pqvndl2fD1gpo/X98FWci/CiWuI+BL/P YQEHHByv1OJfb52pV7SQ5C0bfEcz2SOhWoN2c9M9WZG5BMjUo/sjYGhWwN+paJE+ItTw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=elcFJP4tShqU1xBgHrUQB6kdWN2w+uj0gsTKiDnTgUc=; b=ehSkiWXgdcx8ehM3zxodbMkesj p0Ef4Zlmomt1bwaETR+dhXdO4o5xugVyLdQL96upapLvdbeM1ajYHscjvReWsexQ+OhjORWElptPi zGOgEovmdo5tUFHJAZIIDgezVVoaJJMTyI4KWpQEWcp6kB3DcTJRb+48plkXoNixFlqM=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1msmhM-0000Zl-2i for linux-f2fs-devel@lists.sourceforge.net; Thu, 02 Dec 2021 14:04:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5A3CACE21BE for ; Thu, 2 Dec 2021 14:04:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B80C2C00446; Thu, 2 Dec 2021 14:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638453855; bh=5v11wuwoWmcBaHc5VRNqR3MfF8jXLA5MgIqvuA5C/UM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tgSj4VgQZ8YFojjMD128a/fjnqh4u4zKL6lc+xauUDAYNp3p1p6ZfBfjoCRvYWUif sya/XFZ52eFnLz5qhdLGqoToZ7W8j2CUDPGbUmcjo4mRaSSk9OH3Zfpb3vkvHTEVUt 0ZkKawR/S97teDiKIVbR/IoADenvFkeRFDOBf5Uu4PRoimS3rLyvXIFiDN8jMkRg7o JNDo05Z1sHfukPbMiofWgcowXu0HfFc8QQdZ2oQbVB4X60e4u36SoIhEC6Y1HDrzx6 HwkMOhTt/WkQt45ma6GZjI2Bj6WnNuhNy27ZeaAoSQRXrDFkYibJmNm56Y1Dq+bLOV 5l+BKzAjSPVyA== Message-ID: <1ba0f002-42c7-b085-0c54-6071664ba79b@kernel.org> Date: Thu, 2 Dec 2021 22:04:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-US To: Eric Biggers References: <20211116214510.2934905-1-jaegeuk@kernel.org> <20211116214510.2934905-5-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: X-Headers-End: 1msmhM-0000Zl-2i Subject: Re: [f2fs-dev] [PATCH 5/6] f2fs: implement iomap operations X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/12/2 12:15, Eric Biggers wrote: > On Thu, Dec 02, 2021 at 11:10:41AM +0800, Chao Yu wrote: >> Why not relocating this check before f2fs_map_blocks()? Wait, it supports DIO in multi-device image after commit 71f2c8206202 ("f2fs: multidevice: support direct IO"), how about checking with f2fs_allow_multi_device_dio()? Thanks, >> >> Thanks, >> >>> + iomap->bdev = inode->i_sb->s_bdev; > > Are you talking about the check for !f2fs_is_multi_device()? It could go in > either location, but I think it makes the most sense to have it right before the > line that uses 'inode->i_sb->s_bdev', since that is the place which makes the > assumption that the filesystem has only one block device. > > - Eric > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel