From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109AEC4363D for ; Tue, 22 Sep 2020 14:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF4C52395B for ; Tue, 22 Sep 2020 14:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="B/5nuZLA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726652AbgIVOR2 (ORCPT ); Tue, 22 Sep 2020 10:17:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbgIVOR2 (ORCPT ); Tue, 22 Sep 2020 10:17:28 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7850AC0613CF for ; Tue, 22 Sep 2020 07:17:28 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id n10so15648915qtv.3 for ; Tue, 22 Sep 2020 07:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lmkHKvhQWDjy+TPo22EHdOgINUlzo9nTiFY5Hb0YDxM=; b=B/5nuZLAvXsPd0HbDGqEtCTbRDrbaW+Ahog57XmRWZbdi72gGySJDcZ97+tu1S+iCo z38wzWlR1P90JbtFhJsDq6+oa7PXSr3XCqxYhVQe/2dK3JFhDEYitjVCVxjKhQ8o0N8q xWKndrOiX3e/0VdNthkK4/2RSW6pQOk8y1NI+VVs9HK4g30LZCJd+WbuyIu5xTqxNghA pazukkPmTuEsEFvPmPniv9PR4wNHs/4P2+usRjr/hDkT39h5Yibtvx2TKlmSvI0kvsOl d8gXWljBFXMiW7RNRLtWMo2WqvL7no8FtglhFiEnRtYFhwLkJspDdoWbXkDkPoIeJ5mL FDhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lmkHKvhQWDjy+TPo22EHdOgINUlzo9nTiFY5Hb0YDxM=; b=G1Vv1Z+KH2oyfP8fc5Ggeds+fX3idCCkbURRLMIdGZvy7hisfK4ocw8Jb1sTB7be+i nVNIGRjPdh53ZiTuXcrUcihaxafBZ3dLa3gW1uenc7Ly3hbq+PRi/XAQrR1E77LjfNJ3 2R7s/OwYaFmyjJJ/5NeHguFy1vdXsRy2j2xjt3pTRF76vK370LzjnTaAJxIGaJcu8YvD /HO2zzqTJDDkRNyxZeaJhg97BfNi+P3xH9rB0ZU36BwxFYy2SeJeYKzL9VbNBopKq9c4 CacCMx6d3q0SbaadMyp6ysAfWGDzNuaEUvCVEnXKbfWGFeLxim/4uw4SQAmLvC0oPY6F w/gg== X-Gm-Message-State: AOAM532N976yzo/atW0EzTMlVlhkX3HY1OPg8tiLGsltg/bI6sWJ2UzC aNJrkvq85/FVXuQPea/7WpI0Yg== X-Google-Smtp-Source: ABdhPJw5TArAbezCs6y4WdY7u+7Q0dIOg4VjIbajRbOzmLSW19Gzpk9ulisDTEP/g/y6n6lJWIh5nw== X-Received: by 2002:ac8:33ec:: with SMTP id d41mr4933258qtb.390.1600784247688; Tue, 22 Sep 2020 07:17:27 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id p3sm11561735qkj.113.2020.09.22.07.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Sep 2020 07:17:27 -0700 (PDT) Subject: Re: [PATCH 02/15] btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK To: Goldwyn Rodrigues , linux-fsdevel@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, david@fromorbit.com, hch@lst.de, johannes.thumshirn@wdc.com, dsterba@suse.com, darrick.wong@oracle.com, Goldwyn Rodrigues , Nikolay Borisov , Johannes Thumshirn References: <20200921144353.31319-1-rgoldwyn@suse.de> <20200921144353.31319-3-rgoldwyn@suse.de> From: Josef Bacik Message-ID: <1ba34100-4c3d-2fd6-528b-a16efedeee25@toxicpanda.com> Date: Tue, 22 Sep 2020 10:17:25 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200921144353.31319-3-rgoldwyn@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 9/21/20 10:43 AM, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Since we now perform direct reads using i_rwsem, we can remove this > inode flag used to co-ordinate unlocked reads. > > The truncate call takes i_rwsem. This means it is correctly synchronized > with concurrent direct reads. > > Reviewed-by: Nikolay Borisov > Reviewed-by: Johannes Thumshirn > Signed-off-by: Goldwyn Rodrigues Reviewed-by: Josef Bacik Thanks, Josef