From: Quentin Schulz <quentin.schulz@free-electrons.com> To: Icenowy Zheng <icenowy@aosc.io>, Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, Jonathan Cameron <jic23@kernel.org>, Lee Jones <lee.jones@linaro.org> Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Date: Mon, 25 Sep 2017 10:48:54 +0200 [thread overview] Message-ID: <1ba65180-9f13-0ef4-9213-1b20f15b5bdb@free-electrons.com> (raw) In-Reply-To: <20170920151814.22461-4-icenowy@aosc.io> Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > AXP803 SoC features an ADC part including these channels: GPADC (GPIO0) > and TS pins, PMIC internal temperature sensor, battery voltage, battery > charge/discharge current. > > Add support for the battery-related channels and internal temperature > channel in order to allow battery monitoring. The TS and GPADC channels > are complex and will be support after more investigation. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > drivers/iio/adc/axp20x_adc.c | 108 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > > diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c > index 93dd6b80059e..4f0cd98cf6ea 100644 > --- a/drivers/iio/adc/axp20x_adc.c > +++ b/drivers/iio/adc/axp20x_adc.c > @@ -28,6 +28,8 @@ [...]> /* > + * AXP803 shares the same consumer map with AXP22x, as it has no ADC for > + * VBUS and ACIN inputs either. > + */ > + > +/* Put that in the commit log? If we add a comment for each newly supported PMIC we will end up with more comments than code :) [...]> > +static const struct axp_data axp803_data = { > + .iio_info = &axp803_adc_iio_info, > + .num_channels = ARRAY_SIZE(axp803_adc_channels), > + .channels = axp803_adc_channels, > + .adc_en1_mask = AXP803_ADC_EN1_MASK, > + .adc_en2 = false, Not required I guess, by default it is false. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID
From: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Date: Mon, 25 Sep 2017 10:48:54 +0200 [thread overview] Message-ID: <1ba65180-9f13-0ef4-9213-1b20f15b5bdb@free-electrons.com> (raw) In-Reply-To: <20170920151814.22461-4-icenowy-h8G6r0blFSE@public.gmane.org> Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > AXP803 SoC features an ADC part including these channels: GPADC (GPIO0) > and TS pins, PMIC internal temperature sensor, battery voltage, battery > charge/discharge current. > > Add support for the battery-related channels and internal temperature > channel in order to allow battery monitoring. The TS and GPADC channels > are complex and will be support after more investigation. > > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> > --- > drivers/iio/adc/axp20x_adc.c | 108 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > > diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c > index 93dd6b80059e..4f0cd98cf6ea 100644 > --- a/drivers/iio/adc/axp20x_adc.c > +++ b/drivers/iio/adc/axp20x_adc.c > @@ -28,6 +28,8 @@ [...]> /* > + * AXP803 shares the same consumer map with AXP22x, as it has no ADC for > + * VBUS and ACIN inputs either. > + */ > + > +/* Put that in the commit log? If we add a comment for each newly supported PMIC we will end up with more comments than code :) [...]> > +static const struct axp_data axp803_data = { > + .iio_info = &axp803_adc_iio_info, > + .num_channels = ARRAY_SIZE(axp803_adc_channels), > + .channels = axp803_adc_channels, > + .adc_en1_mask = AXP803_ADC_EN1_MASK, > + .adc_en2 = false, Not required I guess, by default it is false. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID
From: quentin.schulz@free-electrons.com (Quentin Schulz) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Date: Mon, 25 Sep 2017 10:48:54 +0200 [thread overview] Message-ID: <1ba65180-9f13-0ef4-9213-1b20f15b5bdb@free-electrons.com> (raw) In-Reply-To: <20170920151814.22461-4-icenowy@aosc.io> Hi Icenowy, On 20/09/2017 17:18, Icenowy Zheng wrote: > AXP803 SoC features an ADC part including these channels: GPADC (GPIO0) > and TS pins, PMIC internal temperature sensor, battery voltage, battery > charge/discharge current. > > Add support for the battery-related channels and internal temperature > channel in order to allow battery monitoring. The TS and GPADC channels > are complex and will be support after more investigation. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > drivers/iio/adc/axp20x_adc.c | 108 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > > diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c > index 93dd6b80059e..4f0cd98cf6ea 100644 > --- a/drivers/iio/adc/axp20x_adc.c > +++ b/drivers/iio/adc/axp20x_adc.c > @@ -28,6 +28,8 @@ [...]> /* > + * AXP803 shares the same consumer map with AXP22x, as it has no ADC for > + * VBUS and ACIN inputs either. > + */ > + > +/* Put that in the commit log? If we add a comment for each newly supported PMIC we will end up with more comments than code :) [...]> > +static const struct axp_data axp803_data = { > + .iio_info = &axp803_adc_iio_info, > + .num_channels = ARRAY_SIZE(axp803_adc_channels), > + .channels = axp803_adc_channels, > + .adc_en1_mask = AXP803_ADC_EN1_MASK, > + .adc_en2 = false, Not required I guess, by default it is false. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2017-09-25 8:49 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-20 15:18 [RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-25 9:14 ` Quentin Schulz 2017-09-25 9:14 ` Quentin Schulz 2017-09-25 9:14 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-25 7:20 ` Quentin Schulz 2017-09-25 7:20 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-24 14:32 ` Jonathan Cameron 2017-09-24 14:32 ` Jonathan Cameron 2017-09-24 14:32 ` Jonathan Cameron 2017-09-25 8:48 ` Quentin Schulz [this message] 2017-09-25 8:48 ` Quentin Schulz 2017-09-25 8:48 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803 Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-24 14:34 ` Jonathan Cameron 2017-09-24 14:34 ` Jonathan Cameron 2017-09-24 14:34 ` Jonathan Cameron 2017-09-25 8:58 ` Quentin Schulz 2017-09-25 8:58 ` Quentin Schulz 2017-09-25 8:58 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-25 9:11 ` Quentin Schulz 2017-09-25 9:11 ` Quentin Schulz 2017-09-25 9:11 ` Quentin Schulz 2017-09-25 9:14 ` Icenowy Zheng 2017-09-25 9:14 ` Icenowy Zheng 2017-09-25 9:14 ` Icenowy Zheng 2017-09-25 9:19 ` [linux-sunxi] " Chen-Yu Tsai 2017-09-25 9:19 ` Chen-Yu Tsai 2017-09-25 9:19 ` Chen-Yu Tsai 2017-09-25 9:19 ` Chen-Yu Tsai 2017-09-25 9:24 ` Quentin Schulz 2017-09-25 9:24 ` Quentin Schulz 2017-09-25 9:24 ` Quentin Schulz 2017-09-20 15:18 ` [RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64 Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-20 15:18 ` Icenowy Zheng 2017-09-21 14:46 ` [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron 2017-09-21 14:46 ` Jonathan Cameron 2017-09-21 14:46 ` Jonathan Cameron 2017-09-21 15:20 ` Icenowy Zheng 2017-09-21 15:20 ` Icenowy Zheng 2017-09-21 15:20 ` Icenowy Zheng 2017-09-24 14:36 ` Jonathan Cameron 2017-09-24 14:36 ` Jonathan Cameron 2017-09-25 9:22 ` Quentin Schulz 2017-09-25 9:22 ` Quentin Schulz 2017-09-25 9:22 ` Quentin Schulz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1ba65180-9f13-0ef4-9213-1b20f15b5bdb@free-electrons.com \ --to=quentin.schulz@free-electrons.com \ --cc=devicetree@vger.kernel.org \ --cc=icenowy@aosc.io \ --cc=jic23@kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=maxime.ripard@free-electrons.com \ --cc=wens@csie.org \ --subject='Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.