All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Sebastiano Miano <mianosebastiano@gmail.com>, cocci@inria.fr
Subject: Re: [cocci] Replace custom function multiple times
Date: Fri, 4 Nov 2022 10:31:00 +0100 (CET)	[thread overview]
Message-ID: <1baafdcd-4e98-af8e-4697-bf37c43c6135@inria.fr> (raw)
In-Reply-To: <3a2a50ba-8c30-43c5-354c-7b194eea8df0@web.de>

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]



On Fri, 4 Nov 2022, Markus Elfring wrote:

> >> @searching@
> >> expression path, fn;
> >> @@
> >>  MERGE_FUNCTION_OPENED(path, fn, ...);
>
> Do you find the metavariable type “constant char[]” more appropriate here?

This is a reasonable suggestion.  But if the rule works as is, then it's
already fine.

julia

>
>
>
> >> @script:python generation@
> >> path << searching.path;
> >> fn << searching.fn;
> >> new_fn;
> >> include_name;
> >> @@
> >> coccinelle.new_fn = cocci.make_expr(fn.strip('\"'))
>
>
> Are ordinary function names passed by string literals instead of detailed expressions?
> How do you think about to use the method “make_ident” here?
>
> Regards,
> Markus
>
>

  reply	other threads:[~2022-11-04  9:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 17:02 [cocci] Replace custom function multiple times Sebastiano Miano
2022-11-02 17:30 ` Julia Lawall
2022-11-02 17:56   ` Sebastiano Miano
2022-11-02 19:15 ` Markus Elfring
2022-11-03 10:51   ` Sebastiano Miano
2022-11-03 12:33     ` Julia Lawall
2022-11-03 13:26     ` Markus Elfring
2022-11-04  8:30     ` Markus Elfring
2022-11-04  9:31       ` Julia Lawall [this message]
2022-11-04  9:48         ` Markus Elfring
2022-11-03 13:07   ` Markus Elfring
2022-11-03 15:28     ` Julia Lawall
2022-11-03 15:50       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1baafdcd-4e98-af8e-4697-bf37c43c6135@inria.fr \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@inria.fr \
    --cc=mianosebastiano@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.