From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [RESEND Patch 2/4] gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle Date: Thu, 11 Aug 2016 12:21:02 +0300 Message-ID: <1bae4a9c-fee3-771f-9ae3-3e5eb6268dbf@ti.com> References: <1468552625-23546-1-git-send-email-peter.chen@nxp.com> <1468552625-23546-3-git-send-email-peter.chen@nxp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1297238782==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [198.47.19.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 862A86E1B6 for ; Thu, 11 Aug 2016 09:27:03 +0000 (UTC) In-Reply-To: <1468552625-23546-3-git-send-email-peter.chen@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Chen , airlied@linux.ie, daniel.vetter@ffwll.ch Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1297238782== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uatT2qF771Bt7StWgncrd7kVttGN6T0WO" --uatT2qF771Bt7StWgncrd7kVttGN6T0WO Content-Type: multipart/mixed; boundary="TecQbRNv8HGl5BBXRV0EOIWq29bsvnKHk" From: Tomi Valkeinen To: Peter Chen , airlied@linux.ie, daniel.vetter@ffwll.ch Cc: dri-devel@lists.freedesktop.org Message-ID: <1bae4a9c-fee3-771f-9ae3-3e5eb6268dbf@ti.com> Subject: Re: [RESEND Patch 2/4] gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle References: <1468552625-23546-1-git-send-email-peter.chen@nxp.com> <1468552625-23546-3-git-send-email-peter.chen@nxp.com> In-Reply-To: <1468552625-23546-3-git-send-email-peter.chen@nxp.com> --TecQbRNv8HGl5BBXRV0EOIWq29bsvnKHk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On 15/07/16 06:17, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. >=20 > Cc: Tomi Valkeinen > Signed-off-by: Peter Chen > --- > drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c b/drivers/gpu/drm/oma= pdrm/dss/dss-of.c > index dfd4e96..e256d87 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dss-of.c > +++ b/drivers/gpu/drm/omapdrm/dss/dss-of.c > @@ -125,15 +125,16 @@ u32 dss_of_port_get_port_number(struct device_nod= e *port) > =20 > static struct device_node *omapdss_of_get_remote_port(const struct dev= ice_node *node) > { > - struct device_node *np; > + struct device_node *np, *np_parent; > =20 > np =3D of_parse_phandle(node, "remote-endpoint", 0); > if (!np) > return NULL; > =20 > - np =3D of_get_next_parent(np); > + np_parent =3D of_get_next_parent(np); > + of_node_put(np); > =20 > - return np; > + return np_parent; > } The doc for of_get_next_parent() says: "This is like of_get_parent() except that it drops the refcount on the passed node, making it suitable for iterating". So this patch breaks omapdrm. Tomi --TecQbRNv8HGl5BBXRV0EOIWq29bsvnKHk-- --uatT2qF771Bt7StWgncrd7kVttGN6T0WO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXrEN+AAoJEPo9qoy8lh71K80P/08CdaJExZd9fyllUsmujZff JZjDfupLuGpn8Nz+nxe5wUTkSABWE7qoEIkHCWikBOodA451A87PGbNTdM956xL/ ErqmRLwYmTOuaWZ9kiF+bQIrDv++dJQ63NyHHxvNkaDEZuAvXoncnQ4oPE3c+RUC 8KthsGZL4Q7WtWGeAtKHF5Zo1yZdCxjsLvz0SFBX43RpChT1bzm3LkFI07kbvxYU sJjYBbj+3h+xnPz/ad6HYR6lM8z03p33x5WULbDbJwD41pzagdwKjCzAXS4RaK0q pA44vHTXjmHomuwEXiN5K11sWdxgZjDhKPPQRSj/FmEZczPVwG89cH2Z9x5ZiUfA h3mYwQOBeDwmrh94uEbPEJYjkzD4MgDxH9Plrbm8+gFaHyJPAOIwL9Zhq73rJm8M EpobxbM5y7UCb1jlxvKb92wgIilTMGk8LPe5J2JFpXo2du3EUS8Z8X4Fd9IN+3kZ i3430BPipGdzVpZpMbVIJ4+BBCmg5dJWb1AMAFzgi1T0ylLlhQ9yoEkOD0EIUzI8 3qGL4TjKGgTiVfGl+Z+wD7aMbPOHOEbx9yzsCUi3JqmJX9nmahplI6T0B5t9nvkR bI8kc/pGg8MWEn0WbjVAWXY839oLBwGXVcZJysSrZ3itYf2kuzNxSjx26wMMT5tu 7kcE82Qg5gRFpuqsBTIw =IO1S -----END PGP SIGNATURE----- --uatT2qF771Bt7StWgncrd7kVttGN6T0WO-- --===============1297238782== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1297238782==--