All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH 1/2] ell: avoid using inet_ntoa()
Date: Fri, 18 Jun 2021 09:54:13 -0500	[thread overview]
Message-ID: <1bc16daf-f783-201c-802f-600721d2f8d2@gmail.com> (raw)
In-Reply-To: <144affac0389b92896ae152643610b6ec497a398.1623871292.git.davide.caratti@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

Hi Davide,

On 6/16/21 2:22 PM, Davide Caratti wrote:
> static checkers (like rpminspect) complain about use of inet_ntoa(), as
> it relies on a static buffer. Fix this as follows:
> 
>   - use inet_ntop() with a buffer of size INET_ADDRSTRLEN allocated in
>     the stack, similarly to what it is already done for IPv6 addresses
>   - convert IP_STR() to use NIPQUAD() / NIPQUAD_FMT, similarly to what
>     is done with MAC addresses
> ---
>   ell/acd.c         | 28 +++++++++++++---------------
>   ell/dhcp-lease.c  |  3 ++-
>   ell/dhcp-server.c | 37 ++++++++++++++++++-------------------
>   ell/dhcp.c        |  6 ++++--
>   ell/rtnl.c        |  7 +++++--
>   5 files changed, 42 insertions(+), 39 deletions(-)
> 

Both applied, thanks.

Regards,
-Denis

      parent reply	other threads:[~2021-06-18 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 19:22 Davide Caratti
2021-06-16 19:22 ` [PATCH 2/2] examples: " Davide Caratti
2021-06-18 14:54 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bc16daf-f783-201c-802f-600721d2f8d2@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ell@lists.01.org \
    --subject='Re: [PATCH 1/2] ell: avoid using inet_ntoa()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.