From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341C3C433E0 for ; Fri, 17 Jul 2020 03:57:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2C9A20739 for ; Fri, 17 Jul 2020 03:57:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2gO81f/e"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="hfzK3xsV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2C9A20739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZEb/oppkHWK2rc8oF+m3sdMyugSA7yxEZRT74E4Aue8=; b=2gO81f/eq/To1JIk4A5jGyliY 3abV+deXO0zGeLabzvhi16ZXf+dWa8lNc/Fwij0oDeXTPn6GT4TvpUVniz+Ef3vMLCuOJXFXAOyQV Lpx5kG6ag7iwx0zM+mKTZ042zb2vScvqKHXVrWlXw4TBYY8nsvHptdg79Z2Xwo6EeCElcGrjvXk43 tN+W3LL0sp/BOCWG780ypvcrr6J/1tWMa5ZcIcGhXEU8xvnBSPxEUOnEVir0690TYSwv79wgQxYoo xU3WhnKV4Dn8fYb8tx6lZzHMuB4Gh/KVtY1p4XrdAolX6XVYhEaRBML0BY6o3/jSCnpU0Y01FDTz+ N2MOAZ4KQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwHTL-0004Ty-Ni; Fri, 17 Jul 2020 03:55:43 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwHTG-0004Aj-EO for linux-arm-kernel@lists.infradead.org; Fri, 17 Jul 2020 03:55:42 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594958141; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=VcFuZUON6AOP/wTdm89IoSQulHlWKQZ3rGSifRb+Po8=; b=hfzK3xsV4mi1yjAjl6P3vbCOrLUpq9src6ZEvxGg1R47UukaTxUKAaJnmbKrTyW3h5KemueB 4Jj6szw7oQhntEOSSYjeXLH2zfwknPUVekGiC4xTADThY4orGI5Wua84IVYfrDDZ81pd6J+F QhW3sADf7DSwLFa5wRAsUuh/Df4= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n19.prod.us-east-1.postgun.com with SMTP id 5f112125427cd55766dcc58f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 17 Jul 2020 03:55:17 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9A81BC4339C; Fri, 17 Jul 2020 03:55:16 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5ED4CC433C9; Fri, 17 Jul 2020 03:55:15 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 17 Jul 2020 11:55:15 +0800 From: tingwei@codeaurora.org To: Mike Leach Subject: Re: [PATCH v2 16/20] coresight: allow cti to be built as a module In-Reply-To: References: <20200714054914.15141-1-tingwei@codeaurora.org> <20200714054914.15141-17-tingwei@codeaurora.org> Message-ID: <1bc87d16bcca21e6a2b23468ac7956c5@codeaurora.org> X-Sender: tingwei@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200716_235541_535912_046F93EF X-CRM114-Status: GOOD ( 24.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Coresight ML , Mao Jinlong , Mian Yousaf Kaukab , Russell King , Randy Dunlap , Leo Yan , linux-arm-kernel , linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-07-16 21:30, Mike Leach wrote: > Hi, > > On Tue, 14 Jul 2020 at 06:54, Tingwei Zhang > wrote: >> >> Allow to build coresight-cti as a module, for ease of development. >> >> - Kconfig becomes a tristate, to allow =m >> - append -core to source file name to allow module to >> be called coresight-cti by the Makefile >> - add an cti_remove function, for module unload >> - add a MODULE_DEVICE_TABLE for autoloading on boot >> >> Signed-off-by: Tingwei Zhang >> --- >> drivers/hwtracing/coresight/Kconfig | 5 ++++- >> drivers/hwtracing/coresight/Makefile | 4 ++-- >> .../{coresight-cti.c => coresight-cti-core.c} | 14 >> ++++++++++++++ >> drivers/hwtracing/coresight/coresight-platform.c | 1 + >> drivers/hwtracing/coresight/coresight.c | 1 + >> 5 files changed, 22 insertions(+), 3 deletions(-) >> rename drivers/hwtracing/coresight/{coresight-cti.c => > coresight-cti-core.c} (98%) >> >> diff --git a/drivers/hwtracing/coresight/Kconfig > b/drivers/hwtracing/coresight/Kconfig >> index f31778dd0b5d..b04aae2ceecc 100644 >> --- a/drivers/hwtracing/coresight/Kconfig >> +++ b/drivers/hwtracing/coresight/Kconfig >> @@ -136,7 +136,7 @@ config CORESIGHT_CPU_DEBUG >> module will be called coresight-cpu-debug. >> >> config CORESIGHT_CTI >> - bool "CoreSight Cross Trigger Interface (CTI) driver" >> + tristate "CoreSight Cross Trigger Interface (CTI) driver" >> depends on ARM || ARM64 >> help >> This driver provides support for CoreSight CTI and CTM > components. >> @@ -147,6 +147,9 @@ config CORESIGHT_CTI >> halt compared to disabling sources and sinks normally in > driver >> software. >> >> + To compile this driver as a module, choose M here: the >> + module will be called coresight-cti. >> + >> config CORESIGHT_CTI_INTEGRATION_REGS >> bool "Access CTI CoreSight Integration Registers" >> depends on CORESIGHT_CTI >> diff --git a/drivers/hwtracing/coresight/Makefile > b/drivers/hwtracing/coresight/Makefile >> index 8a7d7ddcce24..c65a153b1e1b 100644 >> --- a/drivers/hwtracing/coresight/Makefile >> +++ b/drivers/hwtracing/coresight/Makefile >> @@ -18,6 +18,6 @@ coresight-etm4x-y := coresight-etm4x-core.o > coresight-etm4x-sysfs.o >> obj-$(CONFIG_CORESIGHT_STM) += coresight-stm.o >> obj-$(CONFIG_CORESIGHT_CPU_DEBUG) += coresight-cpu-debug.o >> obj-$(CONFIG_CORESIGHT_CATU) += coresight-catu.o >> -obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o \ >> - coresight-cti-platform.o \ >> +obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o >> +coresight-cti-y := coresight-cti-core.o >> coresight-cti-platform.o > \ >> coresight-cti-sysfs.o >> diff --git a/drivers/hwtracing/coresight/coresight-cti.c > b/drivers/hwtracing/coresight/coresight-cti-core.c >> similarity index 98% >> rename from drivers/hwtracing/coresight/coresight-cti.c >> rename to drivers/hwtracing/coresight/coresight-cti-core.c >> index 2829286daed9..b31839682c9e 100644 >> --- a/drivers/hwtracing/coresight/coresight-cti.c >> +++ b/drivers/hwtracing/coresight/coresight-cti-core.c >> @@ -618,6 +618,14 @@ static void cti_device_release(struct device >> *dev) >> if (drvdata->csdev_release) >> drvdata->csdev_release(dev); >> } >> +static int __exit cti_remove(struct amba_device *adev) >> +{ >> + struct cti_drvdata *drvdata = dev_get_drvdata(&adev->dev); >> + >> + coresight_unregister(drvdata->csdev); >> + >> + return 0; >> +} >> >> static int cti_probe(struct amba_device *adev, const struct amba_id > *id) >> { >> @@ -739,6 +747,7 @@ static const struct amba_id cti_ids[] = { >> CS_AMBA_UCI_ID(0x000bb9ed, uci_id_cti), /* Coresight CTI (SoC > 600) */ >> { 0, 0}, >> }; >> +MODULE_DEVICE_TABLE(amba, cti_ids); >> >> static struct amba_driver cti_driver = { >> .drv = { >> @@ -747,6 +756,7 @@ static struct amba_driver cti_driver = { >> .suppress_bind_attrs = true, >> }, >> .probe = cti_probe, >> + .remove = cti_remove, >> .id_table = cti_ids, >> }; >> >> @@ -769,3 +779,7 @@ static void __exit cti_exit(void) >> >> module_init(cti_init); >> module_exit(cti_exit); >> + >> +MODULE_AUTHOR("Mike Leach "); >> +MODULE_DESCRIPTION("Arm CoreSight Funnel Driver"); > > Cut and paste error here - this module it the CTI, not the funnel. > > Regards > > Mike > Thanks for catching this Mike. I'll fix it in next patch set. Thanks, Tingwei >> +MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c > b/drivers/hwtracing/coresight/coresight-platform.c >> index 43418a2126ff..44f24683f089 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -76,6 +76,7 @@ coresight_find_csdev_by_fwnode(struct fwnode_handle > *r_fwnode) >> } >> return csdev; >> } >> +EXPORT_SYMBOL_GPL(coresight_find_csdev_by_fwnode); >> >> #ifdef CONFIG_OF >> static inline bool of_coresight_legacy_ep_is_input(struct device_node > *ep) >> diff --git a/drivers/hwtracing/coresight/coresight.c > b/drivers/hwtracing/coresight/coresight.c >> index bf8c41901016..cf7079f4b99c 100644 >> --- a/drivers/hwtracing/coresight/coresight.c >> +++ b/drivers/hwtracing/coresight/coresight.c >> @@ -273,6 +273,7 @@ void coresight_set_assoc_ectdev_mutex(struct > coresight_device *csdev, >> csdev->ect_dev = ect_csdev; >> mutex_unlock(&coresight_mutex); >> } >> +EXPORT_SYMBOL_GPL(coresight_set_assoc_ectdev_mutex); >> >> static int coresight_enable_sink(struct coresight_device *csdev, >> u32 mode, void *data) >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, >> a Linux Foundation Collaborative Project >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel