From: Dongli Zhang <dongli.zhang@oracle.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
joao.m.martins@oracle.com, joe.jin@oracle.com, dsahern@gmail.com,
edumazet@google.com
Subject: Re: [PATCH net-next v4 1/4] skbuff: introduce kfree_skb_list_reason()
Date: Wed, 2 Mar 2022 08:49:39 -0800 [thread overview]
Message-ID: <1bce4d36-8032-d6c9-541c-858a38ba2596@oracle.com> (raw)
In-Reply-To: <20220301183454.4813d022@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Hi Jakub,
On 3/1/22 6:34 PM, Jakub Kicinski wrote:
> On Sat, 26 Feb 2022 00:49:26 -0800 Dongli Zhang wrote:
>> +void kfree_skb_list(struct sk_buff *segs)
>> +{
>> + kfree_skb_list_reason(segs, SKB_DROP_REASON_NOT_SPECIFIED);
>> +}
>> EXPORT_SYMBOL(kfree_skb_list);
>
> Why not make it a static inline now, like we did with kfree_skb()?
>
I will move kfree_skb_list() to include/linux/skbuff.h as static inline.
Thank you very much!
Dongli Zhang
next prev parent reply other threads:[~2022-03-02 16:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 8:49 [PATCH net-next v4 0/4] tun/tap: use kfree_skb_reason() to trace dropped skb Dongli Zhang
2022-02-26 8:49 ` [PATCH net-next v4 1/4] skbuff: introduce kfree_skb_list_reason() Dongli Zhang
2022-03-02 2:34 ` Jakub Kicinski
2022-03-02 16:49 ` Dongli Zhang [this message]
2022-02-26 8:49 ` [PATCH net-next v4 2/4] net: tap: track dropped skb via kfree_skb_reason() Dongli Zhang
2022-03-02 2:42 ` Jakub Kicinski
2022-03-02 17:43 ` Dongli Zhang
2022-03-02 19:03 ` Jakub Kicinski
2022-03-02 21:44 ` Dongli Zhang
2022-02-26 8:49 ` [PATCH net-next v4 3/4] net: tun: split run_ebpf_filter() and pskb_trim() into different "if statement" Dongli Zhang
2022-02-26 8:49 ` [PATCH net-next v4 4/4] net: tun: track dropped skb via kfree_skb_reason() Dongli Zhang
2022-02-28 1:20 ` David Ahern
2022-03-02 2:50 ` Jakub Kicinski
2022-03-02 3:29 ` David Ahern
2022-03-02 4:16 ` [Internet]Re: " imagedong(董梦龙)
2022-03-02 18:26 ` Dongli Zhang
2022-03-02 19:22 ` Jakub Kicinski
2022-03-02 18:19 ` Dongli Zhang
2022-03-02 19:17 ` Jakub Kicinski
2022-03-02 22:21 ` Dongli Zhang
2022-03-03 5:21 ` Jakub Kicinski
2022-03-03 5:55 ` Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bce4d36-8032-d6c9-541c-858a38ba2596@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=joao.m.martins@oracle.com \
--cc=joe.jin@oracle.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.