From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1wI4-000707-Jm for qemu-devel@nongnu.org; Wed, 02 Nov 2016 10:13:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1wI0-0005kg-MR for qemu-devel@nongnu.org; Wed, 02 Nov 2016 10:13:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1wI0-0005kP-FD for qemu-devel@nongnu.org; Wed, 02 Nov 2016 10:13:16 -0400 References: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> <7179b840-077d-a06f-e2ab-4da711029cfd@redhat.com> <20161031105509.GC2668@redhat.com> <20161102095738.GA6182@noname.redhat.com> From: Eric Blake Message-ID: <1be58a5d-3690-a9b2-d395-01c72ba64e78@redhat.com> Date: Wed, 2 Nov 2016 09:13:12 -0500 MIME-Version: 1.0 In-Reply-To: <20161102095738.GA6182@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1DmpJPEfnIQQkdn6wvXsbMq6a8melLXhQ" Subject: Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , ashish mittal Cc: "Daniel P. Berrange" , qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster , Jeff Cody , famz@redhat.com, Ashish Mittal , Stefan Hajnoczi , Rakesh Ranjan , Buddhi.Madhav@veritas.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1DmpJPEfnIQQkdn6wvXsbMq6a8melLXhQ From: Eric Blake To: Kevin Wolf , ashish mittal Cc: "Daniel P. Berrange" , qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster , Jeff Cody , famz@redhat.com, Ashish Mittal , Stefan Hajnoczi , Rakesh Ranjan , Buddhi.Madhav@veritas.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com Message-ID: <1be58a5d-3690-a9b2-d395-01c72ba64e78@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] block/vxhs: Add Veritas HyperScale VxHS block device support References: <1477640667-4775-1-git-send-email-ashish.mittal@veritas.com> <7179b840-077d-a06f-e2ab-4da711029cfd@redhat.com> <20161031105509.GC2668@redhat.com> <20161102095738.GA6182@noname.redhat.com> In-Reply-To: <20161102095738.GA6182@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/02/2016 04:57 AM, Kevin Wolf wrote: >>> IMHO it should allow use of UNIX sockets, as its possible to have >>> SSH setup a tunnel to a IP server, and expose the endpoint via a >>> UNIX socket. So even if your reference server only supports IPv4, >>> users can conceivably connect with any sockets protocol. >>> >> >> This is not a use-case that we have in mind right now, but a very fair= >> point! Kind of like accessing the audio/video streams remotely from my= >> Raspberry Pi over ssh. Is it OK if we target this in a future patch >> after proper review/testing? >=20 > No, going from InetSocketAddress to SocketAddress changes the API in an= > incompatible way (previously working blockdev-add commands would stop > working), so we must decide now before the API is introduced. Going from InetSocketAddress to SocketAddress is a pain because SocketAddress is a 'simple union' (which really means extra nesting on the wire). I'd really rather that blockdev-add move towards the GlusterServer style of a 'flat union', which CAN be done in a backwards-compatible manner. Or, with examples: InetServer alone: { "host": "foo", "port": "1000" } SocketAddress: { "type": "inet", "data": { "host": "foo", "port": "1000" } } GlusterServer: { "type": "tcp", "host": "foo", "port": "1000" } For comparison, we wrote NFSServer with an eye towards possible expansion into a flat version (more like GlusterServer than SocketAddress= ). NFSServer: { "type": "inet", "host": "foo" } [side note: Uggh - why did we let gluster go into 2.7 with 'tcp' instead of 'inet' :( I'm wondering if we want gluster in 2.8 to recognize 'inet' as a synonym for 'tcp'; I could propose a patch if we think it is worthwhile] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1DmpJPEfnIQQkdn6wvXsbMq6a8melLXhQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYGfR5AAoJEKeha0olJ0NqYQ0IAIQTo1nJ3FkPVkVQiL1jVBKM 84LFom7ZNifAxaXY+6gLgLvtTrhJQXkVCfdUrNyO4Tao9Uw4iSkbEYJ5UhYQwSsx cQGWbOV33oeAMOdV71mgjpZgLlMYD18RcsHQuhpaRGPt1y4GbZICSYojkOm2H5Pt QghKFmYDyuQG1t0/b9ukR4beICrcPtdulPSfUKxHOTXebDP6auscKdo4u9DY7A7O FUBzu9hBAyBT6YvoG5s3ii3bAtHUcYOTIAtWl4e2vasy94uBTtXg/9tYqgKG93yd uNpQhgMD4k8kRIv5E+1jSxevpYEL/32qco1xlXZo4LvoskmS387CqIl6BJyyfl8= =K7tY -----END PGP SIGNATURE----- --1DmpJPEfnIQQkdn6wvXsbMq6a8melLXhQ--