All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up
Date: Mon, 25 Jan 2021 22:16:25 +0100	[thread overview]
Message-ID: <1bf1290d-cd19-dd9e-5ce4-a4ceca0c04e1@redhat.com> (raw)
In-Reply-To: <3cfa7f82-866b-e8b7-3e61-bb3dedff3226@redhat.com>

On 01/25/21 11:57, Max Reitz wrote:
> On 23.01.21 01:41, Laszlo Ersek wrote:
>> On 01/22/21 22:26, Laszlo Ersek wrote:
>>
>>> I'm drifting towards an overhaul of coroutine-sigaltstack, based on my
>>> personal understanding of POSIX, but given that I can absolutely not
>>> *test* coroutine-sigaltstack on the platforms where it actually matters,
>>> an "overhaul" by me would be reckless.
>>>
>>> I didn't expect these skeletons when I first read Max's "Thread safety
>>> of coroutine-sigaltstack" email :/
>>>
>>> Max, after having worked on top of your patch for a few hours, I
>>> officially endorse your mutex approach. I can't encourage you or myself
>>> to touch this code, in good conscience. It's not that it's "bad"; it's
>>> inexplicable and (to me) untestable.
> 
> On one hand, that’s too bad; on the other perhaps it’s just for the
> better to get all of this out of our minds again (for now)... O:)
> 
>> I'm attaching a patch (based on 0e3246263068). I'm not convinced that I
>> should take responsibility for this, given the lack of testability on my
>> end. So I'm not posting it stand-alone even as an RFC. I've built it and
>> have booted one of my existent domains with it, but that's all.
> 
> FWIW, it looks good to me.  We should keep it in mind if in the future
> for some reason sigaltstack becomes more important, but for now I’m not
> too sad to abort any improvement efforts.

OK -- so do you plan to post your mutex approach stand-alone? (Sorry if
that's already been done and I've missed it.)

I actually feel somewhat safe regarding my patch, as long as it is
*only* executed on Linux hosts, and on other hosts that claim
conformance to POSIX.

But, of course, this whole thing has come up because of OSX... and I
don't have the first clue about OSX. (For example whether sigsuspend()
on OSX is prone to a spurious wakeup in response to SIGCONT.)

Thanks
Laszlo



  reply	other threads:[~2021-01-25 21:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 10:20 [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up Max Reitz
2021-01-22 14:55 ` Eric Blake
2021-01-22 16:38 ` Laszlo Ersek
2021-01-22 17:58   ` Max Reitz
2021-01-22 18:19     ` Eric Blake
2021-01-22 18:28       ` Laszlo Ersek
2021-01-22 18:27     ` Laszlo Ersek
2021-01-22 19:02     ` Laszlo Ersek
2021-01-22 17:09 ` Laszlo Ersek
2021-01-22 18:05   ` Max Reitz
2021-01-22 18:29     ` Laszlo Ersek
2021-01-22 21:26       ` Laszlo Ersek
2021-01-23  0:41         ` Laszlo Ersek
2021-01-25 10:57           ` Max Reitz
2021-01-25 21:16             ` Laszlo Ersek [this message]
2021-01-23 22:13         ` Paolo Bonzini
2021-01-25 21:13           ` Laszlo Ersek
2021-01-25 22:08             ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bf1290d-cd19-dd9e-5ce4-a4ceca0c04e1@redhat.com \
    --to=lersek@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.