From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654EEC07E95 for ; Tue, 20 Jul 2021 18:05:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04D6161029 for ; Tue, 20 Jul 2021 18:05:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04D6161029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5u7d-00085l-1O for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 14:05:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5u5x-00051c-E5 for qemu-devel@nongnu.org; Tue, 20 Jul 2021 14:03:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5u5w-0008Ru-0S for qemu-devel@nongnu.org; Tue, 20 Jul 2021 14:03:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626804231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltTJgAUCtkd8qgfcYJsubtS+OQhsZwzjjtiJz40XHew=; b=OurjYbx94diDorHvkVwWYF+fSExqdxqW2OEZvq1W1tk+6SEzkRD5+rCVtkgt1vr332Cko+ IeUSNDPYJc4cRS03v++3JXO9+jjip+fGmcdXCgqKgLzCojJds6aiYLPZJTjsGrTXOeuuBe 1TCbboaHAmQ8c5emMQ8qH+yCi2gsLuo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-7GC1W0WBPGS92eywextLzA-1; Tue, 20 Jul 2021 14:03:50 -0400 X-MC-Unique: 7GC1W0WBPGS92eywextLzA-1 Received: by mail-wm1-f70.google.com with SMTP id y6-20020a7bc1860000b0290227b53c7cefso41038wmi.1 for ; Tue, 20 Jul 2021 11:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ltTJgAUCtkd8qgfcYJsubtS+OQhsZwzjjtiJz40XHew=; b=JavMmv+EjPQqPv+R5abdj4O7bu19YHx3uat9Ma92aRQZVyyrG1ig3otdPjrwviQQnm n2YhVGyVSxUfhr/G5UEqqktndQ1+w7R6Fa3lxORXWYeY3d8cnrezi+/zPX166moI74DX lmiggUI1gdw+K+tYwuc5etY3lo7QzC5f5cOZhvd9iRzi7GY585G+lN2dQoRwJmgczYFt f7T5CN7m2pH6vITgeyd9k+UGHp8wSGtUSQkFyBYQSSUt9AEoIdWs0nuV2m+zl9mGj1hZ LUxiVczN4CcZD88VizAN4mi/q4JXbzWhS2Qjih0rbScEt8Cv2QIL9vu5n+aoD/nqy9Uv t3Ag== X-Gm-Message-State: AOAM531Td1+Fp7Af9nu7aUrjQHxC1cbdsWhRF1vwOT5+z0uM7JG4pnKk kaqPt8sGKi8wRyhyy+CZ/kwWVYJT2K09vV9Aiyy7HMoKrUWNRgDY26rT531s4QGmytvLH0Xpghg JnbmQt6KO7QqhEP8= X-Received: by 2002:adf:a1c4:: with SMTP id v4mr36982889wrv.217.1626804228895; Tue, 20 Jul 2021 11:03:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0/RXLaLhlegJGa2y6S7n2d1DJKuM5mNZMO9StyRNaUyL/oL5iJeampSw9xW4V73ulsR2x7w== X-Received: by 2002:adf:a1c4:: with SMTP id v4mr36982865wrv.217.1626804228786; Tue, 20 Jul 2021 11:03:48 -0700 (PDT) Received: from [192.168.1.36] (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id f2sm24381150wrq.69.2021.07.20.11.03.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 11:03:48 -0700 (PDT) Subject: Re: [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker() To: Markus Armbruster , qemu-devel@nongnu.org References: <20210720125408.387910-1-armbru@redhat.com> <20210720125408.387910-8-armbru@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <1bf18b91-455b-315c-2457-332782a9e601@redhat.com> Date: Tue, 20 Jul 2021 20:03:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210720125408.387910-8-armbru@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kirti Wankhede , Alex Williamson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/20/21 2:53 PM, Markus Armbruster wrote: > When migrate_add_blocker(blocker, &errp) is followed by > error_propagate(errp, err), we can often just as well do > migrate_add_blocker(..., errp). This is the case in > vfio_migration_probe(). > > Prior art: commit 386f6c07d2 "error: Avoid error_propagate() after > migrate_add_blocker()". > > Cc: Kirti Wankhede > Cc: Alex Williamson > Signed-off-by: Markus Armbruster > --- > hw/vfio/migration.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé