From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbdHIUrc (ORCPT ); Wed, 9 Aug 2017 16:47:32 -0400 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:32804 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbdHIUr1 (ORCPT ); Wed, 9 Aug 2017 16:47:27 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH v2] selftests: warn if failure is due to lack of executable bit To: "Luis R. Rodriguez" Cc: linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, keescook@chromium.org, pmladek@suse.com, dan.carpenter@oracle.com, colin.king@canonical.com, dcb314@hotmail.com, linux-kernel@vger.kernel.org, Michael Ellerman , Shuah Khan , shuah Khan References: <20170803202436.6877-1-mcgrof@kernel.org> <20170808175028.GP27873@wotan.suse.de> From: Shuah Khan Message-ID: <1bf53e2c-e899-2da9-aad7-7b803e22a4fa@kernel.org> Date: Wed, 9 Aug 2017 14:47:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170808175028.GP27873@wotan.suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfF/ky+tWcf6ZqBd174efn01TAZ9w8FrVvUJnZmm+aP/NBtZGqCrerOA3lfBKa0K8KOGOetWdtY+dh1rllr7roPmb+4vBb4EOo7KOiH2oAGZ02gbdZyjA 57U9ElAmj8J2wdsYAAVLgr8zEj5qd9V8ewa8QxiPxSNw6OnS7f2UeXH53BNGgt6GQNA0Uf6NSYop5B1aetehrg03o9I/KWGPvMGaI1agMLFWIRXrkVHgOm2h mHNr3vLkOxaR7kpEfG8ZgEuZMukT/LIok/nLHBmO7A1j+Ws5xlSvVaOTBYADeGG8BWMHN4/Adm+deOlcDjvGR7+D4I7SIDbPIvPzradXvv3vyjH6fzVNanpx 5BoPAcYb15c0vXLBlfofFgZS+bw83wkko4Y9/npAbM4AHVDaAqLg2Ows2LHH8GxsGI3EtdCK9vSOUVJu6a0DdM9QMYUS5DIdQQy3wCYrdL/0Gm8a91fzTEpM PZz3C09X6O51kuwgUKKhnMSMATUnz31n6zfjTxI2D+t9MMb9ZLi+/AmvyeiG/Xl6jlv4M+UZSIQJuaUY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2017 11:50 AM, Luis R. Rodriguez wrote: > On Thu, Aug 03, 2017 at 01:24:36PM -0700, Luis R. Rodriguez wrote: >> Executing selftests is fragile as if someone forgot to set a secript >> as executable the test will fail, and you won't know for sure if the >> failure was caused by the lack of proper permissions or something else. >> >> Setting scripts as executable is required, this also enable folks to >> execute selftests as independent units. >> >> Signed-off-by: Luis R. Rodriguez >> --- >> tools/testing/selftests/lib.mk | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index 959273c3a52e..e71f8e4633b1 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -14,7 +14,12 @@ all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) >> define RUN_TESTS >> @for TEST in $(TEST_GEN_PROGS) $(TEST_PROGS); do \ >> BASENAME_TEST=`basename $$TEST`; \ >> - cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests: $$BASENAME_TEST [FAIL]"; cd -;\ >> + if [ ! -x $$BASENAME_TEST ]; then \ >> + echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\ >> + echo "selftests: $$BASENAME_TEST [FAIL]"; \ >> + else \ >> + cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests: $$BASENAME_TEST [FAIL]"; cd -;\ >> + fi; \ >> done; >> endef >> > > *poke* > > Luis > > Applied to linux-kselftest next for 4.14-rc1. thanks, -- Shuah