All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH 6/8] cert: Add PKCS#12 loading support
Date: Fri, 08 Jan 2021 20:29:55 -0600	[thread overview]
Message-ID: <1bfbcc64-9925-4a9f-cf6f-9a24f699ac67@gmail.com> (raw)
In-Reply-To: <CAOq732+3e5qMJtRx6APUVsfYixiSZyu1tku=uj3dufJDCNPrSg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Hi Andrew,

On 1/8/21 7:04 PM, Andrew Zaborowski wrote:
> On Fri, 8 Jan 2021 at 05:59, Denis Kenzior <denkenz@gmail.com> wrote:
>>> +     plaintext = l_malloc(encrypted_len);
>>> +     ok = l_cipher_decrypt(alg, encrypted, plaintext, encrypted_len);
>>> +     l_cipher_free(alg);
>>> +
>>> +     if (!ok)
>>> +             return NULL;
>>> +
>>
>> is plaintext leaked here?
> 
> l_cipher_decrypt has failed so the read() either failed or didn't happen.
> 

By my reading you l_malloc plaintext and never free it, no?

Regards,
-Denis

  reply	other threads:[~2021-01-09  2:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06 19:54 [PATCH 1/8] util: Add L_IN_SET macros Andrew Zaborowski
2021-01-06 19:54 ` [PATCH 2/8] unit: Add an L_IN_SET test Andrew Zaborowski
2021-01-06 19:54 ` [PATCH 3/8] pem: Move PKCS private key parsing to cert.c Andrew Zaborowski
2021-01-06 19:54 ` [PATCH 4/8] pkcs5: Rename to cert-crypto Andrew Zaborowski
2021-01-06 19:54 ` [PATCH 5/8] cert: Add l_cert_load_container_file Andrew Zaborowski
2021-01-08  4:37   ` Denis Kenzior
2021-01-09  0:51     ` Andrew Zaborowski
2021-01-09  2:39       ` Denis Kenzior
2021-01-06 19:54 ` [PATCH 6/8] cert: Add PKCS#12 loading support Andrew Zaborowski
2021-01-08  4:59   ` Denis Kenzior
2021-01-09  1:04     ` Andrew Zaborowski
2021-01-09  2:29       ` Denis Kenzior [this message]
2021-01-09  2:46         ` Andrew Zaborowski
2021-01-06 19:54 ` [PATCH 7/8] unit: Update tests after l_pkcs5_* renaming Andrew Zaborowski
2021-01-06 19:54 ` [PATCH 8/8] unit: Add l_cert_load_container_file tests Andrew Zaborowski
2021-01-07 20:01 ` [PATCH 1/8] util: Add L_IN_SET macros Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bfbcc64-9925-4a9f-cf6f-9a24f699ac67@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ell@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.