From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9A4C49EA5 for ; Thu, 24 Jun 2021 19:58:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08467613B1 for ; Thu, 24 Jun 2021 19:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232851AbhFXUBH (ORCPT ); Thu, 24 Jun 2021 16:01:07 -0400 Received: from mga06.intel.com ([134.134.136.31]:27339 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232554AbhFXUBG (ORCPT ); Thu, 24 Jun 2021 16:01:06 -0400 IronPort-SDR: prDRVVIt83sAT4ea1DdrH8IRNjsNYdzKC5AX34QeXmJuwmGrELAAUjqmh1s0pMi5Zn5+1zMHsH nGypccPWypmw== X-IronPort-AV: E=McAfee;i="6200,9189,10025"; a="268682515" X-IronPort-AV: E=Sophos;i="5.83,297,1616482800"; d="scan'208";a="268682515" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2021 12:58:39 -0700 IronPort-SDR: 9kxQzp6jeZmOIo5W0vvGj+HLZ5lymwQKayMgXxAO3XSx+C1pp2yhYHcsk0VR3FPe9/HKBPUZg+ a416MsUFmuHw== X-IronPort-AV: E=Sophos;i="5.83,297,1616482800"; d="scan'208";a="487896188" Received: from rsharon-mobl1.ger.corp.intel.com (HELO [10.214.203.125]) ([10.214.203.125]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2021 12:58:32 -0700 Subject: Re: [Intel-wired-lan] [PATCH] igc: change default return of igc_read_phy_reg() To: trix@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, jeffrey.t.kirsher@intel.com, sasha.neftin@intel.com Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org References: <20210521195019.2078661-1-trix@redhat.com> From: "Fuxbrumer, Dvora" Message-ID: <1c0592d7-7d54-7834-61d4-f6b3183b5cf2@linux.intel.com> Date: Thu, 24 Jun 2021 22:58:28 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210521195019.2078661-1-trix@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/21/2021 22:50, trix@redhat.com wrote: > From: Tom Rix > > Static analysis reports this problem > > igc_main.c:4944:20: warning: The left operand of '&' > is a garbage value > if (!(phy_data & SR_1000T_REMOTE_RX_STATUS) && > ~~~~~~~~ ^ > > pyy_data is set by the call to igc_read_phy_reg() only if > there is a read_reg() op, else it is unset and a 0 is > returned. Change the return to -EOPNOTSUPP. > > Fixes: 208983f099d9 ("igc: Add watchdog") > Signed-off-by: Tom Rix > --- > drivers/net/ethernet/intel/igc/igc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Dvora Fuxbrumer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fuxbrumer, Dvora Date: Thu, 24 Jun 2021 22:58:28 +0300 Subject: [Intel-wired-lan] [PATCH] igc: change default return of igc_read_phy_reg() In-Reply-To: <20210521195019.2078661-1-trix@redhat.com> References: <20210521195019.2078661-1-trix@redhat.com> Message-ID: <1c0592d7-7d54-7834-61d4-f6b3183b5cf2@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 5/21/2021 22:50, trix at redhat.com wrote: > From: Tom Rix > > Static analysis reports this problem > > igc_main.c:4944:20: warning: The left operand of '&' > is a garbage value > if (!(phy_data & SR_1000T_REMOTE_RX_STATUS) && > ~~~~~~~~ ^ > > pyy_data is set by the call to igc_read_phy_reg() only if > there is a read_reg() op, else it is unset and a 0 is > returned. Change the return to -EOPNOTSUPP. > > Fixes: 208983f099d9 ("igc: Add watchdog") > Signed-off-by: Tom Rix > --- > drivers/net/ethernet/intel/igc/igc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Dvora Fuxbrumer