All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: James Smart <james.smart@broadcom.com>, linux-nvme@lists.infradead.org
Cc: Keith Busch <keith.busch@intel.com>,
	Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v4 3/4] nvme: add uevent variables for controller devices
Date: Wed, 4 Sep 2019 17:18:58 -0700	[thread overview]
Message-ID: <1c073c6f-468f-a3d5-8990-99774779011f@grimberg.me> (raw)
In-Reply-To: <b0e3f456-4071-abb8-5af9-26354c1a5356@broadcom.com>


>>   static void nvme_aen_uevent(struct nvme_ctrl *ctrl)
>>   {
>>       char *envp[2] = { NULL, NULL };
>> @@ -4063,6 +4090,7 @@ static int __init nvme_core_init(void)
>>           result = PTR_ERR(nvme_class);
>>           goto unregister_chrdev;
>>       }
>> +    nvme_class->dev_uevent = nvme_class_uevent,
> 
> Comma at end of line ?

Hmm, still valid I guess.

I can fix it up, I'll wait for some more feedback first...

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-09-05  0:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 21:59 [PATCH v4 0/4] Support discovery log change events Sagi Grimberg
2019-09-04 21:59 ` [PATCH v4 1/4] nvme-fabrics: allow discovery subsystems accept a kato Sagi Grimberg
2019-09-09 16:47   ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 2/4] nvme: enable aen regardless of the presence of I/O queues Sagi Grimberg
2019-09-09 11:17   ` Hannes Reinecke
2019-09-09 16:48   ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 3/4] nvme: add uevent variables for controller devices Sagi Grimberg
2019-09-04 23:17   ` James Smart
2019-09-05  0:18     ` Sagi Grimberg [this message]
2019-09-05 16:00       ` James Smart
2019-09-05 20:06         ` Sagi Grimberg
2019-09-06 12:59   ` Christoph Hellwig
2019-09-06 18:07     ` Sagi Grimberg
2019-09-09 11:18   ` Hannes Reinecke
2019-09-04 21:59 ` [PATCH v4 4/4] nvme: send discovery log page change events to userspace Sagi Grimberg
2019-09-06 13:00   ` Christoph Hellwig
2019-09-09 16:50   ` Chaitanya Kulkarni
2019-09-04 21:59 ` [PATCH v4 5/4 nvme-cli] udev: convert the discovery event handler to the kernel support Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c073c6f-468f-a3d5-8990-99774779011f@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=keith.busch@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.