From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH] x86/msr: Fix fallout from mostly c/s 832c180 Date: Wed, 10 Apr 2019 08:39:13 +0000 Message-ID: <1c075bec024248b79cf57e9900d9d6b7@AMSPEX02CL01.citrite.net> References: <1554832427-30567-1-git-send-email-andrew.cooper3@citrix.com> <1554884886189.62867@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1554884886189.62867@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Xen-devel Cc: Kevin Tian , Wei Liu , Jan Beulich , Andrew Cooper , Jun Nakajima , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IFBhdWwgRHVycmFudAo+IFNlbnQ6 IDEwIEFwcmlsIDIwMTkgMDk6MjgKPiBUbzogQW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNA Y2l0cml4LmNvbT47IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+Cj4gQ2M6IEFu ZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+OyBKYW4gQmV1bGljaCA8SkJl dWxpY2hAc3VzZS5jb20+OyBXZWkgTGl1Cj4gPHdlaS5saXUyQGNpdHJpeC5jb20+OyBSb2dlciBQ YXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPjsgSnVuIE5ha2FqaW1hIDxqdW4ubmFrYWpp bWFAaW50ZWwuY29tPjsKPiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KPiBTdWJq ZWN0OiBSRTogW1BBVENIXSB4ODYvbXNyOiBGaXggZmFsbG91dCBmcm9tIG1vc3RseSBjL3MgODMy YzE4MAo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEFuZHJldyBD b29wZXIgW21haWx0bzphbmRyZXcuY29vcGVyM0BjaXRyaXguY29tXQo+ID4gU2VudDogMDkgQXBy aWwgMjAxOSAxODo1NAo+ID4gVG86IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+ Cj4gPiBDYzogQW5kcmV3IENvb3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IEphbiBC ZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT47IFdlaSBMaXUKPiA+IDx3ZWkubGl1MkBjaXRyaXgu Y29tPjsgUm9nZXIgUGF1IE1vbm5lIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFBhdWwgRHVycmFu dAo+IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT47Cj4gPiBKdW4gTmFrYWppbWEgPGp1bi5uYWth amltYUBpbnRlbC5jb20+OyBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGludGVsLmNvbT4KPiA+IFN1 YmplY3Q6IFtQQVRDSF0geDg2L21zcjogRml4IGZhbGxvdXQgZnJvbSBtb3N0bHkgYy9zIDgzMmMx ODAKPiA+Cj4gPiBUaGUgc2VyaWVzIDgzMmMxODAzXi4uZjYxNjg1YTYgd2FzIGNvbW1pdHRlZCB3 aXRob3V0IGFkZXF1YXRlIHJldmlldy4KPiA+Cj4gCj4gdjEgb2YgdGhlIHNlcmllcyB3YXMgcG9z dGVkIG9uIDd0aCBKYW4gYW5kIHY0IG9uIDE0dGggTWFyY2guIEl0IHdhcyBjb21taXR0ZWQgeWVz dGVyZGF5LiBJJ2Qgc2F5IHRoYXQKPiB0aGVyZSB3YXMgY2VydGFpbmx5IGFkZXF1YXRlIHRpbWUg Zm9yIHJldmlldy4KPiAKPiA+ICAqIEZpeCB0aGUgc2hpbSBidWlsZCBieSBwcm92aWRpbmcgYSAh Q09ORklHX0hWTSBkZWNsYXJhdGlvbiBmb3IKPiA+ICAgIGh2bV9nZXRfZ3Vlc3RfYm5kY2Zncygp Cj4gPiAgKiBSZXZlcnQgdGhlIGJvZ3VzIGRlLWNvbnN0J2luZyBvZiB0aGUgdmNwdSBwb2ludGVy IGluCj4gPiAgICB2bXhfZ2V0X2d1ZXN0X2JuZGNmZ3MoKS4gIHZteF92bWNzX2VudGVyKCkgcmVh bGx5IGRvZXMgbXV0YXRlIHRoZSB2Y3B1LCBhbmQKPiA+ICAgIG1heSBjYXVzZSBpdCB0byB1bmRl cmdvIGEgZnVsbCBkZS9yZXNjaGVkdWxlLCB3aGljaCBpcyBpbiB2aW9sYXRpb24gb2YgdGhlCj4g PiAgICBBQkkgZGVzY3JpYmVkIGJ5IGh2bV9nZXRfZ3Vlc3RfYm5kY2ZncygpLiAgZ3Vlc3RfcmRt c3IoKSB3YXMgYWx3YXlzIGdvaW5nCj4gPiAgICB0byBuZWVkIHRvIGxvc2UgaXRzIGNvbnN0IHBh cmFtZXRlciwgYW5kIHRoaXMgd2FzIHRoZSBjb3JyZWN0IHRpbWUgZm9yIGl0Cj4gPiAgICB0byBo YXBwZW4uCj4gCj4gSW4gdGhlIGNhc2Ugb2Ygdm14X2dldF9ndWVzdF9ibmRjZmdzKCkgaXMgdGhl cmUgYWN0dWFsbHkgcG9zc2liaWxpdHkgb2YgYSByZS1zY2hlZHVsZT8gSXQncyBlaXRoZXIKPiBn b2luZyB0byBiZSBpbiBjdXJyZW50IGNvbnRleHQgKGluIHdoaWNoIGNhc2UgSUlVQyB2bXhfdm1j c19lbnRlcigpIGlzIGdvaW5nIHRvIGJlIGxhcmdlbHkgYSBuby1vcCkgb3IKPiB0aGUgdmNwdSBp biBxdWVzdGlvbiBzaG91bGQgaGF2ZSBhbHJlYWR5IGJlZW4gcGF1c2VkLiBJJ20gbm8KCl5eXiB0 aGF0IGdvdCB0cnVuY2F0ZWQgdGhhbmtzIHRvIGV4Y2hhbmdlIGdvaW5nIGJ5ZSBieWUuLi4gSSB3 YXMganVzdCBhYm91dCB0byBzYXkgSSB3YXMgbm8gcGFydGljdWxhciBmYW4gb2YgdGhlIGRlLWNv bnN0aW5nIHRyaWNrIGJ1dCB0aGUgbWFpbCB0aHJlYWQgd2FzOgoKLS0tLS0KPj4gRnJvbTogWGVu LWRldmVsIFttYWlsdG86eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmddIE9u IEJlaGFsZiBPZiBKYW4gQmV1bGljaAo+PiBTZW50OiAxMyBNYXJjaCAyMDE5IDE1OjU1Cj4+IAo+ PiA+Pj4gT24gMTEuMDMuMTkgYXQgMTk6MDksIDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4gd3Jv dGU6Cj4+ID4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9tc3IuaAo+PiA+ICsrKyBiL3hlbi9p bmNsdWRlL2FzbS14ODYvbXNyLmgKPj4gPiBAQCAtMzI4LDcgKzMyOCw3IEBAIGludCBpbml0X3Zj cHVfbXNyX3BvbGljeShzdHJ1Y3QgdmNwdSAqdik7Cj4+ID4gICAqIFRoZXNlIGZ1bmN0aW9ucyBh cmUgYWxzbyB1c2VkIGJ5IHRoZSBtaWdyYXRpb24gbG9naWMsIHNvIG5lZWQgdG8gY29wZSB3aXRo Cj4+ID4gICAqIGJlaW5nIHVzZWQgb3V0c2lkZSBvZiB2J3MgY29udGV4dC4KPj4gPiAgICovCj4+ ID4gLWludCBndWVzdF9yZG1zcihjb25zdCBzdHJ1Y3QgdmNwdSAqdiwgdWludDMyX3QgbXNyLCB1 aW50NjRfdCAqdmFsKTsKPj4gPiAraW50IGd1ZXN0X3JkbXNyKHN0cnVjdCB2Y3B1ICp2LCB1aW50 MzJfdCBtc3IsIHVpbnQ2NF90ICp2YWwpOwo+PiAKPj4gSSBmaW5kIHRoaXMgcHJldHR5IHVuZGVz aXJhYmxlLCBhbmQgSSdkIGxpa2UgdG8gYXQgbGVhc3QgcHV0IG91dAo+PiBmb3IgZGlzY3Vzc2lv biBhIG1lYW5zIGhvdyB0byBhdm9pZCBpdDogQW55IGVudGl0eSBiZWluZwo+PiBwYXNzZWQgYSBj b25zdCBzdHJ1Y3QgdmNwdSAqY3YgY2FuIGdldCBob2xkIG9mIGEgbm9uLWNvbnN0Cj4+IG9uZSBi eSBkb2luZwo+PiAKPj4gICAgIHN0cnVjdCB2Y3B1ICp2ID0gY3YtPmRvbWFpbi0+dmNwdVtjdi0+ dmNwdV9pZF07Cj4+IAo+IAo+IExvb2tzIGtpbmQgb2Ygb2RkLCBidXQgb2YgY291cnNlIGl0IHdp bGwgY2VydGFpbmx5IHdvcmsuCj4gCj4+IE9mIGNvdXJzZSB0aGlzIHNob3VsZG4ndCBiZSB1c2Vk IGFyYml0cmFyaWx5LCBidXQgdG8gaGlkZSBhbgo+PiBpbXBsZW1lbnRhdGlvbiBkZXRhaWwgbGlr ZSB0aGF0IG9mIHZteF92bWNzX2VudGVyKCkgSSB0aGluawo+PiB0aGlzIGNvdWxkIGJlIGp1c3Rp ZmllZC4gVGhvdWdodHM/Cj4+IAo+IAo+IEkgZ3Vlc3MgdGhlIHF1ZXN0aW9uIGlzIGF0IHdoYXQg bGV2ZWwgdG8gZG8gdGhpcz8gUHJvYmFibHkgaW4gdGhlIGh2bSBjb2RlIAo+IHJhdGhlciB0aGFu IGluIHRoZSB2bXggY29kZS4KCkkgdGhpbmsgaXQgc2hvdWxkIGJlIGluIFZNWCBjb2RlLCBhcyB0 aGF0J3Mgd2hlcmUgdGhlCnZteF92bWNzX2VudGVyKCkgb2RkaXR5IGxpdmVzLgotLS0tLQoKU28g eW91IGNhbiBzZWUgSmFuIGFza2VkIGZvciBvdGhlciBvcGluaW9ucyBhdCB0aGUgdGltZS4gTm9u ZSB3ZXJlIGZvcnRoY29taW5nLiBJIHRoZXJlZm9yZSByZS1jb2RlZCBhcyBoZSByZXF1ZXN0ZWQu Cgo+IAo+ID4gICogUmVtb3ZlIHRoZSBpbnRyb2R1Y2VkIEFTU0VSVChpc19odm1fZG9tYWluKGQp KSBhbmQgY2hlY2sgdGhlIHByZWRpY2F0ZQo+ID4gICAgZGlyZWN0bHkuICBXaGlsZSB3ZSBleHBl Y3QgaXQgdG8gYmUgdHJ1ZSwgdGhlIHJlc3VsdCBpcyBwb3RlbnRpYWwgdHlwZQo+ID4gICAgY29u ZnVzaW9uIGluIHJlbGVhc2UgYnVpbGRzIGJhc2VkIG9uIHNldmVyYWwgc3VidGxlIGFzcGVjdHMg b2YgdGhlIENQVUlECj4gPiAgICBmZWF0dXJlIGRlcml2YXRpb24gbG9naWMgd2l0aCBubyBvdGhl ciBzYWZldHkgY2hlY2tzLiAgVGhpcyBhbHNvIGZpeGVzIHRoZQo+ID4gICAgYSBsaW5rZXIgZXJy b3IgaW4gdGhlIHJlbGVhc2UgYnVpbGQgb2YgdGhlIHNoaW0sIGFnYWluIGZvciAhQ09ORklHX0hW TQo+ID4gICAgcmVhc29ucy4KPiAKPiBBZ2FpbiwgZGlnZ2luZyBiYWNrIGluIG1haWwuLi4KPiAK PiAtLS0tLQo+IFtGcm9tIEphbl0KPiA+ICsgICAgY2FzZSBNU1JfSUEzMl9CTkRDRkdTOgo+ID4g KyAgICAgICAgaWYgKCAhaXNfaHZtX2RvbWFpbihkKSB8fCAhY3AtPmZlYXQubXB4IHx8Cj4gPiAr ICAgICAgICAgICAgICFodm1fc2V0X2d1ZXN0X2JuZGNmZ3ModiwgdmFsKSApCj4gPiArICAgICAg ICAgICAgZ290byBncF9mYXVsdDsKPiAKPiBJbiBib3RoIGNhc2VzIHRoZSBpc19odm1fKigpIGNo ZWNrIGxvb2tzIHRvIGJlIHJlZHVuZGFudCwgYXMKPiBmb3IgUFYgZ3Vlc3RzIGNwLT5mZWF0Lm1w eCBjYW4ndCBiZSBzZXQuIFBlcnNvbmFsbHkgSSdkIHByZWZlcgo+IHRoaXMgdG8gYmUgYW4gQVNT RVJUKCkgaW5zdGVhZCwgYnV0IEknZCBsaXN0ZW4gdG8gQW5kcmV3IChhcwo+IHRoZSBtYWluIGF1 dGhvciBvZiB0aGlzIGNvZGUpIHNheWluZyBvdGhlcndpc2UuCj4gLS0tLS0KPiAKPiAuLi5hbmQg SSBkbyByZWNhbGwgYXNraW5nIGZvciB5b3VyIG9waW5pb24gYXQgdGhlIHRpbWUuIEkgZ3Vlc3Mg eW91IGNoYW5nZWQgeW91ciBtaW5kLgo+IAo+ID4gICogVGhlIE1TUnMgaW4gdmNwdV9tc3JzIGFy ZSBpbiBudW1lcmljIG9yZGVyLiAgUmUtcG9zaXRpb24gWFNTIHRvIG1hdGNoLgo+ID4KPiAKPiBU aGF0IHdhcyBub3QgYXQgYWxsIG9idmlvdXMuIElmIHRoaXMgaXMgdGhlIGNhc2UgdGhlbiB0aGVy ZSBzaG91bGQgYmUgY29tbWVudCBhYm92ZSB0aGUgZGVjbGFyYXRpb24gb2YKPiBzdHJ1Y3QgdmNw dV9tc3JzLgo+IAo+ID4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4KPiAKPiBIb3dldmVyLCB0aGUgY2hhbmdlcyBsb29rIG9rIHRvIG1lIGFu ZCBicmluZ3MgdGhpbmdzIGNsb3NlciB0byBteSBlYXJsaWVyIGNvZGUgYW55d2F5IHNvLCB3aXRo IHRoZQo+IGNvbW1lbnQgcmVxdWVzdGVkIGFib3ZlIGFkZGVkLi4uCj4gCj4gUmV2aWV3ZWQtYnk6 IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs