* [PATCH] arm: mach-s3c: Remove unnecessary break
@ 2021-04-09 6:49 ` Wan Jiabing
0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2021-04-09 6:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Russell King, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: kael_w, Wan Jiabing
There is a return above the break.
The break here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
arch/arm/mach-s3c/mach-rx1950.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-s3c/mach-rx1950.c b/arch/arm/mach-s3c/mach-rx1950.c
index 6e19add158a9..9da94686001a 100644
--- a/arch/arm/mach-s3c/mach-rx1950.c
+++ b/arch/arm/mach-s3c/mach-rx1950.c
@@ -271,7 +271,6 @@ static int rx1950_led_blink_set(struct gpio_desc *desc, int state,
break;
default:
return -EINVAL;
- break;
}
if (delay_on && delay_off && !*delay_on && !*delay_off)
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm: mach-s3c: Remove unnecessary break
@ 2021-04-09 6:49 ` Wan Jiabing
0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2021-04-09 6:49 UTC (permalink / raw)
To: Krzysztof Kozlowski, Russell King, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: kael_w, Wan Jiabing
There is a return above the break.
The break here is unnecessary. Remove it.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
arch/arm/mach-s3c/mach-rx1950.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-s3c/mach-rx1950.c b/arch/arm/mach-s3c/mach-rx1950.c
index 6e19add158a9..9da94686001a 100644
--- a/arch/arm/mach-s3c/mach-rx1950.c
+++ b/arch/arm/mach-s3c/mach-rx1950.c
@@ -271,7 +271,6 @@ static int rx1950_led_blink_set(struct gpio_desc *desc, int state,
break;
default:
return -EINVAL;
- break;
}
if (delay_on && delay_off && !*delay_on && !*delay_off)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: mach-s3c: Remove unnecessary break
2021-04-09 6:49 ` Wan Jiabing
@ 2021-04-13 15:07 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-13 15:07 UTC (permalink / raw)
To: Wan Jiabing, Russell King, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: kael_w
On 09/04/2021 08:49, Wan Jiabing wrote:
> There is a return above the break.
> The break here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> arch/arm/mach-s3c/mach-rx1950.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, looks good but I do not plan another pull request in current
cycle, so I will take it after the merge window.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: mach-s3c: Remove unnecessary break
@ 2021-04-13 15:07 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-13 15:07 UTC (permalink / raw)
To: Wan Jiabing, Russell King, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: kael_w
On 09/04/2021 08:49, Wan Jiabing wrote:
> There is a return above the break.
> The break here is unnecessary. Remove it.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> arch/arm/mach-s3c/mach-rx1950.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, looks good but I do not plan another pull request in current
cycle, so I will take it after the merge window.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: mach-s3c: Remove unnecessary break
2021-04-09 6:49 ` Wan Jiabing
@ 2021-05-11 12:31 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-11 12:31 UTC (permalink / raw)
To: linux-samsung-soc, Wan Jiabing, linux-arm-kernel, Russell King,
linux-kernel, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, kael_w
On Fri, 9 Apr 2021 14:49:20 +0800, Wan Jiabing wrote:
> There is a return above the break.
> The break here is unnecessary. Remove it.
Applied, thanks!
[1/1] arm: mach-s3c: Remove unnecessary break
commit: 0de0b04c83430ee913c9683369b7059e04e106cb
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: mach-s3c: Remove unnecessary break
@ 2021-05-11 12:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-11 12:31 UTC (permalink / raw)
To: linux-samsung-soc, Wan Jiabing, linux-arm-kernel, Russell King,
linux-kernel, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, kael_w
On Fri, 9 Apr 2021 14:49:20 +0800, Wan Jiabing wrote:
> There is a return above the break.
> The break here is unnecessary. Remove it.
Applied, thanks!
[1/1] arm: mach-s3c: Remove unnecessary break
commit: 0de0b04c83430ee913c9683369b7059e04e106cb
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-11 13:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 6:49 [PATCH] arm: mach-s3c: Remove unnecessary break Wan Jiabing
2021-04-09 6:49 ` Wan Jiabing
2021-04-13 15:07 ` Krzysztof Kozlowski
2021-04-13 15:07 ` Krzysztof Kozlowski
2021-05-11 12:31 ` Krzysztof Kozlowski
2021-05-11 12:31 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.