From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3 2/6] ethdev: return named
 opaque type instead of void pointer
Date: Thu, 18 Jan 2018 10:09:15 +0000
Message-ID: <1c3e60a1-5824-77df-4bf4-dac2f8b8059e@intel.com>
References: <20180109162317.18183-1-ferruh.yigit@intel.com>
 <20180117215802.90809-1-ferruh.yigit@intel.com>
 <20180117215802.90809-2-ferruh.yigit@intel.com> <2207589.F0NTZTrxns@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: stable@dpdk.org, dev@dpdk.org, declan.doherty@intel.com,
 Boris Pismenny <borisp@mellanox.com>, Aviad Yehezkel <aviadye@mellanox.com>,
 Radu Nicolau <radu.nicolau@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <2207589.F0NTZTrxns@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/17/2018 10:11 PM, Thomas Monjalon wrote:
> 17/01/2018 22:57, Ferruh Yigit:
>> "struct rte_eth_rxtx_callback" is defined as internal data structure and
>> used as named opaque type.
>>
>> So the functions that are adding callbacks can return objects in this
>> type instead of void pointer.
> 
> It is an API change.
> Let's plan it for 18.05.

No issue for pushing this to next release, but not sure if this API change
effects end user.

"struct rte_eth_rxtx_callback" is private data structure, previously how user
should be using it can be:

a)
void *cb;
cb = rte_eth_add_rx_callback(..);
rte_eth_remove_rx_callback(.., cb);

b)
struct rte_eth_rxtx_callback *cb;
cb = rte_eth_add_rx_callback(..);
rte_eth_remove_rx_callback(.., cb);


And same a) or b) can be used without any side effect with updated API.