From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D841C433E0 for ; Wed, 13 Jan 2021 11:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAE1823358 for ; Wed, 13 Jan 2021 11:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbhAMLPb (ORCPT ); Wed, 13 Jan 2021 06:15:31 -0500 Received: from mga18.intel.com ([134.134.136.126]:42284 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727555AbhAMLPa (ORCPT ); Wed, 13 Jan 2021 06:15:30 -0500 IronPort-SDR: i4yMyrfLqYNeTywb5IobYinT4X/oDmP08dLmYQeiH7A2cuDITJ7PK0TX0sWhgFuzXiH3un3rx+ 9zqsU1dUMx6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="165862791" X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="165862791" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:13:49 -0800 IronPort-SDR: GmAM/i5R61hb8NxYgDEqZuOpRnjbczA38Z9k1eNZ4tN9qowY61kjGRBYoTSpoqEQjeuBMucovY JELjplp0AUJQ== X-IronPort-AV: E=Sophos;i="5.79,344,1602572400"; d="scan'208";a="381806146" Received: from aantonov-mobl.ccr.corp.intel.com (HELO [10.249.225.249]) ([10.249.225.249]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 03:13:46 -0800 Subject: Re: [PATCH v2 2/6] perf evsel: Introduce an observed performance device To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , linux-kernel , Jiri Olsa , Andi Kleen , Alexander Shishkin , Mark Rutland , Ian Rogers , Ingo Molnar , Peter Zijlstra References: <20201223130320.3930-1-alexander.antonov@linux.intel.com> <20201223130320.3930-3-alexander.antonov@linux.intel.com> From: Alexander Antonov Message-ID: <1c42b0c5-2731-ff9c-0b8b-4becf8ecef07@linux.intel.com> Date: Wed, 13 Jan 2021 14:13:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/6/2021 11:44 AM, Namhyung Kim wrote: > Hi, > > On Wed, Dec 23, 2020 at 10:03 PM Alexander Antonov > wrote: >> Adding evsel::perf_device void pointer. >> >> For performance monitoring purposes, an evsel can have a related device. >> These changes allow to attribute, for example, I/O performance metrics >> to IIO stack. >> >> Signed-off-by: Alexander Antonov >> --- >> tools/perf/util/evsel.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h >> index 79a860d8e3ee..c346920f477a 100644 >> --- a/tools/perf/util/evsel.h >> +++ b/tools/perf/util/evsel.h >> @@ -127,6 +127,7 @@ struct evsel { >> * See also evsel__has_callchain(). >> */ >> __u64 synth_sample_type; >> + void *perf_device; > Maybe we can use the existing 'priv' field. > > Thanks, > Namhyung Hello Namhyung, Looks like the 'priv' field isn't used in this case. I suppose it can be re-used in iiostat mode. Thanks, Alexander > >> }; >> >> struct perf_missing_features { >> -- >> 2.19.1 >>