All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed
Date: Thu, 9 Apr 2020 09:42:43 +0100	[thread overview]
Message-ID: <1c47516b-f087-6792-bf05-97f498e503c2@intel.com> (raw)
In-Reply-To: <854770a880777e7ad200481294a7aa5ac9a45f2d.1586361368.git.anatoly.burakov@intel.com>

Hi Anatoly,

On 8/4/2020 4:56 PM, Anatoly Burakov wrote:
> Currently, if power library initialization fails, only a log message is
> displayed. This is suboptimal for a number of reasons, but the main one
> is that telemetry mode does not depend on the power library and can
> therefore run in environments where l3fwd-power would normally not run
> correctly (such as inside a VM). This will lead to attempts to
> deinitialize the power library on exit, with a subsequent forced unclean
> shutdown of DPDK.
>
> Fix this by only initializing the power library in modes that actually
> need it, and change a log message to a failure to initialize.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   examples/l3fwd-power/main.c | 20 +++++++++++---------
>   1 file changed, 11 insertions(+), 9 deletions(-)
>

Acked-by: David Hunt <david.hunt@intel.com>



  parent reply	other threads:[~2020-04-09  8:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 15:56 [dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed Anatoly Burakov
2020-04-08 15:56 ` [dpdk-dev] [PATCH 2/2] l3fwd-power: implement proper shutdown handling Anatoly Burakov
2020-04-09  8:44   ` Hunt, David
2020-04-09  9:22   ` Pattan, Reshma
2020-04-09  8:42 ` Hunt, David [this message]
2020-04-09  9:23 ` [dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed Pattan, Reshma
2020-04-20 17:56 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
2020-04-28 11:19   ` Xie, WeiX
2020-04-20 17:56 ` [dpdk-dev] [PATCH v2 2/2] l3fwd-power: implement proper shutdown handling Anatoly Burakov
2020-04-26 21:52   ` Thomas Monjalon
2020-04-28 11:19   ` Xie, WeiX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c47516b-f087-6792-bf05-97f498e503c2@intel.com \
    --to=david.hunt@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.