From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEL6K-0000gN-Q6 for qemu-devel@nongnu.org; Thu, 03 May 2018 16:45:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEL6J-0001sX-W7 for qemu-devel@nongnu.org; Thu, 03 May 2018 16:45:16 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56056 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEL6J-0001rq-Rz for qemu-devel@nongnu.org; Thu, 03 May 2018 16:45:15 -0400 References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-6-git-send-email-mst@redhat.com> <5fbe4232-ca1a-5e0c-437c-8b63cf83c510@redhat.com> <20180503230505-mutt-send-email-mst@kernel.org> <20180503232542-mutt-send-email-mst@kernel.org> From: Eric Blake Message-ID: <1c48254a-1b86-c60e-e491-47e171a37638@redhat.com> Date: Thu, 3 May 2018 15:45:08 -0500 MIME-Version: 1.0 In-Reply-To: <20180503232542-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, berrange@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org, Juan Quintela , "Dr. David Alan Gilbert" On 05/03/2018 03:29 PM, Michael S. Tsirkin wrote: >> >> There are a few .c files exempt from including osdep.h, but in general, >> those files should probably also not be including anything from include/. > > Here's a list from a quick grep. > Most of them probably get osdep.h indirectly. > > > +contrib/libvhost-user/libvhost-user.c contrib may or may not be exempt; but it's not in the whitelist. > +hw/rdma/rdma_utils.c Probably a bug; looks like a recently added file. > +libuser/trace.c Huh? I don't see this file in git. > +target/mips/translate_init.c > +target/ppc/mfrom_table.c Probably bugs. > +target/ppc/translate/dfp-impl.inc.c This, and all other .inc.c, are indeed picking it up indirectly (by the master .c that is including these secondary .c), so they are exempt. They are whitelisted by the script via the shell case statement. > +target/s390x/gen-features.c Possibly a bug. > +tests/multiboot/libc.c > +tests/multiboot/mmap.c > +tests/multiboot/modules.c Exempt, per the XDIRREGEX in scripts/clean-includes > > lots of files under tests/tcg Also exempt. > > +tests/test-qapi-event.c Huh? That starts with #include "qemu/osdep.h". But it's not a file under version control. In fact, it's stale leftovers (it used to be generated by that name, but now we generate tests/test-qapi-events.c. > +tests/test-qapi-types.c > +tests/test-qapi-visit.c > +tests/test-qmp-introspect.c > +tests/test-qmp-marshal.c Again, how are you flagging these generated files? > > +ui/keycodemapdb/tests/stdc.c Exempt, since it's in a submodule. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org