From: Johannes Sixt <j6t@kdbg.org>
To: jeffhost@microsoft.com
Cc: Jeff Hostetler via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes
Date: Sat, 8 Sep 2018 11:26:58 +0200 [thread overview]
Message-ID: <1c524f56-2021-a961-168f-e5c6d7914ec2@kdbg.org> (raw)
In-Reply-To: <f433937d55974b75750cfc7d579a6a56109259a4.1536344387.git.gitgitgadget@gmail.com>
Am 07.09.2018 um 20:19 schrieb Jeff Hostetler via GitGitGadget:
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> ---
> compat/mingw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/compat/mingw.c b/compat/mingw.c
> index 858ca14a57..ef03bbe5d2 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -355,7 +355,7 @@ static int mingw_open_append(wchar_t const *wfilename, int oflags, ...)
> * FILE_SHARE_WRITE is required to permit child processes
> * to append to the file.
> */
> - handle = CreateFileW(wfilename, FILE_APPEND_DATA,
> + handle = CreateFileW(wfilename, FILE_WRITE_DATA | FILE_APPEND_DATA,
> FILE_SHARE_WRITE | FILE_SHARE_READ,
> NULL, create, FILE_ATTRIBUTE_NORMAL, NULL);
> if (handle == INVALID_HANDLE_VALUE)
>
I did not go with this version because the documentation
https://docs.microsoft.com/en-us/windows/desktop/fileio/file-access-rights-constants
says:
FILE_APPEND_DATA: For a file object, the right to append data to the
file. (For local files, write operations will not overwrite existing
data if this flag is specified without FILE_WRITE_DATA.) [...]
which could be interpreted as: Only if FILE_WRITE_DATA is not set, we
have the guarantee that existing data in local files is not overwritten,
i.e., new data is appended atomically.
Is this interpretation too narrow and we do get atomicity even when
FILE_WRITE_DATA is set?
-- Hannes
next prev parent reply other threads:[~2018-09-08 9:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 18:19 [PATCH 0/2] Fixup for js/mingw-o-append Jeff Hostetler via GitGitGadget
2018-09-07 18:19 ` [PATCH 1/2] t0051: test GIT_TRACE to a windows named pipe Jeff Hostetler via GitGitGadget
2018-09-09 7:28 ` Sebastian Schuberth
2018-09-10 13:21 ` Jeff Hostetler
2018-09-07 18:19 ` [PATCH 2/2] mingw: fix mingw_open_append to work with named pipes Jeff Hostetler via GitGitGadget
2018-09-08 9:26 ` Johannes Sixt [this message]
2018-09-08 18:31 ` Johannes Sixt
2018-09-10 15:44 ` Jeff Hostetler
2018-09-10 16:42 ` Junio C Hamano
2018-09-10 16:55 ` Jeff Hostetler
2018-09-07 18:36 ` [PATCH 0/2] Fixup for js/mingw-o-append Jeff Hostetler
2018-09-10 17:05 ` [PATCH v2 " Jeff Hostetler via GitGitGadget
2018-09-10 17:05 ` [PATCH v2 1/2] t0051: test GIT_TRACE to a windows named pipe Jeff Hostetler via GitGitGadget
2018-09-10 17:05 ` [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes Jeff Hostetler via GitGitGadget
2018-09-10 19:45 ` Johannes Sixt
2018-09-10 20:07 ` Jeff Hostetler
2018-09-10 22:00 ` Junio C Hamano
2018-09-11 14:25 ` Jeff Hostetler
2018-09-11 20:05 ` [PATCH v3 0/2] Fixup for js/mingw-o-append Jeff Hostetler via GitGitGadget
2018-09-11 20:06 ` [PATCH v3 1/2] t0051: test GIT_TRACE to a windows named pipe Jeff Hostetler via GitGitGadget
2018-09-11 20:06 ` [PATCH v3 2/2] mingw: fix mingw_open_append to work with named pipes Jeff Hostetler via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c524f56-2021-a961-168f-e5c6d7914ec2@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.