On 04/14/2017 10:25 AM, Kołłątaj, Remigiusz wrote: > Hi Marc, > > Thanks for the review. My answers/comments inline. > > On 13 April 2017 at 17:56, Marc Kleine-Budde wrote: >> >> On 01/25/2017 02:02 PM, Remigiusz Kołłątaj wrote: >>> SocketCAN driver for Microchip CAN BUS Analyzer >>> (http://www.microchip.com/development-tools/) >>> >>> Changes since v2: >>> - improved/simplified CAN ID conversion >>> - functions for transmission of skb and cmd separated >>> - fixed/improved netif_stop_queue handling >>> - style/cosmetic corrections >>> >>> Changes since v1: >>> - Termination handling reimplemented to fit new netlink API >>> (IFLA_CAN_TERMINATION) >>> - Bitrate handling reimplemented to fit new netlink API >>> (IFLA_CAN_BITRATE) >>> - CAN ID conversion refactored (changed from macro to inline functions) >>> - CAN DLC handling using get_can_dlc() >>> - Endianness handling for can_speed introduced >>> - Debugging removed >>> - Redundant error prints removed >>> - Style/cosmetic corrections (i.e. macro names, redefs, inits etc.) >>> >>> Signed-off-by: Remigiusz Kołłątaj >> >> Can you pleeas add LED support, see commit: >> >> adccadb92f05 can: flexcan: add LED trigger support >> >> as an example. More comments inline. >> > > In MBCA leds are controlled by device itself - CAN status leds are > connected directly CANTX and CANRX pins of PIC controller and CAN > Error led is driven by firmware. With LED support in the driver, you can use CAN RX and/or TX events to drive generic LEDs. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |