From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 1/2] drm/i915: Allow control of PSR at runtime through debugfs, v4. Date: Wed, 1 Aug 2018 11:41:32 +0200 Message-ID: <1c66dcb9-2440-aab4-fc4b-630db61576a4@linux.intel.com> References: <1532755389.7639.59.camel@intel.com> <20180731133559.6892-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2267188867 for ; Wed, 1 Aug 2018 09:41:35 +0000 (UTC) In-Reply-To: <20180731133559.6892-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T3AgMzEtMDctMTggb20gMTU6MzUgc2NocmVlZiBNYWFydGVuIExhbmtob3JzdDoKPiBDdXJyZW50 bHkgdGVzdHMgbW9kaWZ5IGk5MTUuZW5hYmxlX3BzciBhbmQgdGhlbiBkbyBhIG1vZGVzZXQgY3lj bGUKPiB0byBjaGFuZ2UgUFNSLiBXZSBjYW4gd3JpdGUgYSB2YWx1ZSB0byBpOTE1X2VkcF9wc3Jf ZGVidWcgdG8gZm9yY2UKPiBhIGNlcnRhaW4gUFNSIG1vZGUgd2l0aG91dCBhIG1vZGVzZXQuCj4K PiBUbyByZXRhaW4gY29tcGF0aWJpbGl0eSB3aXRoIG9sZGVyIHVzZXJzcGFjZSwgd2UgYWxzbyBz dGlsbCBhbGxvdwo+IHRoZSBvdmVycmlkZSB0aHJvdWdoIHRoZSBtb2R1bGUgcGFyYW1ldGVyLCBh bmQgYWRkIHNvbWUgdHJhY2tpbmcKPiB0byBjaGVjayB3aGV0aGVyIGEgZGVidWdmcyBtb2RlIGlz IHNwZWNpZmllZC4KPgo+IENoYW5nZXMgc2luY2UgdjE6Cj4gLSBSZW5hbWUgZGV2X3ByaXYtPnBz ci5lbmFibGVkIHRvIC5kcCwgYW5kIC5od19jb25maWd1cmVkIHRvIC5lbmFibGVkLgo+IC0gRml4 IGk5MTVfcHNyX2RlYnVnZnNfbW9kZSB0byBtYXRjaCB0aGUgd3JpdGVzIHRvIGRlYnVnZnMuCj4g LSBSZW5hbWUgX19pOTE1X2VkcF9wc3Jfd3JpdGUgdG8gaW50ZWxfcHNyX3NldF9kZWJ1Z2ZzX21v ZGUsIHNpbXBsaWZ5Cj4gICBpdCBhbmQgbW92ZSBpdCB0byBpbnRlbF9wc3IuYy4gVGhpcyBrZWVw cyBhbGwgaW50ZXJuYWxzIGluIGludGVsX3Bzci5jCj4gLSBQZXJmb3JtIGFuIGludGVycnVwdGli bGUgd2FpdCBmb3IgaHcgY29tcGxldGlvbiBvdXRzaWRlIG9mIHRoZSBwc3IKPiAgIGxvY2ssIGlu c3RlYWQgb2YgYmVpbmcgZm9yY2VkIHRvIHRyeXdhaXQgYW5kIHJldHVybiAtRUJVU1kuCj4gQ2hh bmdlcyBzaW5jZSB2MjoKPiAtIFJlYmFzZSBvbiB0b3Agb2YgaW50ZWxfcHNyIGNoYW5nZXMuCj4g Q2hhbmdlcyBzaW5jZSB2MzoKPiAtIEFzc2lnbiBwc3IuZHAgZHVyaW5nIGluaXQuIChkaG5rcm4p Cj4gLSBBZGQgcHJlcGFyZWQgYm9vbCwgd2hpY2ggc2hvdWxkIGJlIHVzZWQgaW5zdGVhZCBvZiBy ZWx5aW5nIG9uIHBzci5kcC4gKGRobmtybikKPiAtIEZpeCAtRURFQURMSyBoYW5kbGluZyBpbiBk ZWJ1Z2ZzLiAoZGhua3JuKQo+IC0gQ2xlYW4gdXAgd2FpdGluZyBmb3IgaWRsZSBpbiBpbnRlbF9w c3Jfc2V0X2RlYnVnZnNfbW9kZS4KPiAtIFByaW50IFBTUiBtb2RlIHdoZW4gdHJ5aW5nIHRvIGVu YWJsZSBQU1IuIChkaG5rcm4pCj4gLSBNb3ZlIGNoYW5naW5nIHBzciBkZWJ1ZyBzZXR0aW5nIHRv IGk5MTVfZWRwX3Bzcl9kZWJ1Z19zZXQuIChkaG5rcm4pCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYWFy dGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBS b2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IERoaW5ha2FyYW4gUGFu ZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8ICAyMSArKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oICAgICB8ICAxMiArKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9pcnEuYyAgICAgfCAgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2Lmgg ICAgfCAgIDUgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgICAgfCAxMzYg KysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ICA1IGZpbGVzIGNoYW5nZWQsIDE0NCBpbnNl cnRpb25zKCspLCAzMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdm cy5jCj4gaW5kZXggNTlkYzA2MTBlYTQ0Li5hN2U5Mjc0MTNlOGUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0yNzA1LDcgKzI3MDUsNyBAQCBzdGF0aWMgaW50IGk5 MTVfZWRwX3Bzcl9zdGF0dXMoc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAJaW50 ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+ICAKPiAgCW11dGV4X2xvY2soJmRldl9wcml2 LT5wc3IubG9jayk7Cj4gLQlzZXFfcHJpbnRmKG0sICJFbmFibGVkOiAlc1xuIiwgeWVzbm8oKGJv b2wpZGV2X3ByaXYtPnBzci5lbmFibGVkKSk7Cj4gKwlzZXFfcHJpbnRmKG0sICJFbmFibGVkOiAl c1xuIiwgeWVzbm8oZGV2X3ByaXYtPnBzci5lbmFibGVkKSk7Cj4gIAlzZXFfcHJpbnRmKG0sICJC dXN5IGZyb250YnVmZmVyIGJpdHM6IDB4JTAzeFxuIiwKPiAgCQkgICBkZXZfcHJpdi0+cHNyLmJ1 c3lfZnJvbnRidWZmZXJfYml0cyk7Cj4gIAo+IEBAIC0yNzQ3LDE0ICsyNzQ3LDI5IEBAIHN0YXRp YyBpbnQKPiAgaTkxNV9lZHBfcHNyX2RlYnVnX3NldCh2b2lkICpkYXRhLCB1NjQgdmFsKQo+ICB7 Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkYXRhOwo+ICsJc3RydWN0 IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGN0eDsKPiArCWludCByZXQ7Cj4gIAo+ICAJaWYgKCFD QU5fUFNSKGRldl9wcml2KSkKPiAgCQlyZXR1cm4gLUVOT0RFVjsKPiAgCj4gLQlEUk1fREVCVUdf S01TKCJQU1IgZGVidWcgJXNcbiIsIGVuYWJsZWRkaXNhYmxlZCh2YWwpKTsKPiArCURSTV9ERUJV R19LTVMoIlNldHRpbmcgUFNSIGRlYnVnIHRvICVsbHhcbiIsIHZhbCk7Cj4gIAo+ICAJaW50ZWxf cnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+IC0JaW50ZWxfcHNyX2lycV9jb250cm9sKGRldl9w cml2LCAhIXZhbCk7Cj4gKwo+ICsJZHJtX21vZGVzZXRfYWNxdWlyZV9pbml0KCZjdHgsIERSTV9N T0RFU0VUX0FDUVVJUkVfSU5URVJSVVBUSUJMRSk7Cj4gKwo+ICtyZXRyeToKPiArCXJldCA9IGlu dGVsX3Bzcl9zZXRfZGVidWdmc19tb2RlKGRldl9wcml2LCAmY3R4LCB2YWwpOwo+ICsJaWYgKHJl dCA9PSAtRURFQURMSykgewo+ICsJCXJldCA9IGRybV9tb2Rlc2V0X2JhY2tvZmYoJmN0eCk7Cj4g KwkJaWYgKCFyZXQpCj4gKwkJCWdvdG8gcmV0cnk7Cj4gKwl9Cj4gKwo+ICsJZHJtX21vZGVzZXRf ZHJvcF9sb2NrcygmY3R4KTsKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiAr Cj4gIAlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gIAo+ICAJcmV0dXJuIDA7Cl5P b3BzLCBuZWVkcyB0byBiZSBjaGFuZ2VkIHRvIHJldHVybiByZXQ7Cgp+TWFhcnRlbgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK