From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A5FC2D0C0 for ; Mon, 23 Dec 2019 14:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBADF20709 for ; Mon, 23 Dec 2019 14:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbfLWO17 (ORCPT ); Mon, 23 Dec 2019 09:27:59 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33172 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726791AbfLWO17 (ORCPT ); Mon, 23 Dec 2019 09:27:59 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 8D11B292129 Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge To: Nicolas Boichat Cc: lkml , Collabora Kernel ML , Matthias Brugger , Hsin-Yi Wang , Jitao Shi , Daniel Kurtz , Ulrich Hecht , linux-arm Mailing List , Andrzej Hajda , Jonas Karlman , dri-devel@lists.freedesktop.org, Neil Armstrong , "moderated list:ARM/Mediatek SoC support" , David Airlie , Jernej Skrabec , Laurent Pinchart , Daniel Vetter References: <20191220081738.1895-1-enric.balletbo@collabora.com> <20191220081738.1895-3-enric.balletbo@collabora.com> <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com> From: Enric Balletbo i Serra Message-ID: <1c68fa67-c4c4-ea78-bfe4-6344799bbf46@collabora.com> Date: Mon, 23 Dec 2019 15:27:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, On 23/12/19 10:14, Nicolas Boichat wrote: > On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> Many thanks for you review. Just preparing a new version with your comments >> addressed. >> >> On 20/12/19 9:44, Nicolas Boichat wrote: >>> On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra >>> wrote: >>>> >>>> From: Jitao Shi >>>> >>>> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >>>> >>>> Signed-off-by: Jitao Shi >>>> Reviewed-by: Daniel Kurtz >>>> Reviewed-by: Enric Balletbo i Serra >>>> [uli: followed API changes, removed FW update feature] >>>> Signed-off-by: Ulrich Hecht >>>> Signed-off-by: Enric Balletbo i Serra >>>> --- >> [snip] >>>> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN, >>>> + status & ~MCS_EN); >>>> + if (ret < 0) { >>>> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret); >>>> + goto err_regulators_disable; >>>> + } >>>> + >>>> + ret = ps8640_bridge_unmute(ps_bridge); >>>> + if (ret) >>>> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret); >>> >>> failed to unmute? Or failed to enable? >>> >> >> failed to unmute sound more clear to me. > > I may be wrong, but I have the feeling that the functions > "mute/unmute" video/display, actually... And that the function naming > is strange... > Yes, that's strange. > You could just try to remove the calls, as there is no audio on the > board you have (elm), so if video still works, maybe this is actually > audio ,-) > And without those the display doesn't work. So I suspect that what is wrong and confusing is the message, instead of mute/unmute, and based on the register names this looks more like an internal regulator that you need to enable and disable, so I'll change the error message accordingly. Thanks, Enric > Thanks, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC190C2D0C0 for ; Mon, 23 Dec 2019 14:28:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCFB220709 for ; Mon, 23 Dec 2019 14:28:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZZoz5pae" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCFB220709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bQ3TOk6+RLRcE4KZAPNXO2zmKDlYoOYRbQvlfL7EWWQ=; b=ZZoz5paeWRcdBN C7apgwC7jLPx9PZanilXeE0BbP7ddnBZG0Jj2AcIq/AhkfgN4kwiWWE66Hs/Dpfx6FIw7liYZqwGK +r2IccqMJRP8nJlCaijmo95qOOET3wLGv186Oy11IfNXEFywJ/SQw5XZM673ix/8FHmitmJa8WFHC eLHa22Z/afTytxgSf0/TZHaOsZr+BJEMXgrLoDOMRm3C9w3a0NURVqvlyMd1ioaeBUDb9ak6RSArx QA0e+n6OHu9cQ7B4wOALGfWo4EwhxR8+O8aEConOKjv6GCFxisBq9555M4r7Un0mwCwVvnVnJUEEe xSx/HCvMEQWzcQS/f0tQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijOgw-0007Sp-2v; Mon, 23 Dec 2019 14:28:14 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijOgh-00076P-JN; Mon, 23 Dec 2019 14:28:01 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 8D11B292129 Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge To: Nicolas Boichat References: <20191220081738.1895-1-enric.balletbo@collabora.com> <20191220081738.1895-3-enric.balletbo@collabora.com> <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com> From: Enric Balletbo i Serra Message-ID: <1c68fa67-c4c4-ea78-bfe4-6344799bbf46@collabora.com> Date: Mon, 23 Dec 2019 15:27:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191223_062759_792943_1D04954E X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulrich Hecht , Jernej Skrabec , Jitao Shi , Jonas Karlman , David Airlie , Neil Armstrong , lkml , Andrzej Hajda , "moderated list:ARM/Mediatek SoC support" , dri-devel@lists.freedesktop.org, Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , Collabora Kernel ML , linux-arm Mailing List , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Nicolas, On 23/12/19 10:14, Nicolas Boichat wrote: > On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> Many thanks for you review. Just preparing a new version with your comments >> addressed. >> >> On 20/12/19 9:44, Nicolas Boichat wrote: >>> On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra >>> wrote: >>>> >>>> From: Jitao Shi >>>> >>>> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >>>> >>>> Signed-off-by: Jitao Shi >>>> Reviewed-by: Daniel Kurtz >>>> Reviewed-by: Enric Balletbo i Serra >>>> [uli: followed API changes, removed FW update feature] >>>> Signed-off-by: Ulrich Hecht >>>> Signed-off-by: Enric Balletbo i Serra >>>> --- >> [snip] >>>> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN, >>>> + status & ~MCS_EN); >>>> + if (ret < 0) { >>>> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret); >>>> + goto err_regulators_disable; >>>> + } >>>> + >>>> + ret = ps8640_bridge_unmute(ps_bridge); >>>> + if (ret) >>>> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret); >>> >>> failed to unmute? Or failed to enable? >>> >> >> failed to unmute sound more clear to me. > > I may be wrong, but I have the feeling that the functions > "mute/unmute" video/display, actually... And that the function naming > is strange... > Yes, that's strange. > You could just try to remove the calls, as there is no audio on the > board you have (elm), so if video still works, maybe this is actually > audio ,-) > And without those the display doesn't work. So I suspect that what is wrong and confusing is the message, instead of mute/unmute, and based on the register names this looks more like an internal regulator that you need to enable and disable, so I'll change the error message accordingly. Thanks, Enric > Thanks, > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B96AC2D0CF for ; Mon, 23 Dec 2019 14:28:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AED020709 for ; Mon, 23 Dec 2019 14:28:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hinrrL+Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AED020709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=61TS3kyj8Z8kJnhOY0eIYTps1Nutmx58gKu3j0vRLIY=; b=hinrrL+QzMy7OQ cG4wM3x8Ip0JaTis8i8y41FESwGtBdMf49/nsd9qPhohvG0BU+IlPNE0X851KDdP53Si3nHOHb+ht rZwGxTuCGCeJODBtYidIaODuLTTkd0M5e6ESTh67knQTWk7jIOerWx04ZX26waI+dQfLbQcGukGZt WJtwNvnBUx7g1sQMB/3abT+Gv0szQUnQTTj1cfF7uvzfon6BBVQSr6aHUwSbgbUotIwTdBjyq3gui mq73Xt2ucFz/siXDXsrAgIHyNfxrULzOw79Xn4Q1Uw2h+R7BLbZj+z8SF77kxI+Ero6Va4uhTASJU xumnyg0hg7t+/d3FKuuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijOgl-00077p-A8; Mon, 23 Dec 2019 14:28:03 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijOgh-00076P-JN; Mon, 23 Dec 2019 14:28:01 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 8D11B292129 Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge To: Nicolas Boichat References: <20191220081738.1895-1-enric.balletbo@collabora.com> <20191220081738.1895-3-enric.balletbo@collabora.com> <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com> From: Enric Balletbo i Serra Message-ID: <1c68fa67-c4c4-ea78-bfe4-6344799bbf46@collabora.com> Date: Mon, 23 Dec 2019 15:27:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191223_062759_792943_1D04954E X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulrich Hecht , Jernej Skrabec , Jitao Shi , Jonas Karlman , David Airlie , Neil Armstrong , lkml , Daniel Kurtz , Andrzej Hajda , "moderated list:ARM/Mediatek SoC support" , dri-devel@lists.freedesktop.org, Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , Collabora Kernel ML , linux-arm Mailing List , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicolas, On 23/12/19 10:14, Nicolas Boichat wrote: > On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> Many thanks for you review. Just preparing a new version with your comments >> addressed. >> >> On 20/12/19 9:44, Nicolas Boichat wrote: >>> On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra >>> wrote: >>>> >>>> From: Jitao Shi >>>> >>>> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >>>> >>>> Signed-off-by: Jitao Shi >>>> Reviewed-by: Daniel Kurtz >>>> Reviewed-by: Enric Balletbo i Serra >>>> [uli: followed API changes, removed FW update feature] >>>> Signed-off-by: Ulrich Hecht >>>> Signed-off-by: Enric Balletbo i Serra >>>> --- >> [snip] >>>> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN, >>>> + status & ~MCS_EN); >>>> + if (ret < 0) { >>>> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret); >>>> + goto err_regulators_disable; >>>> + } >>>> + >>>> + ret = ps8640_bridge_unmute(ps_bridge); >>>> + if (ret) >>>> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret); >>> >>> failed to unmute? Or failed to enable? >>> >> >> failed to unmute sound more clear to me. > > I may be wrong, but I have the feeling that the functions > "mute/unmute" video/display, actually... And that the function naming > is strange... > Yes, that's strange. > You could just try to remove the calls, as there is no audio on the > board you have (elm), so if video still works, maybe this is actually > audio ,-) > And without those the display doesn't work. So I suspect that what is wrong and confusing is the message, instead of mute/unmute, and based on the register names this looks more like an internal regulator that you need to enable and disable, so I'll change the error message accordingly. Thanks, Enric > Thanks, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E707EC2D0D5 for ; Tue, 24 Dec 2019 14:30:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5BF220706 for ; Tue, 24 Dec 2019 14:30:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5BF220706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0C9B6E5C8; Tue, 24 Dec 2019 14:30:01 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1104089950 for ; Mon, 23 Dec 2019 14:27:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 8D11B292129 Subject: Re: [PATCH v22 2/2] drm/bridge: Add I2C based driver for ps8640 bridge To: Nicolas Boichat References: <20191220081738.1895-1-enric.balletbo@collabora.com> <20191220081738.1895-3-enric.balletbo@collabora.com> <05db638b-02a6-0e3a-43ed-44a0a1458d87@collabora.com> From: Enric Balletbo i Serra Message-ID: <1c68fa67-c4c4-ea78-bfe4-6344799bbf46@collabora.com> Date: Mon, 23 Dec 2019 15:27:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Tue, 24 Dec 2019 14:29:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulrich Hecht , Jernej Skrabec , Jitao Shi , Jonas Karlman , David Airlie , Neil Armstrong , lkml , "moderated list:ARM/Mediatek SoC support" , dri-devel@lists.freedesktop.org, Hsin-Yi Wang , Matthias Brugger , Collabora Kernel ML , linux-arm Mailing List , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nicolas, On 23/12/19 10:14, Nicolas Boichat wrote: > On Mon, Dec 23, 2019 at 3:10 PM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> Many thanks for you review. Just preparing a new version with your comments >> addressed. >> >> On 20/12/19 9:44, Nicolas Boichat wrote: >>> On Fri, Dec 20, 2019 at 4:17 PM Enric Balletbo i Serra >>> wrote: >>>> >>>> From: Jitao Shi >>>> >>>> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >>>> >>>> Signed-off-by: Jitao Shi >>>> Reviewed-by: Daniel Kurtz >>>> Reviewed-by: Enric Balletbo i Serra >>>> [uli: followed API changes, removed FW update feature] >>>> Signed-off-by: Ulrich Hecht >>>> Signed-off-by: Enric Balletbo i Serra >>>> --- >> [snip] >>>> + ret = i2c_smbus_write_byte_data(client, PAGE2_MCS_EN, >>>> + status & ~MCS_EN); >>>> + if (ret < 0) { >>>> + DRM_ERROR("failed write PAGE2_MCS_EN: %d\n", ret); >>>> + goto err_regulators_disable; >>>> + } >>>> + >>>> + ret = ps8640_bridge_unmute(ps_bridge); >>>> + if (ret) >>>> + DRM_ERROR("failed to enable unmutevideo: %d\n", ret); >>> >>> failed to unmute? Or failed to enable? >>> >> >> failed to unmute sound more clear to me. > > I may be wrong, but I have the feeling that the functions > "mute/unmute" video/display, actually... And that the function naming > is strange... > Yes, that's strange. > You could just try to remove the calls, as there is no audio on the > board you have (elm), so if video still works, maybe this is actually > audio ,-) > And without those the display doesn't work. So I suspect that what is wrong and confusing is the message, instead of mute/unmute, and based on the register names this looks more like an internal regulator that you need to enable and disable, so I'll change the error message accordingly. Thanks, Enric > Thanks, > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel