From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91D42C433F5 for ; Mon, 21 Feb 2022 09:07:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E7AB1408B3; Mon, 21 Feb 2022 09:07:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l0dk9tWZCPeD; Mon, 21 Feb 2022 09:07:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 0D0F14054A; Mon, 21 Feb 2022 09:07:35 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 603AC1BF2BA for ; Mon, 21 Feb 2022 09:07:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4C516404F6 for ; Mon, 21 Feb 2022 09:07:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=aruba.it Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13cdL5FkgjOl for ; Mon, 21 Feb 2022 09:07:31 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from smtpcmd0987.aruba.it (smtpcmd0987.aruba.it [62.149.156.87]) by smtp2.osuosl.org (Postfix) with ESMTP id 024CA4010E for ; Mon, 21 Feb 2022 09:07:30 +0000 (UTC) Received: from [192.168.50.220] ([146.241.188.82]) by Aruba Outgoing Smtp with ESMTPSA id M4fGnjuzHks1JM4fHnVBJp; Mon, 21 Feb 2022 10:07:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1645434449; bh=cHS6T91LFYzNG7NFiwPid17B6edauJmBqPzBtcxQkBI=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=Q9QHiZrBXOAsVv4CZOhfaKKftTlC6OqchXEVL7duVOQ2pTyRU+zLcWSvK0ggw6miM H42i/XLB2x8br8kSD8dCd7l29OPOvtUjNcmDxJ3CPdRWWWaC4kG9kqnFHyVANEeS+h woIVQSwtd85lDOyRr4TvR+9NRIVzVO94FUiU+RxTpfXWdenDLW6kCXnerIR7w7HaUe mPDdYRBjjAIj43Fxn47xKpeWORAGq1nADM1QgpCIoTNtfO0dvrdWLNqDF+UZQFzoH7 5RRo/3iQePanvEwK7Q2yg0N4Jk1MLg7WAyRNAIPwQqX7UxX54s5I+BNRzNX972IfTJ +9kz702u0xu1g== Message-ID: <1c7b8b85-7b50-0832-24e8-174100f5a6f5@benettiengineering.com> Date: Mon, 21 Feb 2022 10:07:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Yu Chien Peter Lin References: <20220215053327.4046-1-peterlin@andestech.com> From: Giulio Benetti In-Reply-To: X-CMAE-Envelope: MS4wfHrv2nQQMNPeSOZ+b4Qla3mPbtYmaYes//CcpXbc0fbjlXvH0uZuE8BTg1TqYNVipJZxYH3fqhyNN270DC3RT0Gr4epxOfduqEzyaCZ9Q+FASyNl1OLk yr4ZOLcDZ0Vm+Cxgo4RDLysra7nXT7w4pYxAIsCJh2UM2jYxaoA4cU13vD++FXjw6Jvq53w7J4tTmJlOtAQTyFj5y4vmT6hRXGii+2vRwKnQMUGegZgs9VCr opcPHFFYAkBWn/SWaKqEs6hhdNfXLmrszQPjs2zXmzc= Subject: Re: [Buildroot] [PATCH v3 1/3] board/andes: rearrange nds32 folder structure X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alankao@andestech.com, buildroot@buildroot.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hi Peter, Alan, On 21/02/22 04:37, Yu Chien Peter Lin wrote: > Hi Giulio, > > On Thu, Feb 17, 2022 at 04:55:49PM +0100, Giulio Benetti wrote: >> Hi Peter, >> >> On 15/02/22 06:33, Yu Chien Peter Lin wrote: >>> Rearrange nds32 folder structure to add AE350 platform. >>> >>> Signed-off-by: Yu Chien Peter Lin >>> Signed-off-by: Alan Kao >>> --- >>> .../patches/linux/0001-nds32-Fix-boot-messages-garbled.patch | 0 >>> ...2-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch | 0 >>> board/andes/{ => ae3xx}/readme.txt | 0 >>> configs/andes_ae3xx_defconfig | 2 +- >>> 4 files changed, 1 insertion(+), 1 deletion(-) >>> rename board/andes/{ => ae3xx}/patches/linux/0001-nds32-Fix-boot-messages-garbled.patch (100%) >>> rename board/andes/{ => ae3xx}/patches/linux/0002-scripts-dtc-Remove-redundant-YYLOC-global-declaratio.patch (100%) >>> rename board/andes/{ => ae3xx}/readme.txt (100%) >> >> Here we have both: >> board/andes/ae3xx >> and >> board/andes/ae350 >> >> ae3xx should be use for every ae3xx family(ae350 included), but for ae350 >> you use a specific folder. >> What I see digging into ae3xx is that it is for FPGA demonstration, so I >> would move ae3xx directory to be name as ae3xx-fpga. Otherwise I would >> expect ae350(and newer parts) to be part of ae3xx. >> >> Same goes for the defconfig, I would name it like: >> andes_ae3xx_fpga_defconfig >> >> This way we can divide the 2 typologies: >> - fpga demonostration for ae3xx >> - ae3xx SoC family >> >> Otherwise you should provide a single family folder(ae3xx) compatible for >> both fpgas and SoCs. >> >> Thank you >> >> Best regards >> -- >> Giulio Benetti >> Benetti Engineering sas > > For this naming issue, we decide to make ae3xx > explicit to have these two platform residing > in its own folder. So it would be: > > board/andes/ > |- {ae3xx => ae300}/ > `- ae350/ > > If this make sense to you, I will submit PATCH v4. It works for me. I've checked your website and I see: http://www.andestech.com/en/products-solutions/andeshape-platforms/ where you have: AE300: http://www.andestech.com/en/products-solutions/andeshape-platforms/ae300/ and AE350: http://www.andestech.com/en/products-solutions/andeshape-platforms/ae350-axi-based-platform-pre-integrated-with-n25f-nx25f-a25-ax25/ so your solution fits perfectly since they are two very distinct platforms. So yes please send V4 with that change. Thank you! Best regards -- Giulio Benetti Benetti Engineering sas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot