From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751869AbdJTBtX (ORCPT ); Thu, 19 Oct 2017 21:49:23 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:39081 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645AbdJTBtW (ORCPT ); Thu, 19 Oct 2017 21:49:22 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <2389f5628bd6fc33a5fa5dee3ba1c1d1> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register() To: Jeffy Chen , linux-kernel@vger.kernel.org Cc: briannorris@chromium.org, seanpaul@chromium.org, dianders@chromium.org, heiko@sntech.de, tfiga@chromium.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, David Airlie , linux-arm-kernel@lists.infradead.org References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <20171019034812.13768-6-jeffy.chen@rock-chips.com> From: Mark yao Message-ID: <1c7f4eaf-6fa2-58e1-a216-46ac039fffd5@rock-chips.com> Date: Fri, 20 Oct 2017 09:49:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171019034812.13768-6-jeffy.chen@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年10月19日 11:48, Jeffy Chen wrote: > The rockchip_drm_psr_register() can fail, so add a sanity check for that. > > Also reorder the calls in unbind() to match bind(). > > Signed-off-by: Jeffy Chen Looks good for me Acked-by: Mark Yao Mark From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register() Date: Fri, 20 Oct 2017 09:49:23 +0800 Message-ID: <1c7f4eaf-6fa2-58e1-a216-46ac039fffd5@rock-chips.com> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <20171019034812.13768-6-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171019034812.13768-6-jeffy.chen@rock-chips.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jeffy Chen , linux-kernel@vger.kernel.org Cc: briannorris@chromium.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxN+W5tDEw5pyIMTnml6UgMTE6NDgsIEplZmZ5IENoZW4gd3JvdGU6Cj4gVGhlIHJvY2tj aGlwX2RybV9wc3JfcmVnaXN0ZXIoKSBjYW4gZmFpbCwgc28gYWRkIGEgc2FuaXR5IGNoZWNrIGZv ciB0aGF0Lgo+Cj4gQWxzbyByZW9yZGVyIHRoZSBjYWxscyBpbiB1bmJpbmQoKSB0byBtYXRjaCBi aW5kKCkuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKZWZmeSBDaGVuPGplZmZ5LmNoZW5Acm9jay1jaGlw cy5jb20+CgpMb29rcyBnb29kIGZvciBtZQpBY2tlZC1ieTogTWFyayBZYW8gPG1hcmsueWFvQHJv Y2stY2hpcHMuY29tPgoKTWFyawoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 20 Oct 2017 09:49:23 +0800 Subject: [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register() In-Reply-To: <20171019034812.13768-6-jeffy.chen@rock-chips.com> References: <20171019034812.13768-1-jeffy.chen@rock-chips.com> <20171019034812.13768-6-jeffy.chen@rock-chips.com> Message-ID: <1c7f4eaf-6fa2-58e1-a216-46ac039fffd5@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2017?10?19? 11:48, Jeffy Chen wrote: > The rockchip_drm_psr_register() can fail, so add a sanity check for that. > > Also reorder the calls in unbind() to match bind(). > > Signed-off-by: Jeffy Chen Looks good for me Acked-by: Mark Yao Mark