From: Martin Wilck <Martin.Wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>,
"christophe.varoqui@opensvc.com" <christophe.varoqui@opensvc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH 1/3] libmultipath: assign variable to make gcc happy
Date: Wed, 25 Mar 2020 15:22:08 +0000 [thread overview]
Message-ID: <1c843854bf71e0ddbf8f4b81e33276c05504e0cc.camel@suse.com> (raw)
In-Reply-To: <1585083834-14237-1-git-send-email-bmarzins@redhat.com>
On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote:
> There is nothing wrong with is_queueing not being set at the start
> of __set_no_path_retry(), it will always get set before it is
> accessed,
> but gcc 8.2.1 is failing with
>
> structs_vec.c: In function ‘__set_no_path_retry’:
> structs_vec.c:339:7: error: ‘is_queueing’ may be used uninitialized
> in
> this function [-Werror=maybe-uninitialized]
> bool is_queueing;
> ^~~~~~~~~~~
>
> so, assign a value to make it happy.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/structs_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
That actually looks like a gcc bug to me. Anyway:
Reviewed-by: Martin Wilck <mwilck@suse.de>
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Software Solutions Germany GmbH
HRB 36809, AG Nürnberg GF: Felix
Imendörffer
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2020-03-25 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:03 [PATCH 1/3] libmultipath: assign variable to make gcc happy Benjamin Marzinski
2020-03-24 21:03 ` [PATCH 2/3] libmutipath: don't close fd on dm_lib_release Benjamin Marzinski
2020-03-25 15:16 ` Martin Wilck
2020-03-25 20:52 ` Benjamin Marzinski
2020-03-25 22:00 ` Benjamin Marzinski
2020-03-25 22:11 ` Martin Wilck
2020-07-02 11:52 ` Martin Wilck
2020-07-02 20:06 ` Benjamin Marzinski
2020-07-03 14:05 ` Martin Wilck
2020-03-24 21:03 ` [PATCH 3/3] libmultipath: allow force reload with no active paths Benjamin Marzinski
2020-03-25 15:27 ` Martin Wilck
2020-03-25 15:22 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c843854bf71e0ddbf8f4b81e33276c05504e0cc.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.