From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A92C433ED for ; Mon, 17 May 2021 08:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B61861185 for ; Mon, 17 May 2021 08:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233316AbhEQIIa (ORCPT ); Mon, 17 May 2021 04:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbhEQII3 (ORCPT ); Mon, 17 May 2021 04:08:29 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B551C061573 for ; Mon, 17 May 2021 01:07:13 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id h4so7517335lfv.0 for ; Mon, 17 May 2021 01:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PsWxchSj6IsfblxIjcdWW7ZX83ze5SRG4vA70cLrM7A=; b=fk7lEsgVhMM8fOmwyUfed66RSTd8ey3C8TrJYxrYuVdaJCaxGJpgFmswJvDOyJ2kA2 2COMzLfb9TrxQc4G2WItTgb/jKu7DfkMaUlHaBEmtlr43KuMCzYJ/5ubVWZW9jjc5h8r RymapGTPQLOeIFURsfPiJ0ji+P6njJCBpMJo79Nvmkcb4L+nb8YmqTsH+0uQj8yA6mrS efsv8tPZNMaF2xIW6pmfY7AzXlulWce2I+CR/F7uNsZvxNKJw7Ldbw4A/LDOE3sUYtlv /w9QnUDplcUQokTFyNHhWWsoju9/RSNh2EKnTnbjJC4weixNYSQn00oDfTejeJ56/g6V 1YEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PsWxchSj6IsfblxIjcdWW7ZX83ze5SRG4vA70cLrM7A=; b=dtMSGHMd8bwQRYlXAtixOgd0u+dMMrwtmU7SVKM686l1SpR0zT7DCf6PSVb44AIR+j HMS5bs9dzMfvpmN7l7SwRR5hqGaRodpJCNEqjS/7+xz5xH2CSmS8DA6ZORN6siMvPJbm GgZMoztvR1xOlyOxGM2TlhvunrwhWi2oH/PXDtDesE8PdoV/zLsZQ6SrbohN581OMt2a k2QhcgmDKU1dMH5cC2p7nQOTX20S+OmzPJIxfthVFjaitngS19QKFkxKZ552J8bELMLv q1RJSYbSjSYYfr5bTKl2OtEfaHAxLjcLrYV8RgzSZiqK61Ff5x/LkYalv2xbYvwI07sc 7L0Q== X-Gm-Message-State: AOAM532E/sUC2NnBdfVRV4UIY9fF87fjVVGSLIijIWvjnGIJuICnZqbU VE4EuYdgKQfW0fq3qjf4kckJD73xI1A/4AkX X-Google-Smtp-Source: ABdhPJw1SjBEjNJNPkIQKq/gztKPKO5hpbNaaCpp2o7nB24mtW8/2D/Ia7pjqpFncXqQH3yiuumtxA== X-Received: by 2002:a19:c511:: with SMTP id w17mr10749915lfe.113.1621238831207; Mon, 17 May 2021 01:07:11 -0700 (PDT) Received: from [10.0.0.40] (91-155-111-71.elisa-laajakaista.fi. [91.155.111.71]) by smtp.gmail.com with ESMTPSA id z18sm1902645lfd.180.2021.05.17.01.07.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 01:07:10 -0700 (PDT) To: "Mukunda,Vijendar" , Mark Brown Cc: alsa-devel@alsa-project.org, amistry@google.com, nartemiev@google.com, Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Ranjani Sridharan , Kuninori Morimoto , open list References: <1619195089-29710-1-git-send-email-Vijendar.Mukunda@amd.com> <20210423164617.GG5507@sirena.org.uk> <070b4e5b-b7bd-b8a6-beea-593a94ec3078@gmail.com> <26c79eec-5e74-38bc-465b-0ca2b2d9a6f5@amd.com> <9b689495-e956-6242-0784-af3ccf7c3238@amd.com> From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= Subject: Re: [PATCH 1/2] ASoC: dwc: add a quirk DW_I2S_QUIRK_STOP_ON_SHUTDOWN to dwc driver Message-ID: <1c875eae-88f2-5bc7-849b-f1c4afb29dbe@gmail.com> Date: Mon, 17 May 2021 11:07:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <9b689495-e956-6242-0784-af3ccf7c3238@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2021 20:27, Mukunda,Vijendar wrote: >> Hardware signal broken between ACP and Designware I2S controller with >> re-ordering the sequence. >>   > It is surely not a designware IP issue, trying to solve it there >> is wrong. >>> >> As it's not a designware IP issue, initially we started idea with >> introducing quirk that applies for this ACP version based AMD platforms. >> > > Hi Peter, > > Any suggestion on the work around for this issue? > How about declaring a flag in sound card structure and this flag will be > set in stoneyridge machine driver. This can only be solved in the core, that's clear. If this issue only affects this version of ACP with dw I2S (the same ACP version works fine with other audio IP), then it is more like machine driver level of quirk. If this ACP have the same issue with other audio IPs as well then it is platform quirk. If the this ACP is only used in this setup then I would consider machine level quirk as it might be simpler to implement. Other thing to consider is how other setups with similar issues can use the new quirk/flag... Some might need to make sure that a component is first, not last for example. > Based on flag check trigger stop sequence will be re-ordered. > > Thanks, > Vijendar -- Péter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08BACC433ED for ; Mon, 17 May 2021 08:08:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B4E6611ED for ; Mon, 17 May 2021 08:08:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B4E6611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 469971660; Mon, 17 May 2021 10:07:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 469971660 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621238909; bh=Rj0L/FnUEtP1IP5LeiYanzKByRtgvd0iZLL9bhNAOds=; h=To:References:From:Subject:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WB+H1Az8DowUyyc1pNth+k6oBRkqD2vujnn8m/uIYjpjtaiIpDi0w3L95SUKUhJp3 2TlsoCC3y8LXr/Y3kMMoW+m8jsHxT6IbKNE6Yh02Z+nhmDt8NxQ0BKtfmSUd+qXo9q gT5SofEzJjPT6xz/Ebmnk9kva81KRjH/bHqFLwzo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C8F07F8016E; Mon, 17 May 2021 10:07:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EA580F8020B; Mon, 17 May 2021 10:07:20 +0200 (CEST) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 79057F80082 for ; Mon, 17 May 2021 10:07:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 79057F80082 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fk7lEsgV" Received: by mail-lf1-x129.google.com with SMTP id q7so6111159lfr.6 for ; Mon, 17 May 2021 01:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PsWxchSj6IsfblxIjcdWW7ZX83ze5SRG4vA70cLrM7A=; b=fk7lEsgVhMM8fOmwyUfed66RSTd8ey3C8TrJYxrYuVdaJCaxGJpgFmswJvDOyJ2kA2 2COMzLfb9TrxQc4G2WItTgb/jKu7DfkMaUlHaBEmtlr43KuMCzYJ/5ubVWZW9jjc5h8r RymapGTPQLOeIFURsfPiJ0ji+P6njJCBpMJo79Nvmkcb4L+nb8YmqTsH+0uQj8yA6mrS efsv8tPZNMaF2xIW6pmfY7AzXlulWce2I+CR/F7uNsZvxNKJw7Ldbw4A/LDOE3sUYtlv /w9QnUDplcUQokTFyNHhWWsoju9/RSNh2EKnTnbjJC4weixNYSQn00oDfTejeJ56/g6V 1YEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PsWxchSj6IsfblxIjcdWW7ZX83ze5SRG4vA70cLrM7A=; b=YvQTVN+r8gcPZXJeP4Llh2wX9CYdm9x+dTKh6Ypgcz7i0bJWd6ygMkB8Q433icYuvj Xk92BeoozhuZQoon0/FV0KQCHSfUX2VM3CIy87tdl0SP7TCddll6HUYCuJMLo+HNqj0G ev9iscgCGa1prg1iEfCmUdVRAbnA2wnecz2Z0gzD5gK+uTC8ETlRFc89LQoRJytnQx1a tMnsUjzah3aRxYJRIMTGJiwyBfJ8qjnSvIvXWSgbl/1TPNAK5Q4eGlycuWp96u8ODF5y Zv9+k5gum1JfA0HdPar4HFax6ho7szMl5gwP33blT0YP8Ruu850APMIAO5mYjd5B18uA CV0A== X-Gm-Message-State: AOAM53205lBAs0Kn+ymD0CnaUZN56FRLMZNzGoDtZSk5b/3W/IHEmFGm AQk9bTkYGczk3hVxXlVSokg= X-Google-Smtp-Source: ABdhPJw1SjBEjNJNPkIQKq/gztKPKO5hpbNaaCpp2o7nB24mtW8/2D/Ia7pjqpFncXqQH3yiuumtxA== X-Received: by 2002:a19:c511:: with SMTP id w17mr10749915lfe.113.1621238831207; Mon, 17 May 2021 01:07:11 -0700 (PDT) Received: from [10.0.0.40] (91-155-111-71.elisa-laajakaista.fi. [91.155.111.71]) by smtp.gmail.com with ESMTPSA id z18sm1902645lfd.180.2021.05.17.01.07.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 01:07:10 -0700 (PDT) To: "Mukunda,Vijendar" , Mark Brown References: <1619195089-29710-1-git-send-email-Vijendar.Mukunda@amd.com> <20210423164617.GG5507@sirena.org.uk> <070b4e5b-b7bd-b8a6-beea-593a94ec3078@gmail.com> <26c79eec-5e74-38bc-465b-0ca2b2d9a6f5@amd.com> <9b689495-e956-6242-0784-af3ccf7c3238@amd.com> From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= Subject: Re: [PATCH 1/2] ASoC: dwc: add a quirk DW_I2S_QUIRK_STOP_ON_SHUTDOWN to dwc driver Message-ID: <1c875eae-88f2-5bc7-849b-f1c4afb29dbe@gmail.com> Date: Mon, 17 May 2021 11:07:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <9b689495-e956-6242-0784-af3ccf7c3238@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com, amistry@google.com, Kuninori Morimoto , Liam Girdwood , open list , Basavaraj.Hiregoudar@amd.com, Takashi Iwai , Ranjani Sridharan , Alexander.Deucher@amd.com, nartemiev@google.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/05/2021 20:27, Mukunda,Vijendar wrote: >> Hardware signal broken between ACP and Designware I2S controller with >> re-ordering the sequence. >>   > It is surely not a designware IP issue, trying to solve it there >> is wrong. >>> >> As it's not a designware IP issue, initially we started idea with >> introducing quirk that applies for this ACP version based AMD platforms. >> > > Hi Peter, > > Any suggestion on the work around for this issue? > How about declaring a flag in sound card structure and this flag will be > set in stoneyridge machine driver. This can only be solved in the core, that's clear. If this issue only affects this version of ACP with dw I2S (the same ACP version works fine with other audio IP), then it is more like machine driver level of quirk. If this ACP have the same issue with other audio IPs as well then it is platform quirk. If the this ACP is only used in this setup then I would consider machine level quirk as it might be simpler to implement. Other thing to consider is how other setups with similar issues can use the new quirk/flag... Some might need to make sure that a component is first, not last for example. > Based on flag check trigger stop sequence will be re-ordered. > > Thanks, > Vijendar -- Péter