From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Tue, 28 Apr 2020 16:43:38 +0000 Subject: Re: [PATCH 08/11] target: add sysfs session helper functions Message-Id: <1c97ee38-7a0e-5aac-6065-41267baea648@acm.org> List-Id: References: <20200428061109.3042-1-mchristi@redhat.com> <20200428061109.3042-9-mchristi@redhat.com> In-Reply-To: <20200428061109.3042-9-mchristi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Christie , bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org On 2020-04-27 23:11, Mike Christie wrote: > + ret = kobject_add(&se_sess->kobj, se_tpg->sessions_kobj, "session-%d", > + se_sess->sid); > + if (ret) { > + pr_err("Could not add session%d to sysfs. Error %d.\n", > + se_sess->sid, ret); > + goto free_acl_name; > + } Has it been considered to derive the directory name for a session from the initiator name (se_node_acl.initiatorname-%d)? Would that be more convenient for users than the session-%d naming scheme? Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41350C83000 for ; Tue, 28 Apr 2020 16:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24700208E0 for ; Tue, 28 Apr 2020 16:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728291AbgD1Qnl (ORCPT ); Tue, 28 Apr 2020 12:43:41 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:43986 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbgD1Qnl (ORCPT ); Tue, 28 Apr 2020 12:43:41 -0400 Received: by mail-pg1-f194.google.com with SMTP id x26so10597269pgc.10; Tue, 28 Apr 2020 09:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6VJupdaTXWQyhc1wV3O2tpzdLqkcolUwWGrYprUpasM=; b=svk3oMzpanJc29xBjWEe+yiS4W1EtgWjZmMlfJbJTJn5cYgfrP/tGmE/LboAeZMhBZ xGs2726DRmmxL8J7Us4FpB/Fm+Ye4ITN+dvx65V6Ccb8Bfb1QRBPG8oWaudYq8rEAhg5 we7rmEG6KXDLDuIja6jGf8xJSe7iBElccTEHJqqLd9GRS5HCjJSFADusi5M7yETQyeHs UUAyAEWKjPBijC3fMf367zFAF2s7xA7Zde1htAzB+YnLeKOKZYlbdkseq1zBLWDWIPjb Ci4sZ+YdyBARKOUpJ6qyqCF92YeHXcf2KDbj4RKO57rQ98y6TEpQro+9PrJ8TWNyGwm+ /Suw== X-Gm-Message-State: AGi0PubknKoHsvIXPKBW65XW3gU8IBXiVouKMkDvDUGSIX1xStvs9L2c ol+wNz0umz4OkTdE1ncicQPetwGEUMxlWg== X-Google-Smtp-Source: APiQypKiTCNW3xZUjROBP59gGx70ri0atrmf6iHBuRbcYmp/wBB86D94qSMSys5rAe6mnaGfX5I8Bg== X-Received: by 2002:a63:4650:: with SMTP id v16mr25261620pgk.99.1588092219950; Tue, 28 Apr 2020 09:43:39 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:1473:9ec8:73db:e572? ([2601:647:4000:d7:1473:9ec8:73db:e572]) by smtp.gmail.com with ESMTPSA id k63sm1000004pge.42.2020.04.28.09.43.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2020 09:43:39 -0700 (PDT) Subject: Re: [PATCH 08/11] target: add sysfs session helper functions To: Mike Christie , bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org References: <20200428061109.3042-1-mchristi@redhat.com> <20200428061109.3042-9-mchristi@redhat.com> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <1c97ee38-7a0e-5aac-6065-41267baea648@acm.org> Date: Tue, 28 Apr 2020 09:43:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200428061109.3042-9-mchristi@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2020-04-27 23:11, Mike Christie wrote: > + ret = kobject_add(&se_sess->kobj, se_tpg->sessions_kobj, "session-%d", > + se_sess->sid); > + if (ret) { > + pr_err("Could not add session%d to sysfs. Error %d.\n", > + se_sess->sid, ret); > + goto free_acl_name; > + } Has it been considered to derive the directory name for a session from the initiator name (se_node_acl.initiatorname-%d)? Would that be more convenient for users than the session-%d naming scheme? Thanks, Bart.