From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C799C433E0 for ; Mon, 21 Dec 2020 23:01:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB50F22B51 for ; Mon, 21 Dec 2020 23:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbgLUXBE (ORCPT ); Mon, 21 Dec 2020 18:01:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgLUXBD (ORCPT ); Mon, 21 Dec 2020 18:01:03 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54D1FC0613D3; Mon, 21 Dec 2020 15:00:23 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id c79so7330337pfc.2; Mon, 21 Dec 2020 15:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=65pt/EpKbKnqnWANzNSM/MF57uxSvX6gWSCDRynSRlA=; b=WxVL33ES70LsqsN4AA7yZyhE4dkhaHXl0+g0SzjRmv9x+dL0ILzQvdo98UOj9nza25 yexpKtG20dvF9QFUzqcQizmaJfzf0UeeCmfxMAkUpd2nigbOfCVRmm3XlwwsVtTfoLuR hQtpFslAupUCpq3xS/xZ/TR22ziNYnm+Ak61SyCYShWIIr49j4VegVhb+DKHv4RKUDpJ et+OCoAb2IojFp/3Xfd875wM8XWYAe9mLNgcteweCiGtnUpDs04UH5h71BAHQ7JbKJ+o Hqi93kB37kJ05K+0Nr59fO5UiFnz6k+bnf3+vzEp44ySkaxWUdOGr46e7yXIfhArvk34 tqVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=65pt/EpKbKnqnWANzNSM/MF57uxSvX6gWSCDRynSRlA=; b=jNYQ1IaA3URYqNiXOFTMRAPyJ8/5hz/XorGBVI5BHu3tvWeiJdrXMnz5RYyttL9c+0 q0tRf7mK5OmJb1iIIWOZBgjEjTC6eX1zfXwvATPBKmLkFr4JcYBe6k8ZTVlChie5ldSl qjSvZKae1KIsHjHhQNZ0A1r9B+r14BD8z+cglUNiBqcTRG4X/66V9iVp2/3stOhoV4IW 8i+g6on0rrmtgOcPkRg62ghakJKBg0oCoBcOvdOccuuIXfaVbVZCblvmACzAPNLNMrmo TasVgT7I64mFGjV9scwIzssDH+hXCJNmznvW0iQ4paquFFwYGMlgRZt/7C4Pos60/NmH Mw7Q== X-Gm-Message-State: AOAM530PMpwdB5zEgIyZfDMAT6E9J0qjeRH43ZeXY+1WNBBpWwiSAwNV 8kHu80033DD/V9Sn+I9c/WcoiXCpI0g= X-Google-Smtp-Source: ABdhPJx4blbyV+GNHUeZersi/78OT573VQmpJDni0rEUoDkBlL919baDrYt5gH3bDZC00CzA1gYIjA== X-Received: by 2002:a63:5460:: with SMTP id e32mr17254953pgm.59.1608591622405; Mon, 21 Dec 2020 15:00:22 -0800 (PST) Received: from [10.230.29.166] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id gm18sm16675885pjb.55.2020.12.21.15.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Dec 2020 15:00:21 -0800 (PST) Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the probe function To: Christophe JAILLET , mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, f.fainelli@gmail.com Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> From: Florian Fainelli Message-ID: <1cba966a-2485-3333-40fd-26ffa1c3d78f@gmail.com> Date: Mon, 21 Dec 2020 15:00:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/19/2020 2:17 AM, Christophe JAILLET wrote: > If 'cpufreq_register_driver()' fails, we must release the resources > allocated in 'brcm_avs_prepare_init()' as already done in the remove > function. > > To do that, introduce a new function 'brcm_avs_prepare_uninit()' in order > to avoid code duplication. This also makes the code more readable (IMHO). > > Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs") > Signed-off-by: Christophe JAILLET Acked-by: Florian Fainelli We could have considered switching to device managed APIs for automatic cleanup, but this will do as well. Thanks Christophe. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Date: Mon, 21 Dec 2020 23:00:19 +0000 Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the Message-Id: <1cba966a-2485-3333-40fd-26ffa1c3d78f@gmail.com> List-Id: References: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET , mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, f.fainelli@gmail.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org On 12/19/2020 2:17 AM, Christophe JAILLET wrote: > If 'cpufreq_register_driver()' fails, we must release the resources > allocated in 'brcm_avs_prepare_init()' as already done in the remove > function. > > To do that, introduce a new function 'brcm_avs_prepare_uninit()' in order > to avoid code duplication. This also makes the code more readable (IMHO). > > Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs") > Signed-off-by: Christophe JAILLET Acked-by: Florian Fainelli We could have considered switching to device managed APIs for automatic cleanup, but this will do as well. Thanks Christophe. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2587AC433E0 for ; Mon, 21 Dec 2020 23:01:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3A05229CA for ; Mon, 21 Dec 2020 23:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3A05229CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n1NZfUPbB2YotIbwAgnogeryjPtHncHAE7tVCB3TjLQ=; b=n7QatJ4VvSVGt8DpN+AnoN2SW YhHr9DwEhbXRcDLguFlpX7+A4bFbSp/IZniEjbtakb9qf/wmudYMgnoPMMpXS5yM1A22AaIIOGUT1 GVuFdA+lKNtyN+z2Fkd+a/3B95JVL3XUe9SIQ/E6TfEEB6bxv0BQ2haLKbdKXVXvdOWO6i+sbgJ3B q9kqXCAPD3YsRoZ5k7xQ8HqB/DzpEUz5wcnuV2RY1qZ4w2ifPwLr1DiZEdR0gV86FmMku1t9d+HEh eKb97VE/7KVJ0UxwZqEKUa8q+KJGC0vWq/xHXp84FylmMD7f9iulgC4ZHrvD9tmdq35XfwEuFoEoc TmS5wi2VQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krUAE-0002Fv-KV; Mon, 21 Dec 2020 23:00:26 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krUAC-0002FT-Od for linux-arm-kernel@lists.infradead.org; Mon, 21 Dec 2020 23:00:25 +0000 Received: by mail-pg1-x535.google.com with SMTP id w5so7211451pgj.3 for ; Mon, 21 Dec 2020 15:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=65pt/EpKbKnqnWANzNSM/MF57uxSvX6gWSCDRynSRlA=; b=WxVL33ES70LsqsN4AA7yZyhE4dkhaHXl0+g0SzjRmv9x+dL0ILzQvdo98UOj9nza25 yexpKtG20dvF9QFUzqcQizmaJfzf0UeeCmfxMAkUpd2nigbOfCVRmm3XlwwsVtTfoLuR hQtpFslAupUCpq3xS/xZ/TR22ziNYnm+Ak61SyCYShWIIr49j4VegVhb+DKHv4RKUDpJ et+OCoAb2IojFp/3Xfd875wM8XWYAe9mLNgcteweCiGtnUpDs04UH5h71BAHQ7JbKJ+o Hqi93kB37kJ05K+0Nr59fO5UiFnz6k+bnf3+vzEp44ySkaxWUdOGr46e7yXIfhArvk34 tqVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=65pt/EpKbKnqnWANzNSM/MF57uxSvX6gWSCDRynSRlA=; b=QnnR5NLOu36uS8Hk4ozJVMc6G3W2BoVUx40jbuGDE4edmjY/pBOZVPDxsVPwApwugR kVileIcGpYD1ODvR/OwTIRrQ990j0pt7KBwi0xNQRQ53uaa7ZMbwSvv0/IpsS5rjyrt8 7dKozEusGNVTB6iTv4/GdrxRTP6u0I40BKBNM4fL8H8yUU222UMRzkmED9g0oag/bs5m 2e6pqbOeoAAcBVb9Huh+ppAEHXBzinUuDAtxLLE9vKVyYwhw0KIOKxF+v+rTtxsfFd43 XHHLxVlLC+x0bSCFM+DR/v+9cn+6EX6FpC8rR86npiGDTyVHUCamSe0ENKO7C6OjYRjj EyRQ== X-Gm-Message-State: AOAM532rukhtlbNEGmH47IBL0tAYfIOvNxbQnEnk8QE9RnVPh7nUNt8B 4LmcXgmDQ4cFVCck/HlUFbM= X-Google-Smtp-Source: ABdhPJx4blbyV+GNHUeZersi/78OT573VQmpJDni0rEUoDkBlL919baDrYt5gH3bDZC00CzA1gYIjA== X-Received: by 2002:a63:5460:: with SMTP id e32mr17254953pgm.59.1608591622405; Mon, 21 Dec 2020 15:00:22 -0800 (PST) Received: from [10.230.29.166] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id gm18sm16675885pjb.55.2020.12.21.15.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Dec 2020 15:00:21 -0800 (PST) Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the probe function To: Christophe JAILLET , mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, f.fainelli@gmail.com References: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> From: Florian Fainelli Message-ID: <1cba966a-2485-3333-40fd-26ffa1c3d78f@gmail.com> Date: Mon, 21 Dec 2020 15:00:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_180024_851660_83A983DE X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/19/2020 2:17 AM, Christophe JAILLET wrote: > If 'cpufreq_register_driver()' fails, we must release the resources > allocated in 'brcm_avs_prepare_init()' as already done in the remove > function. > > To do that, introduce a new function 'brcm_avs_prepare_uninit()' in order > to avoid code duplication. This also makes the code more readable (IMHO). > > Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs") > Signed-off-by: Christophe JAILLET Acked-by: Florian Fainelli We could have considered switching to device managed APIs for automatic cleanup, but this will do as well. Thanks Christophe. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel