All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, "Leo Yan" <leoy@marvell.com>,
	"Zhangfei Gao" <zhangfei.gao@marvell.com>,
	"Lubomir Rintel" <lkundrak@v3.sk>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Kees Cook" <keescook@chromium.org>,
	"Tony Luck" <tony.luck@intel.com>,
	"Guilherme G . Piccoli" <gpiccoli@igalia.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Karel Balej <balejk@matfyz.cz>
Subject: Re: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform
Date: Fri, 3 Nov 2023 17:51:39 +0000	[thread overview]
Message-ID: <1cbc6def-8255-4a13-99b0-145d3f8ffcac@arm.com> (raw)
In-Reply-To: <2919185.e9J7NaK4W3@radijator>

On 2023-11-03 5:02 pm, Duje Mihanović wrote:
> On Friday, November 3, 2023 4:34:54 PM CET Robin Murphy wrote:
>> On 2023-11-02 3:20 pm, Duje Mihanović wrote:
>>> +config ARCH_MMP
>>> +	bool "Marvell MMP SoC Family"
>>> +	select ARM_GIC
>>> +	select ARM_ARCH_TIMER
>>> +	select ARM_SMMU
>>
>> NAK, not only is selecting user-visible symbols generally frowned upon,
>> and ignoring their dependencies even worse, but for a multiplatform
>> kernel the user may well want this to be a module.
>>
>> If having the SMMU driver built-in is somehow fundamentally required for
>> this platform to boot, that would represent much bigger problems.
> 
> The SoC can boot without SMMU and PDMA, but not GIC, pinctrl or the arch
> timer. I see that most other SoCs still select drivers and frameworks they
> presumably need for booting, with the exceptions of ARCH_BITMAIN, ARCH_LG1K
> and a couple others. Which of these two options should I go for?

Well, you don't really need to select ARM_GIC or ARM_ARCH_TIMER here 
either, since those are already selected by ARM64 itself. Keeping 
PINCTRL_SINGLE is fair, although you should also select PINCTRL as its 
dependency.

As an additional nit, the file seems to be primarily ordered by symbol 
name, so it might be nice to slip ARCH_MMC in between ARCH_MESON and 
ARCH_MVEBU.

Cheers,
Robin.

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Tony Lindgren" <tony@atomide.com>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, "Leo Yan" <leoy@marvell.com>,
	"Zhangfei Gao" <zhangfei.gao@marvell.com>,
	"Lubomir Rintel" <lkundrak@v3.sk>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	"Kees Cook" <keescook@chromium.org>,
	"Tony Luck" <tony.luck@intel.com>,
	"Guilherme G . Piccoli" <gpiccoli@igalia.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Karel Balej <balejk@matfyz.cz>
Subject: Re: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform
Date: Fri, 3 Nov 2023 17:51:39 +0000	[thread overview]
Message-ID: <1cbc6def-8255-4a13-99b0-145d3f8ffcac@arm.com> (raw)
In-Reply-To: <2919185.e9J7NaK4W3@radijator>

On 2023-11-03 5:02 pm, Duje Mihanović wrote:
> On Friday, November 3, 2023 4:34:54 PM CET Robin Murphy wrote:
>> On 2023-11-02 3:20 pm, Duje Mihanović wrote:
>>> +config ARCH_MMP
>>> +	bool "Marvell MMP SoC Family"
>>> +	select ARM_GIC
>>> +	select ARM_ARCH_TIMER
>>> +	select ARM_SMMU
>>
>> NAK, not only is selecting user-visible symbols generally frowned upon,
>> and ignoring their dependencies even worse, but for a multiplatform
>> kernel the user may well want this to be a module.
>>
>> If having the SMMU driver built-in is somehow fundamentally required for
>> this platform to boot, that would represent much bigger problems.
> 
> The SoC can boot without SMMU and PDMA, but not GIC, pinctrl or the arch
> timer. I see that most other SoCs still select drivers and frameworks they
> presumably need for booting, with the exceptions of ARCH_BITMAIN, ARCH_LG1K
> and a couple others. Which of these two options should I go for?

Well, you don't really need to select ARM_GIC or ARM_ARCH_TIMER here 
either, since those are already selected by ARM64 itself. Keeping 
PINCTRL_SINGLE is fair, although you should also select PINCTRL as its 
dependency.

As an additional nit, the file seems to be primarily ordered by symbol 
name, so it might be nice to slip ARCH_MMC in between ARCH_MESON and 
ARCH_MVEBU.

Cheers,
Robin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-11-03 17:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 15:20 [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64 Duje Mihanović
2023-11-02 15:20 ` Duje Mihanović
2023-11-02 15:20 ` [PATCH v7 07/10] dt-bindings: marvell: Document PXA1908 SoC Duje Mihanović
2023-11-02 15:20   ` Duje Mihanović
2023-11-02 15:20 ` [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Duje Mihanović
2023-11-02 15:20   ` Duje Mihanović
2023-11-03 15:34   ` Robin Murphy
2023-11-03 15:34     ` Robin Murphy
2023-11-03 17:02     ` Duje Mihanović
2023-11-03 17:02       ` Duje Mihanović
2023-11-03 17:51       ` Robin Murphy [this message]
2023-11-03 17:51         ` Robin Murphy
2023-11-02 15:20 ` [PATCH v7 09/10] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte Duje Mihanović
2023-11-02 15:20   ` Duje Mihanović
2023-11-02 15:20 ` [PATCH v7 10/10] MAINTAINERS: add myself as Marvell PXA1908 maintainer Duje Mihanović
2023-11-02 15:20   ` Duje Mihanović
2023-11-02 15:26 ` [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64 Mark Brown
2023-11-02 15:26   ` Mark Brown
2023-11-03 15:23   ` Robin Murphy
2023-11-03 15:23     ` Robin Murphy
2023-11-03 16:58     ` Duje Mihanović
2023-11-03 16:58       ` Duje Mihanović
2023-11-06 10:58       ` Mark Brown
2023-11-06 10:58         ` Mark Brown
2023-11-10 19:28         ` Duje Mihanović
2023-11-10 19:28           ` Duje Mihanović
2023-11-11 11:39           ` Mark Brown
2023-11-11 11:39             ` Mark Brown
2023-11-11 21:01             ` Duje Mihanović
2023-11-11 21:01               ` Duje Mihanović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cbc6def-8255-4a13-99b0-145d3f8ffcac@arm.com \
    --to=robin.murphy@arm.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=balejk@matfyz.cz \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=duje.mihanovic@skole.hr \
    --cc=gpiccoli@igalia.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=keescook@chromium.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoy@marvell.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=mturquette@baylibre.com \
    --cc=perex@perex.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tiwai@suse.com \
    --cc=tony.luck@intel.com \
    --cc=tony@atomide.com \
    --cc=will@kernel.org \
    --cc=zhangfei.gao@marvell.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.