From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A17A43484 for ; Wed, 28 Jul 2021 21:45:58 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so6279127pjd.0 for ; Wed, 28 Jul 2021 14:45:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XicekCZGMuTmx7BgzDuVSPZdtJx2YNBwg9Vgy0Mbawo=; b=X/IhFa7+rUxFnSDRkCGMW82N9BdxQEWPzsmqJY5PMK3Sgvknnf9yxKWWRPzWE97yWk c6YmtiNbk7Qwe/tTvlytHU6/RHnJOjFdVyxpQqOgpHXT7u8pcKRYQy+8LB+TC+esJUi+ jJSJ0g/4LFUNP22uQHsv+n5k/339cT9KBB2/LyGKeegQkhp2XG/6jMIZ7yn3ryEBhQF4 J/1Whu1hG2wh1B6f2nZRQSPI+jlZuBWf6USAUywpWDxxDYHQMlKOU55JM3onezH/pDf1 hbumywH3JvDXMfLEap15lmvoMnP0u/wgN3FFR4KUpdWFIiAWPTLOkML7Fi2cc7fCmzPV QTSw== X-Gm-Message-State: AOAM533aQqbXnIP5/QP0qIJVRV3vXcPJmunHfd6RjqXvODo6DmMUudo8 cvY2q9wN6Vm5n4gF+gIUWlk= X-Google-Smtp-Source: ABdhPJw8GLTntP9/607bFZm4hvTLuV2RygVm16ypIjamKfpthJMPHWWs51SpMIWNplCV818V7piMmg== X-Received: by 2002:a62:61c3:0:b029:35b:cb61:d2c3 with SMTP id v186-20020a6261c30000b029035bcb61d2c3mr1780844pfb.62.1627508758153; Wed, 28 Jul 2021 14:45:58 -0700 (PDT) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:1:3328:5f8d:f6e2:85ea]) by smtp.gmail.com with ESMTPSA id b15sm876167pgj.60.2021.07.28.14.45.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 14:45:57 -0700 (PDT) Subject: Re: [PATCH 48/64] drbd: Use struct_group() to zero algs To: Kees Cook , linux-hardening@vger.kernel.org Cc: "Gustavo A. R. Silva" , Keith Packard , Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com References: <20210727205855.411487-1-keescook@chromium.org> <20210727205855.411487-49-keescook@chromium.org> From: Bart Van Assche Message-ID: <1cc74e5e-8d28-6da4-244e-861eac075ca2@acm.org> Date: Wed, 28 Jul 2021 14:45:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210727205855.411487-49-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/27/21 1:58 PM, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add a struct_group() for the algs so that memset() can correctly reason > about the size. > > Signed-off-by: Kees Cook > --- > drivers/block/drbd/drbd_main.c | 3 ++- > drivers/block/drbd/drbd_protocol.h | 6 ++++-- > drivers/block/drbd/drbd_receiver.c | 3 ++- > 3 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c > index 55234a558e98..b824679cfcb2 100644 > --- a/drivers/block/drbd/drbd_main.c > +++ b/drivers/block/drbd/drbd_main.c > @@ -729,7 +729,8 @@ int drbd_send_sync_param(struct drbd_peer_device *peer_device) > cmd = apv >= 89 ? P_SYNC_PARAM89 : P_SYNC_PARAM; > > /* initialize verify_alg and csums_alg */ > - memset(p->verify_alg, 0, 2 * SHARED_SECRET_MAX); > + BUILD_BUG_ON(sizeof(p->algs) != 2 * SHARED_SECRET_MAX); > + memset(&p->algs, 0, sizeof(p->algs)); > > if (get_ldev(peer_device->device)) { > dc = rcu_dereference(peer_device->device->ldev->disk_conf); > diff --git a/drivers/block/drbd/drbd_protocol.h b/drivers/block/drbd/drbd_protocol.h > index dea59c92ecc1..a882b65ab5d2 100644 > --- a/drivers/block/drbd/drbd_protocol.h > +++ b/drivers/block/drbd/drbd_protocol.h > @@ -283,8 +283,10 @@ struct p_rs_param_89 { > > struct p_rs_param_95 { > u32 resync_rate; > - char verify_alg[SHARED_SECRET_MAX]; > - char csums_alg[SHARED_SECRET_MAX]; > + struct_group(algs, > + char verify_alg[SHARED_SECRET_MAX]; > + char csums_alg[SHARED_SECRET_MAX]; > + ); > u32 c_plan_ahead; > u32 c_delay_target; > u32 c_fill_target; > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index 1f740e42e457..6df2539e215b 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -3921,7 +3921,8 @@ static int receive_SyncParam(struct drbd_connection *connection, struct packet_i > > /* initialize verify_alg and csums_alg */ > p = pi->data; > - memset(p->verify_alg, 0, 2 * SHARED_SECRET_MAX); > + BUILD_BUG_ON(sizeof(p->algs) != 2 * SHARED_SECRET_MAX); > + memset(&p->algs, 0, sizeof(p->algs)); Using struct_group() introduces complexity. Has it been considered not to modify struct p_rs_param_95 and instead to use two memset() calls instead of one (one memset() call per member)? Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E497C432BE for ; Wed, 28 Jul 2021 21:46:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6392760F12 for ; Wed, 28 Jul 2021 21:46:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6392760F12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D15166E3B2; Wed, 28 Jul 2021 21:45:59 +0000 (UTC) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88A256E3B2 for ; Wed, 28 Jul 2021 21:45:58 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso6070990pjf.4 for ; Wed, 28 Jul 2021 14:45:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XicekCZGMuTmx7BgzDuVSPZdtJx2YNBwg9Vgy0Mbawo=; b=qRsvbI+rHYEiRC2rsaQilPSeDsG6xHz23Gg7u7G77h5lVYiE9RY/ic/QrdP1CiLGFG HNGvcUk7vxNmx+5k1fEoVctQeebmoMZAtWlgrNdUC3wYJKUtcM9ps+7FkAM8Tf4dFWZq WLiZmfxApauaFEr8uRik+m2354Ycce0Jc/G8MKm3OJqS4b18r+xGepvsfIByOyUXQTOV AEdblj9EfgtvfzohyJVRv1CHNdEnV0N0a5aFfg2/BCMTmURWn3I4OGoCrN29tUESJzlq ucoykYE6ETvM5+vW8doZjyiEbC0lv68lJXr+ICOdJrjzus1Eyqko+Fxd94zBL8I7lj2k YlCg== X-Gm-Message-State: AOAM530byz4yqa649A+R7yUub+s7FMyc7so+r46PoSgJF+eyTdfcE4R2 Asbd2/SqLF81gng+npvN+os= X-Google-Smtp-Source: ABdhPJw8GLTntP9/607bFZm4hvTLuV2RygVm16ypIjamKfpthJMPHWWs51SpMIWNplCV818V7piMmg== X-Received: by 2002:a62:61c3:0:b029:35b:cb61:d2c3 with SMTP id v186-20020a6261c30000b029035bcb61d2c3mr1780844pfb.62.1627508758153; Wed, 28 Jul 2021 14:45:58 -0700 (PDT) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:1:3328:5f8d:f6e2:85ea]) by smtp.gmail.com with ESMTPSA id b15sm876167pgj.60.2021.07.28.14.45.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jul 2021 14:45:57 -0700 (PDT) Subject: Re: [PATCH 48/64] drbd: Use struct_group() to zero algs To: Kees Cook , linux-hardening@vger.kernel.org References: <20210727205855.411487-1-keescook@chromium.org> <20210727205855.411487-49-keescook@chromium.org> From: Bart Van Assche Message-ID: <1cc74e5e-8d28-6da4-244e-861eac075ca2@acm.org> Date: Wed, 28 Jul 2021 14:45:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210727205855.411487-49-keescook@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kbuild@vger.kernel.org, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, "Gustavo A. R. Silva" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, clang-built-linux@googlegroups.com, Keith Packard , netdev@vger.kernel.org, Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/27/21 1:58 PM, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add a struct_group() for the algs so that memset() can correctly reason > about the size. > > Signed-off-by: Kees Cook > --- > drivers/block/drbd/drbd_main.c | 3 ++- > drivers/block/drbd/drbd_protocol.h | 6 ++++-- > drivers/block/drbd/drbd_receiver.c | 3 ++- > 3 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c > index 55234a558e98..b824679cfcb2 100644 > --- a/drivers/block/drbd/drbd_main.c > +++ b/drivers/block/drbd/drbd_main.c > @@ -729,7 +729,8 @@ int drbd_send_sync_param(struct drbd_peer_device *peer_device) > cmd = apv >= 89 ? P_SYNC_PARAM89 : P_SYNC_PARAM; > > /* initialize verify_alg and csums_alg */ > - memset(p->verify_alg, 0, 2 * SHARED_SECRET_MAX); > + BUILD_BUG_ON(sizeof(p->algs) != 2 * SHARED_SECRET_MAX); > + memset(&p->algs, 0, sizeof(p->algs)); > > if (get_ldev(peer_device->device)) { > dc = rcu_dereference(peer_device->device->ldev->disk_conf); > diff --git a/drivers/block/drbd/drbd_protocol.h b/drivers/block/drbd/drbd_protocol.h > index dea59c92ecc1..a882b65ab5d2 100644 > --- a/drivers/block/drbd/drbd_protocol.h > +++ b/drivers/block/drbd/drbd_protocol.h > @@ -283,8 +283,10 @@ struct p_rs_param_89 { > > struct p_rs_param_95 { > u32 resync_rate; > - char verify_alg[SHARED_SECRET_MAX]; > - char csums_alg[SHARED_SECRET_MAX]; > + struct_group(algs, > + char verify_alg[SHARED_SECRET_MAX]; > + char csums_alg[SHARED_SECRET_MAX]; > + ); > u32 c_plan_ahead; > u32 c_delay_target; > u32 c_fill_target; > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index 1f740e42e457..6df2539e215b 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -3921,7 +3921,8 @@ static int receive_SyncParam(struct drbd_connection *connection, struct packet_i > > /* initialize verify_alg and csums_alg */ > p = pi->data; > - memset(p->verify_alg, 0, 2 * SHARED_SECRET_MAX); > + BUILD_BUG_ON(sizeof(p->algs) != 2 * SHARED_SECRET_MAX); > + memset(&p->algs, 0, sizeof(p->algs)); Using struct_group() introduces complexity. Has it been considered not to modify struct p_rs_param_95 and instead to use two memset() calls instead of one (one memset() call per member)? Thanks, Bart.