From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C17F9C433E3 for ; Sat, 25 Jul 2020 16:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D16B206F6 for ; Sat, 25 Jul 2020 16:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595694488; bh=ZGJ9wovlL834zONXF71oiA5DPaPlldIbIJTnUFfLbWA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=K7+3Qv/Yd6nAkQG1a5iMqOPhqxI/wloNBKRJN5HzkRj8+SlcrAla2EdrllMiDkhSu u7JUYhMJJsiiBh5xCzlye7xbNNnDs5D5+YKwy0ww79V0E+X3is5j42SDS6oIXU8/If iJgsUCxxo/Xm51Ov6l1hl8w0OI78Y+omW7tl49iA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727789AbgGYQ17 (ORCPT ); Sat, 25 Jul 2020 12:27:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbgGYQ17 (ORCPT ); Sat, 25 Jul 2020 12:27:59 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E271B20674; Sat, 25 Jul 2020 16:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595694479; bh=ZGJ9wovlL834zONXF71oiA5DPaPlldIbIJTnUFfLbWA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j+FD0H/s0WZrA68Cw9sGGZr0JfKFpXkdH4Yo6gQxeOovekdRKCdH3DIvI6/eYQwjF psSPh7Wf3FpfpBwBiXLrDYzhvnDkW+YiMKgNamA5fxSSg9VLcFjcsWYiVEsmt1v2Au TMJMspVjcBGPdnPthbXM/8Pb7L+R9DAaj8jUn+F8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jzN1h-00Es3k-9y; Sat, 25 Jul 2020 17:27:57 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 25 Jul 2020 17:27:57 +0100 From: Marc Zyngier To: Suman Anna Cc: Grzegorz Jaszczyk , tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com Subject: Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts In-Reply-To: <14a0978a-f38f-8cd7-3fee-b0e438513396@ti.com> References: <1593699479-1445-1-git-send-email-grzegorz.jaszczyk@linaro.org> <1593699479-1445-4-git-send-email-grzegorz.jaszczyk@linaro.org> <2a6b0391f1395eb0aa15ffee6769184e@kernel.org> <3a73bb14-9f7b-970d-fbae-f9c7bb7bdf1e@ti.com> <87imemxv3l.wl-maz@kernel.org> <14a0978a-f38f-8cd7-3fee-b0e438513396@ti.com> User-Agent: Roundcube Webmail/1.4.5 Message-ID: <1cd0b6c9bfe2dc42e9c6b69baacf4635@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: s-anna@ti.com, grzegorz.jaszczyk@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-25 16:57, Suman Anna wrote: Suman, > Hi Marc, [...] >>>>> @@ -244,8 +295,14 @@ static int pruss_intc_probe(struct >>>>> platform_device *pdev) >>>>>          return -ENOMEM; >>>>> >>>>>      for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { >>>>> +        if (intc->invalid_intr & BIT(i)) >>>>> +            continue; >>>>> + >>>>>          irq = platform_get_irq_byname(pdev, irq_names[i]); >>>>>          if (irq <= 0) { >>>>> +            if (intc->shared_intr & BIT(i)) >>>>> +                continue; >>>> >>>> I don't really understand why you are treating these "shared" >>>> interrupts >>>> differently from the invalid ones. In all cases, they shouldn't be >>>> used. >>> >>> The behavior is the same in how we handle it, but the difference is >>> that an "invalid" one is never even connected to the ARM interrupt >>> controller, while the "shared" one is a choice. So, unless this >>> interrupt is being used/handled by a different processor/entity, you >>> would not see this skipped from the dts node. >> >> And I'm saying that all that matters is that you are discarding these >> interrupts. Whether they are flagged invalid or shared, they are not >> available to Linux. So the difference in handling is pointless and >> only makes it harder to understand what you are doing. > > The primary reason for using two properties and this logic was to > accurately describe the h/w and usage of these in the DT bindings to > distinguish the "never connected" vs the "optionally can be skipped" > interrupts rather than go by how these are handled in the driver. I > feel we will loose this description and make it confusing for SoC > product integration developers. This logic makes zero difference to Linux, and I do not see what you gain by having two code paths with separate list of unusable interrupts. And why on Earth would a "Soc product integration developer" have any business to mess with this driver code? They should very much stay away from it and deal with their precious value add. If you want two properties or even twenty, go for it, and have fun. Just don't make this driver even more unreadable than it already is. Merge all these interrupts in *one* list of unusable interrupts, and be done with it. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A2FC433E1 for ; Sat, 25 Jul 2020 16:29:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1F2120674 for ; Sat, 25 Jul 2020 16:29:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wtskh8eZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="j+FD0H/s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1F2120674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1cS7PGxDqQgqGui3Ouxw8vwPB9P2Sid9zwGOYzhvByE=; b=Wtskh8eZlfwR1NvOYPLhs3iiC aqIUHdZTutyHru0jg5ASpNxIPArQiNXxwEZP/F4R37SYqcWJ2y8PdRS911B2dDAqGP43q1d7M7Dfg 5NZo3msmWd3j5ZAvzdJ699PzwvZHUf6ub/TaEZWwHUPgXWPrB4nm5tPeLvvSxfIljZdrcUvsJqseM vijpWHYdSeVZieL/kZtEPdU4U+zOXa0rnEiRhRt9Yee7eXr9uJqnVE9umjYsXQigOjTMRrafUy83C lt5jtEUK8Xs7pEimn0CfxOyoQTLrJWRMALZAW0L0fTg9PNUUlJecCABreJKJ+psq8ko/TUGe9KONw 9Y7wZhxaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzN1o-000865-6R; Sat, 25 Jul 2020 16:28:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzN1k-00085E-6P for linux-arm-kernel@lists.infradead.org; Sat, 25 Jul 2020 16:28:03 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E271B20674; Sat, 25 Jul 2020 16:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595694479; bh=ZGJ9wovlL834zONXF71oiA5DPaPlldIbIJTnUFfLbWA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j+FD0H/s0WZrA68Cw9sGGZr0JfKFpXkdH4Yo6gQxeOovekdRKCdH3DIvI6/eYQwjF psSPh7Wf3FpfpBwBiXLrDYzhvnDkW+YiMKgNamA5fxSSg9VLcFjcsWYiVEsmt1v2Au TMJMspVjcBGPdnPthbXM/8Pb7L+R9DAaj8jUn+F8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jzN1h-00Es3k-9y; Sat, 25 Jul 2020 17:27:57 +0100 MIME-Version: 1.0 Date: Sat, 25 Jul 2020 17:27:57 +0100 From: Marc Zyngier To: Suman Anna Subject: Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts In-Reply-To: <14a0978a-f38f-8cd7-3fee-b0e438513396@ti.com> References: <1593699479-1445-1-git-send-email-grzegorz.jaszczyk@linaro.org> <1593699479-1445-4-git-send-email-grzegorz.jaszczyk@linaro.org> <2a6b0391f1395eb0aa15ffee6769184e@kernel.org> <3a73bb14-9f7b-970d-fbae-f9c7bb7bdf1e@ti.com> <87imemxv3l.wl-maz@kernel.org> <14a0978a-f38f-8cd7-3fee-b0e438513396@ti.com> User-Agent: Roundcube Webmail/1.4.5 Message-ID: <1cd0b6c9bfe2dc42e9c6b69baacf4635@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: s-anna@ti.com, grzegorz.jaszczyk@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200725_122800_466622_49D6D6FF X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Grzegorz Jaszczyk , jason@lakedaemon.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-omap@vger.kernel.org, lee.jones@linaro.org, wmills@ti.com, linux-arm-kernel@lists.infradead.org, david@lechnology.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0wNy0yNSAxNjo1NywgU3VtYW4gQW5uYSB3cm90ZToKClN1bWFuLAoKPiBIaSBNYXJj LAoKWy4uLl0KCj4+Pj4+IEBAIC0yNDQsOCArMjk1LDE0IEBAIHN0YXRpYyBpbnQgcHJ1c3NfaW50 Y19wcm9iZShzdHJ1Y3QKPj4+Pj4gcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+Pj4+PiAgwqDCoMKg wqDCoMKgwqDCoCByZXR1cm4gLUVOT01FTTsKPj4+Pj4gCj4+Pj4+ICDCoMKgwqDCoCBmb3IgKGkg PSAwOyBpIDwgTUFYX05VTV9IT1NUX0lSUVM7IGkrKykgewo+Pj4+PiArwqDCoMKgwqDCoMKgwqAg aWYgKGludGMtPmludmFsaWRfaW50ciAmIEJJVChpKSkKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqAgY29udGludWU7Cj4+Pj4+ICsKPj4+Pj4gIMKgwqDCoMKgwqDCoMKgwqAgaXJxID0gcGxh dGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgaXJxX25hbWVzW2ldKTsKPj4+Pj4gIMKgwqDCoMKg wqDCoMKgwqAgaWYgKGlycSA8PSAwKSB7Cj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlm IChpbnRjLT5zaGFyZWRfaW50ciAmIEJJVChpKSkKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBjb250aW51ZTsKPj4+PiAKPj4+PiBJIGRvbid0IHJlYWxseSB1bmRlcnN0YW5k IHdoeSB5b3UgYXJlIHRyZWF0aW5nIHRoZXNlICJzaGFyZWQiIAo+Pj4+IGludGVycnVwdHMKPj4+ PiBkaWZmZXJlbnRseSBmcm9tIHRoZSBpbnZhbGlkIG9uZXMuIEluIGFsbCBjYXNlcywgdGhleSBz aG91bGRuJ3QgYmUgCj4+Pj4gdXNlZC4KPj4+IAo+Pj4gVGhlIGJlaGF2aW9yIGlzIHRoZSBzYW1l IGluIGhvdyB3ZSBoYW5kbGUgaXQsIGJ1dCB0aGUgZGlmZmVyZW5jZSBpcwo+Pj4gdGhhdCBhbiAi aW52YWxpZCIgb25lIGlzIG5ldmVyIGV2ZW4gY29ubmVjdGVkIHRvIHRoZSBBUk0gaW50ZXJydXB0 Cj4+PiBjb250cm9sbGVyLCB3aGlsZSB0aGUgInNoYXJlZCIgb25lIGlzIGEgY2hvaWNlLiBTbywg dW5sZXNzIHRoaXMKPj4+IGludGVycnVwdCBpcyBiZWluZyB1c2VkL2hhbmRsZWQgYnkgYSBkaWZm ZXJlbnQgcHJvY2Vzc29yL2VudGl0eSwgeW91Cj4+PiB3b3VsZCBub3Qgc2VlIHRoaXMgc2tpcHBl ZCBmcm9tIHRoZSBkdHMgbm9kZS4KPj4gCj4+IEFuZCBJJ20gc2F5aW5nIHRoYXQgYWxsIHRoYXQg bWF0dGVycyBpcyB0aGF0IHlvdSBhcmUgZGlzY2FyZGluZyB0aGVzZQo+PiBpbnRlcnJ1cHRzLiBX aGV0aGVyIHRoZXkgYXJlIGZsYWdnZWQgaW52YWxpZCBvciBzaGFyZWQsIHRoZXkgYXJlIG5vdAo+ PiBhdmFpbGFibGUgdG8gTGludXguIFNvIHRoZSBkaWZmZXJlbmNlIGluIGhhbmRsaW5nIGlzIHBv aW50bGVzcyBhbmQKPj4gb25seSBtYWtlcyBpdCBoYXJkZXIgdG8gdW5kZXJzdGFuZCB3aGF0IHlv dSBhcmUgZG9pbmcuCj4gCj4gVGhlIHByaW1hcnkgcmVhc29uIGZvciB1c2luZyB0d28gcHJvcGVy dGllcyBhbmQgdGhpcyBsb2dpYyB3YXMgdG8KPiBhY2N1cmF0ZWx5IGRlc2NyaWJlIHRoZSBoL3cg YW5kIHVzYWdlIG9mIHRoZXNlIGluIHRoZSBEVCBiaW5kaW5ncyB0bwo+IGRpc3Rpbmd1aXNoIHRo ZSAibmV2ZXIgY29ubmVjdGVkIiB2cyB0aGUgIm9wdGlvbmFsbHkgY2FuIGJlIHNraXBwZWQiCj4g aW50ZXJydXB0cyByYXRoZXIgdGhhbiBnbyBieSBob3cgdGhlc2UgYXJlIGhhbmRsZWQgaW4gdGhl IGRyaXZlci4gSQo+IGZlZWwgd2Ugd2lsbCBsb29zZSB0aGlzIGRlc2NyaXB0aW9uIGFuZCBtYWtl IGl0IGNvbmZ1c2luZyBmb3IgU29DCj4gcHJvZHVjdCBpbnRlZ3JhdGlvbiBkZXZlbG9wZXJzLgoK VGhpcyBsb2dpYyBtYWtlcyB6ZXJvIGRpZmZlcmVuY2UgdG8gTGludXgsIGFuZCBJIGRvIG5vdCBz ZWUgd2hhdAp5b3UgZ2FpbiBieSBoYXZpbmcgdHdvIGNvZGUgcGF0aHMgd2l0aCBzZXBhcmF0ZSBs aXN0IG9mIHVudXNhYmxlCmludGVycnVwdHMuIEFuZCB3aHkgb24gRWFydGggd291bGQgYSAiU29j IHByb2R1Y3QgaW50ZWdyYXRpb24KZGV2ZWxvcGVyIiBoYXZlIGFueSBidXNpbmVzcyB0byBtZXNz IHdpdGggdGhpcyBkcml2ZXIgY29kZT8KVGhleSBzaG91bGQgdmVyeSBtdWNoIHN0YXkgYXdheSBm cm9tIGl0IGFuZCBkZWFsIHdpdGggdGhlaXIKcHJlY2lvdXMgdmFsdWUgYWRkLgoKSWYgeW91IHdh bnQgdHdvIHByb3BlcnRpZXMgb3IgZXZlbiB0d2VudHksIGdvIGZvciBpdCwgYW5kIGhhdmUgZnVu LgpKdXN0IGRvbid0IG1ha2UgdGhpcyBkcml2ZXIgZXZlbiBtb3JlIHVucmVhZGFibGUgdGhhbiBp dCBhbHJlYWR5IGlzLgpNZXJnZSBhbGwgdGhlc2UgaW50ZXJydXB0cyBpbiAqb25lKiBsaXN0IG9m IHVudXNhYmxlIGludGVycnVwdHMsCmFuZCBiZSBkb25lIHdpdGggaXQuCgpUaGFua3MsCgogICAg ICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK