From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C75C73C53 for ; Tue, 9 Jul 2019 21:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D21BC2073D for ; Tue, 9 Jul 2019 21:27:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbfGIV1p (ORCPT ); Tue, 9 Jul 2019 17:27:45 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:32972 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbfGIV1p (ORCPT ); Tue, 9 Jul 2019 17:27:45 -0400 Received: by mail-oi1-f194.google.com with SMTP id u15so16549741oiv.0; Tue, 09 Jul 2019 14:27:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JFmZc74oeeM35zjBvo4+BukpLYLvklQy3qJm+E2OtJU=; b=KlBUku48coRkOcM346aG1N84w+w094WErXhf3NDNsJ8Ev4ofPfyJ84st/VXAHZ+qWN hbjUjMNtuFYssDOkZVmwQd3jjZ2aRHB7LzZXMudOMxdKhUXjQvgE99NClgNPIO9Hpbsn DIzB9bQbLC40kM7pMc6/KHr5SMVkYeHFCvBdMqfHphhwbUtugNsyLNSNokIRfza2ig2X /PMvJE1angF7Z5mFBMnIgt+z1vmKeipku7Z9X8AxWGgPHhFuGAHgyr6b+hgeRoZvAitO MaMZtVMtexu/mDiDaPJDmIj/PXEPssl8OybHTMF+x7fDOqDtGMhu4cZlWCM+hLUEM+WA /zRg== X-Gm-Message-State: APjAAAVI9Ye44jivetFVqOZCFmvvH+8LUTdSKcFV7Un8OFJwL0f6DqB6 JHSlWrWIbWHqb/KJfPSj59g= X-Google-Smtp-Source: APXvYqxDF0A6yCgF0FCviLWVZqNRm5Hbs7TmfD5YpmIKbBad5iRl8KSOywojmloSncHdk6BuyEh3eg== X-Received: by 2002:aca:d7d5:: with SMTP id o204mr1337022oig.16.1562707664103; Tue, 09 Jul 2019 14:27:44 -0700 (PDT) Received: from ?IPv6:2600:1700:65a0:78e0:514:7862:1503:8e4d? ([2600:1700:65a0:78e0:514:7862:1503:8e4d]) by smtp.gmail.com with ESMTPSA id o18sm140782ote.63.2019.07.09.14.27.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 14:27:43 -0700 (PDT) Subject: Re: [PATCH v4 00/25] InfiniBand Transport (IBTRS) and Network Block Device (IBNBD) To: Jason Gunthorpe , Jinpu Wang Cc: Jinpu Wang , Leon Romanovsky , Danil Kipnis , "linux-block@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Jens Axboe , Christoph Hellwig , "bvanassche@acm.org" , "dledford@redhat.com" , Roman Pen , Greg Kroah-Hartman References: <20190620150337.7847-1-jinpuwang@gmail.com> <20190709110036.GQ7034@mtr-leonro.mtl.com> <20190709120606.GB3436@mellanox.com> <20190709131932.GI3436@mellanox.com> From: Sagi Grimberg Message-ID: <1cd86f4b-7cd1-4e00-7111-5c8e09ba06be@grimberg.me> Date: Tue, 9 Jul 2019 14:27:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190709131932.GI3436@mellanox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org >> Thanks Jason for feedback. >> Can you be more specific about "the invalidation model for MR was wrong" > > MR's must be invalidated before data is handed over to the block > layer. It can't leave MRs open for access and then touch the memory > the MR covers. Jason is referring to these fixes: 2f122e4f5107 ("nvme-rdma: wait for local invalidation before completing a request") 4af7f7ff92a4 ("nvme-rdma: don't complete requests before a send work request has completed") b4b591c87f2b ("nvme-rdma: don't suppress send completions")