From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65120C433F5 for ; Sun, 17 Apr 2022 17:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232593AbiDQSAn (ORCPT ); Sun, 17 Apr 2022 14:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231189AbiDQSAl (ORCPT ); Sun, 17 Apr 2022 14:00:41 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C7D1AF3A for ; Sun, 17 Apr 2022 10:58:04 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id u15so23473122ejf.11 for ; Sun, 17 Apr 2022 10:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nSubeHyIkbDyezCXTtI5pe5KWL/Nm+X5yHUcXHqauxY=; b=KmCxtqwiDxG8GCSszSnyyyohTIwtJgrR4dUoq6Pfw2NqgZdygFjyj52fymLpmFKQyV o1D/vivFHFxicCfzDfW2EdM5J1v7O0OsXJUF3UJhWq9NTWJDMwaCar9U4Yh6/o0wc+PI 85xJa78Im2Lp7png/Ov+RZ3TQZdRvx1ByVbt1flSmuoYsi4//TUWig18ZBv/nqedKgm0 heXVjbAGS90FAg9SFPZZMv4aBG/o+oHmzpswH931UpQXPd+Vt4h2ibwDESMDVYyjPN08 o4X/bShbg7lG7u+Cv9wZrJf7GOwbQKFzT3aG9hxhfmd+ZRdEI0MY+PsbNoef/hz1LuP+ +yZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nSubeHyIkbDyezCXTtI5pe5KWL/Nm+X5yHUcXHqauxY=; b=QjNzAsxZzLDOkL7yYjNr+IdMnJC+SIbfcVnqk7kuvad1XvXqdAIYxJDBvp+wGilcKC ywq1MJxHgd6H0UUJ0ttDl9IBjjptFcDItXvzYtYLnVIQ6FfnbD4P0aoB9j2bJDwstKJm wsX7mOONz87xeHzov1u09MCCBaDU9a00KYair5c7IW0chmzuIzQac8iLu4j4ra5WqESg Tq0k6KtHZAW2Zcy4RP5xymeLw1bwO9BD1dew3W+yhKie//c9J1c1IbrDNxWXFHR+EEZW bHGLjDBTqr0vNdzcCKuR+HXBE/9Z+muSf+K9Bhs5ASEru81mxBJmvQyDbtPfOjbCxUTX ABsA== X-Gm-Message-State: AOAM533eyV8vfOLq3eILnpJuOXHtEzIbNq4KCswcQ6+dDXOStBo1sjMN c9dZgAU3sjW6py2Eb/1siQKM5A== X-Google-Smtp-Source: ABdhPJwn4RYMuzx1OPkO0KuwJKryizP0RNdSa0rqni5YB3lwpEj/clUpmf0tuoUU1d7TDzbh6UlCZg== X-Received: by 2002:a17:906:c113:b0:6d7:7b53:9cb with SMTP id do19-20020a170906c11300b006d77b5309cbmr6634960ejc.197.1650218283093; Sun, 17 Apr 2022 10:58:03 -0700 (PDT) Received: from [192.168.0.216] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id bf11-20020a0564021a4b00b00423e997a3ccsm80153edb.19.2022.04.17.10.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 10:58:02 -0700 (PDT) Message-ID: <1cecb0c3-2925-765f-0654-37d5703b75b8@linaro.org> Date: Sun, 17 Apr 2022 19:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Content-Language: en-US To: Nishanth Menon Cc: Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220407143140.295092-1-krzysztof.kozlowski@linaro.org> <20220407143140.295092-2-krzysztof.kozlowski@linaro.org> <20220415185439.4hsfnllhplfcpwvk@encrypt> From: Krzysztof Kozlowski In-Reply-To: <20220415185439.4hsfnllhplfcpwvk@encrypt> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/2022 20:54, Nishanth Menon wrote: > > I have no idea how this works. There is no documentation for the > compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor"; Compatible is documented in jedec,spi-nor.yaml (through pattern), although it should be followed by "jedec,spi-nor", according to schema. I did not fix that missing compatible fallback, because I did not want to break any setup (I cannot test it), but adding the fallback seems harmless/safe. > > $ git grep micron,n25q128a11 . > arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11"; > arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > > Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FE16C433EF for ; Sun, 17 Apr 2022 17:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2pBIApQqY/nrPooPAp77K1XJnzD9+5OBYHQYxDFyfik=; b=OMM+JvScKJYFF7 qRHPUk49TfX6WK2v8H1jkDEKoxtQ+RTyKmUG8VbZIJW1Hu12bbWR+IjczuDZIiDtQE0iySJFVmPId KUa3qukt3uI8ee7cuVpUfU2CdbXR8Oy4+JmU2yUm96yOrbLwGOv22EpXn4JbEOKy18WlZszXpTfbc EEkRC+sw4NW6dlKOKC8FaxzffMz+uY33i48rhI8eCtDOEwCHl6MNNIPQuC26WyvsET4KtYsVZq/3Y +e71eFd8TNJq+cjqNDaAgc9KEx6KKjUwmjilujekviPuhjAO8qZbG7nfLysSPbCIZ3YCPERJUbzEh NRfL8WNcRTi8YvC9MInA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng9A0-00ElfO-Ny; Sun, 17 Apr 2022 17:58:08 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng99x-00Elea-BD for linux-arm-kernel@lists.infradead.org; Sun, 17 Apr 2022 17:58:06 +0000 Received: by mail-ej1-x633.google.com with SMTP id ks6so23576750ejb.1 for ; Sun, 17 Apr 2022 10:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nSubeHyIkbDyezCXTtI5pe5KWL/Nm+X5yHUcXHqauxY=; b=KmCxtqwiDxG8GCSszSnyyyohTIwtJgrR4dUoq6Pfw2NqgZdygFjyj52fymLpmFKQyV o1D/vivFHFxicCfzDfW2EdM5J1v7O0OsXJUF3UJhWq9NTWJDMwaCar9U4Yh6/o0wc+PI 85xJa78Im2Lp7png/Ov+RZ3TQZdRvx1ByVbt1flSmuoYsi4//TUWig18ZBv/nqedKgm0 heXVjbAGS90FAg9SFPZZMv4aBG/o+oHmzpswH931UpQXPd+Vt4h2ibwDESMDVYyjPN08 o4X/bShbg7lG7u+Cv9wZrJf7GOwbQKFzT3aG9hxhfmd+ZRdEI0MY+PsbNoef/hz1LuP+ +yZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nSubeHyIkbDyezCXTtI5pe5KWL/Nm+X5yHUcXHqauxY=; b=XAsCVjjvXcVekIALrL18xen9x1gx85kXfQnhRqxJXO9zegiuGzz9GS6+ZD2d1tOtVq NH6LzhQnaglf4RRs/cRei7fvYpQyn8I/9yLenap3lfqDUlITYUaz6DIweuJMXrRBeXqA xzo5jbE9JCIxKvtYg2KCwYypEWLkWRQIm8lIo8cqHHqu6kPeEYfCBEXn0TkHYEPu6SIH /f1dfMeUtiLb38mMVi50rHmhpyAOwUZCf5cbew1T/dGIRv/j4XVyrVjMPdC/izkSy7Bm 2LlVUmAv26QrnGnGysLZWWi1JzwrOk2QPrGjM+FncIgH/9+yrGcKXW6q/76u/GUCJ6hz 0ADg== X-Gm-Message-State: AOAM530wc5dlPvLtdlvIZd0HXiQS9MvOzszD7CkAXmYqQ22F7f+baDf2 3NrzTDNTjDlXFJVBw4tDZMokdAIKqW/s6A== X-Google-Smtp-Source: ABdhPJwn4RYMuzx1OPkO0KuwJKryizP0RNdSa0rqni5YB3lwpEj/clUpmf0tuoUU1d7TDzbh6UlCZg== X-Received: by 2002:a17:906:c113:b0:6d7:7b53:9cb with SMTP id do19-20020a170906c11300b006d77b5309cbmr6634960ejc.197.1650218283093; Sun, 17 Apr 2022 10:58:03 -0700 (PDT) Received: from [192.168.0.216] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id bf11-20020a0564021a4b00b00423e997a3ccsm80153edb.19.2022.04.17.10.58.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Apr 2022 10:58:02 -0700 (PDT) Message-ID: <1cecb0c3-2925-765f-0654-37d5703b75b8@linaro.org> Date: Sun, 17 Apr 2022 19:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] ARM: dts: keystone: fix case in SPI NOR node compatible Content-Language: en-US To: Nishanth Menon Cc: Santosh Shilimkar , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220407143140.295092-1-krzysztof.kozlowski@linaro.org> <20220407143140.295092-2-krzysztof.kozlowski@linaro.org> <20220415185439.4hsfnllhplfcpwvk@encrypt> From: Krzysztof Kozlowski In-Reply-To: <20220415185439.4hsfnllhplfcpwvk@encrypt> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_105805_434506_F063188F X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/04/2022 20:54, Nishanth Menon wrote: > > I have no idea how this works. There is no documentation for the > compatible, So I am guessing adding it to Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > is appropriate prior to replacing with "micron,n25q128a11", "jedec,spi-nor"; Compatible is documented in jedec,spi-nor.yaml (through pattern), although it should be followed by "jedec,spi-nor", according to schema. I did not fix that missing compatible fallback, because I did not want to break any setup (I cannot test it), but adding the fallback seems harmless/safe. > > $ git grep micron,n25q128a11 . > arch/arm/boot/dts/imx6qdl-aristainetos.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/arm/boot/dts/keystone-k2e-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2hk-evm.dts: compatible = "micron,n25q128a11"; > arch/arm/boot/dts/keystone-k2l-evm.dts: compatible = "micron,n25q128a11"; > arch/powerpc/boot/dts/fsl/t1024qds.dts: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > arch/powerpc/boot/dts/fsl/t104xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; > arch/powerpc/boot/dts/fsl/t208xqds.dtsi: compatible = "micron,n25q128a11", "jedec,spi-nor"; /* 16MB */ > > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel