From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B915C77B6D for ; Tue, 28 Mar 2023 17:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbjC1Q76 (ORCPT ); Tue, 28 Mar 2023 12:59:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjC1Q75 (ORCPT ); Tue, 28 Mar 2023 12:59:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22DCC9ECF; Tue, 28 Mar 2023 09:59:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A129D618C7; Tue, 28 Mar 2023 16:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE429C433EF; Tue, 28 Mar 2023 16:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680022796; bh=5JSnUi0WPwXlNlLr2PLygtWZxa1SAMU3aE2taoy2XJ8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=pG0CxzYc2iEAdKBPDBguoug0WhMNqYnXGWZ0vBpoy+o6qPYkfq/te1U0HzBubmaQY Qc8D+RBVRs1+W1SNXJeXhNKBBI9XldesJIStEjChrgsxA4gbMXGDDthNbKmnJm75t/ rbiuw9xpcFMA4l9jMzA9x3O4cQgTvHfYJBzKd5tHBS2YxTcl56WOqzpvinvMcLQ6QR ZZZNr2QWvUVX9A5g2OoAj4eUUfQqtuziuEXpF+e38ZnF2Wj0hWFv1NPx+LQ0f+d+u7 6i1mCDUrzUQp9f8kbWzJZ1qdkaw6r3WKLHPJQlx2L24KbYY/2fUPQel4IbrAAIC++G gXkxDvMHR41aw== Message-ID: <1cfd584a48e1bb453596948a0187ecf1.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <2484518b-bcf6-7fb1-6bfb-b96b3682397b@quicinc.com> References: <20230327132718.573-1-quic_devipriy@quicinc.com> <20230327132718.573-3-quic_devipriy@quicinc.com> <0af15083921c5d3c89392209654f0c9b.sboyd@kernel.org> <2484518b-bcf6-7fb1-6bfb-b96b3682397b@quicinc.com> Subject: Re: [PATCH V10 2/4] clk: qcom: Add Global Clock Controller driver for IPQ9574 From: Stephen Boyd Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com To: Devi Priya , agross@kernel.org, andersson@kernel.org, arnd@arndb.de, broonie@kernel.org, catalin.marinas@arm.com, devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org, konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, marcel.ziswiler@toradex.com, mturquette@baylibre.com, nfraprado@collabora.com, p.zabel@pengutronix.de, robh+dt@kernel.org, shawnguo@kernel.org, will@kernel.org Date: Tue, 28 Mar 2023 09:59:53 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Devi Priya (2023-03-27 23:15:35) >=20 >=20 > On 3/27/2023 10:18 PM, Stephen Boyd wrote: > > Quoting Devi Priya (2023-03-27 06:27:16) > >> diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq= 9574.c > >> new file mode 100644 > >> index 000000000000..b2a2d618a5ec > >> --- /dev/null > >> +++ b/drivers/clk/qcom/gcc-ipq9574.c > >> @@ -0,0 +1,4248 @@ > >> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +/* > >> + * Copyright (c) 2023 The Linux Foundation. All rights reserved. > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >=20 > > What is this include for? > This include actually don't seem necessary. But, I see that of.h &=20 > platform_device.h are being included via of_device.h > Would you suggest to drop of_device.h or the other two > headers instead? Include headers for things you use. Don't try to omit includes if you see that a header includes other headers that you're using. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04262C6FD18 for ; Tue, 28 Mar 2023 17:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sh82oJaeXJKxHylcs9pi7bUZYVSeM/ZSNk8JV8WJImE=; b=Roc/E0pvR4TXNz C5vaEM3UhWa0PHX/C5RbQYmh0SuN6o5400ubNDEiIw/bhnBVjTZFt1KwN6bZq6yuYJ1JQ9VB3jKTd iyEEy0lTv8xQof7BKa98ztoBA+Ex2XbRg9CyQEguwagvpMSwjPk2rDjQBqqJQQgjhQ915MbaB9G0u 3uazaDR96zvzBguDyx5pa0nSfJQQ2BqJ7UWYX8YSM65y4HeP0RpIaPI0eXrQ0S2rVP7tXrEN8jbR9 0voFyuzGTXQDO7qtWD/WK2D3Y7EGy8SZVqHiQThEov9mEa5Y4t5yzPoeaJXHKrbzu8HJLXmW6oHEn CWmuZbm4ngIrPfiaLu2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phCfv-00FE7K-2f; Tue, 28 Mar 2023 16:59:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1phCft-00FE66-33 for linux-arm-kernel@lists.infradead.org; Tue, 28 Mar 2023 16:59:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 994B9618C5; Tue, 28 Mar 2023 16:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE429C433EF; Tue, 28 Mar 2023 16:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680022796; bh=5JSnUi0WPwXlNlLr2PLygtWZxa1SAMU3aE2taoy2XJ8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=pG0CxzYc2iEAdKBPDBguoug0WhMNqYnXGWZ0vBpoy+o6qPYkfq/te1U0HzBubmaQY Qc8D+RBVRs1+W1SNXJeXhNKBBI9XldesJIStEjChrgsxA4gbMXGDDthNbKmnJm75t/ rbiuw9xpcFMA4l9jMzA9x3O4cQgTvHfYJBzKd5tHBS2YxTcl56WOqzpvinvMcLQ6QR ZZZNr2QWvUVX9A5g2OoAj4eUUfQqtuziuEXpF+e38ZnF2Wj0hWFv1NPx+LQ0f+d+u7 6i1mCDUrzUQp9f8kbWzJZ1qdkaw6r3WKLHPJQlx2L24KbYY/2fUPQel4IbrAAIC++G gXkxDvMHR41aw== Message-ID: <1cfd584a48e1bb453596948a0187ecf1.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <2484518b-bcf6-7fb1-6bfb-b96b3682397b@quicinc.com> References: <20230327132718.573-1-quic_devipriy@quicinc.com> <20230327132718.573-3-quic_devipriy@quicinc.com> <0af15083921c5d3c89392209654f0c9b.sboyd@kernel.org> <2484518b-bcf6-7fb1-6bfb-b96b3682397b@quicinc.com> Subject: Re: [PATCH V10 2/4] clk: qcom: Add Global Clock Controller driver for IPQ9574 From: Stephen Boyd Cc: quic_srichara@quicinc.com, quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com, quic_anusha@quicinc.com, quic_poovendh@quicinc.com To: Devi Priya , agross@kernel.org, andersson@kernel.org, arnd@arndb.de, broonie@kernel.org, catalin.marinas@arm.com, devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org, konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, marcel.ziswiler@toradex.com, mturquette@baylibre.com, nfraprado@collabora.com, p.zabel@pengutronix.de, robh+dt@kernel.org, shawnguo@kernel.org, will@kernel.org Date: Tue, 28 Mar 2023 09:59:53 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230328_095958_043742_8CE06C5D X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Devi Priya (2023-03-27 23:15:35) > > > On 3/27/2023 10:18 PM, Stephen Boyd wrote: > > Quoting Devi Priya (2023-03-27 06:27:16) > >> diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c > >> new file mode 100644 > >> index 000000000000..b2a2d618a5ec > >> --- /dev/null > >> +++ b/drivers/clk/qcom/gcc-ipq9574.c > >> @@ -0,0 +1,4248 @@ > >> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +/* > >> + * Copyright (c) 2023 The Linux Foundation. All rights reserved. > >> + */ > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > >> +#include > > > > What is this include for? > This include actually don't seem necessary. But, I see that of.h & > platform_device.h are being included via of_device.h > Would you suggest to drop of_device.h or the other two > headers instead? Include headers for things you use. Don't try to omit includes if you see that a header includes other headers that you're using. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel