All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Dinh Nguyen <dinguyen@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties
Date: Thu, 28 Apr 2022 11:43:01 +0100	[thread overview]
Message-ID: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> (raw)
In-Reply-To: <20220427155840.596535-5-krzysztof.kozlowski@linaro.org>

On 2022-04-27 16:58, Krzysztof Kozlowski wrote:
> pl330 DMA controller bindings documented 'dma-channels' and
> 'dma-requests' properties (without leading hash sign), so fix the DTS to
> match the bindings.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index 4f40a5c8f565..96ef0ddc0b2d 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -829,8 +829,8 @@ dma-controller@7ff00000 {
>   		compatible = "arm,pl330", "arm,primecell";
>   		reg = <0x0 0x7ff00000 0 0x1000>;
>   		#dma-cells = <1>;
> -		#dma-channels = <8>;
> -		#dma-requests = <32>;
> +		dma-channels = <8>;
> +		dma-requests = <32>;

BTW, this has always been wrong - Juno is configured with only 8 request 
interfaces. But then it's moot anyway since PL330 has an ID register for 
this stuff[1], so the DT properties aren't used by Linux, and shouldn't 
be needed in general.

Thanks,
Robin.

[1] 
https://developer.arm.com/documentation/ddi0424/d/programmers-model/register-descriptions/configuration-register-0?lang=en

>   		interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,

WARNING: multiple messages have this Message-ID
From: Robin Murphy <robin.murphy@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Dinh Nguyen <dinguyen@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom Kernel Team <bcm-kernel-feedback-list@broadcom.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties
Date: Thu, 28 Apr 2022 11:43:01 +0100	[thread overview]
Message-ID: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> (raw)
In-Reply-To: <20220427155840.596535-5-krzysztof.kozlowski@linaro.org>

On 2022-04-27 16:58, Krzysztof Kozlowski wrote:
> pl330 DMA controller bindings documented 'dma-channels' and
> 'dma-requests' properties (without leading hash sign), so fix the DTS to
> match the bindings.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
> index 4f40a5c8f565..96ef0ddc0b2d 100644
> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi
> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
> @@ -829,8 +829,8 @@ dma-controller@7ff00000 {
>   		compatible = "arm,pl330", "arm,primecell";
>   		reg = <0x0 0x7ff00000 0 0x1000>;
>   		#dma-cells = <1>;
> -		#dma-channels = <8>;
> -		#dma-requests = <32>;
> +		dma-channels = <8>;
> +		dma-requests = <32>;

BTW, this has always been wrong - Juno is configured with only 8 request 
interfaces. But then it's moot anyway since PL330 has an ID register for 
this stuff[1], so the DT properties aren't used by Linux, and shouldn't 
be needed in general.

Thanks,
Robin.

[1] 
https://developer.arm.com/documentation/ddi0424/d/programmers-model/register-descriptions/configuration-register-0?lang=en

>   		interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
>   			     <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-28 10:43 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 15:58 [PATCH 00/10] ARM/arm64: dts: use proper 'dma-channels/requests' properties Krzysztof Kozlowski
2022-04-27 15:58 ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 01/10] ARM: dts: zynq-7000: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-28  6:24   ` Michal Simek
2022-04-28  6:24     ` Michal Simek
2022-04-27 15:58 ` [PATCH 02/10] ARM: dts: socfpga: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 03/10] arm64: dts: stratix10/agilex: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 04/10] arm64: dts: juno: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-28 10:43   ` Robin Murphy [this message]
2022-04-28 10:43     ` Robin Murphy
2022-04-28 10:45     ` Krzysztof Kozlowski
2022-04-28 10:45       ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 05/10] arm64: dts: broadcom: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 15:58 ` [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: fix " Krzysztof Kozlowski
2022-04-27 15:58   ` [PATCH 06/10] dt-bindings: mfd: samsung, exynos5433-lpass: " Krzysztof Kozlowski
2022-04-27 16:41   ` [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: " Alim Akhtar
2022-04-27 16:41     ` Alim Akhtar
2022-04-27 18:25   ` Rob Herring
2022-04-27 18:25     ` Rob Herring
2022-04-28  9:53   ` Lee Jones
2022-04-28  9:53     ` Lee Jones
2022-04-27 15:58 ` [PATCH 07/10] ARM: dts: s5pv210: use proper " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:45   ` Alim Akhtar
2022-04-27 16:45     ` Alim Akhtar
2022-04-27 15:58 ` [PATCH 08/10] ARM: dts: exynos: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:44   ` Alim Akhtar
2022-04-27 16:44     ` Alim Akhtar
2022-04-28  9:50   ` Marek Szyprowski
2022-04-28  9:50     ` Marek Szyprowski
2022-04-28  9:54     ` Krzysztof Kozlowski
2022-04-28  9:54       ` Krzysztof Kozlowski
2022-04-28  9:57       ` Marek Szyprowski
2022-04-28  9:57         ` Marek Szyprowski
2022-04-28 10:00         ` Krzysztof Kozlowski
2022-04-28 10:00           ` Krzysztof Kozlowski
2022-04-28 10:05           ` Marek Szyprowski
2022-04-28 10:05             ` Marek Szyprowski
2022-04-28 10:09             ` Krzysztof Kozlowski
2022-04-28 10:09               ` Krzysztof Kozlowski
2022-04-28 13:33               ` Rob Herring
2022-04-28 13:33                 ` Rob Herring
2022-04-28  9:55     ` Alim Akhtar
2022-04-28  9:55       ` Alim Akhtar
2022-04-27 15:58 ` [PATCH 09/10] arm64: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:46   ` Alim Akhtar
2022-04-27 16:46     ` Alim Akhtar
2022-04-27 15:58 ` [PATCH 10/10] arm64: dts: fsd: " Krzysztof Kozlowski
2022-04-27 15:58   ` Krzysztof Kozlowski
2022-04-27 16:49   ` Alim Akhtar
2022-04-27 16:49     ` Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com \
    --to=robin.murphy@arm.com \
    --cc=alim.akhtar@samsung.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sbranden@broadcom.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.