From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F18C433F5 for ; Thu, 28 Apr 2022 10:43:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344621AbiD1Kqq (ORCPT ); Thu, 28 Apr 2022 06:46:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343885AbiD1Kqb (ORCPT ); Thu, 28 Apr 2022 06:46:31 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B1ED86AEC; Thu, 28 Apr 2022 03:43:10 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 963DB1474; Thu, 28 Apr 2022 03:43:10 -0700 (PDT) Received: from [10.57.80.98] (unknown [10.57.80.98]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EEF53F774; Thu, 28 Apr 2022 03:43:07 -0700 (PDT) Message-ID: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> Date: Thu, 28 Apr 2022 11:43:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties Content-Language: en-GB To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> From: Robin Murphy In-Reply-To: <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-04-27 16:58, Krzysztof Kozlowski wrote: > pl330 DMA controller bindings documented 'dma-channels' and > 'dma-requests' properties (without leading hash sign), so fix the DTS to > match the bindings. > > Reported-by: Rob Herring > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 4f40a5c8f565..96ef0ddc0b2d 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -829,8 +829,8 @@ dma-controller@7ff00000 { > compatible = "arm,pl330", "arm,primecell"; > reg = <0x0 0x7ff00000 0 0x1000>; > #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > + dma-channels = <8>; > + dma-requests = <32>; BTW, this has always been wrong - Juno is configured with only 8 request interfaces. But then it's moot anyway since PL330 has an ID register for this stuff[1], so the DT properties aren't used by Linux, and shouldn't be needed in general. Thanks, Robin. [1] https://developer.arm.com/documentation/ddi0424/d/programmers-model/register-descriptions/configuration-register-0?lang=en > interrupts = , > , > , From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D111C433F5 for ; Thu, 28 Apr 2022 10:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AwBgBmJIQKp33U4JqbjnxLeB/f2KUy75NKhZVJPw1Lg=; b=2jBaqsWlf5IM6/ /jWKtLf71FhoFBRxQ4ImsABNsSLHKHJEHCfHVKkmaSywZLzlEaIR13WVE9RStE3ZAP4qm/9SrlN2c nRJn7G4sZAShSf1Ef95JdDiAIimQQB+3zRd4lvZp+4f6EJR5Mh5rLQK0Fngqo0w8KCxqhvsDQAu0e auEdmnDoUFdxGc20xTU/GqfoEDzUMQGn9+Wb7phKeeBhsZl9uChhMY50qB66Ccy5mWZTtLv0FQ8YV tcMtWbuuMG+Z2oH+A+soV6x4FfC+p7Pu22ZjQEap/A21NC7Z/+rBEECTRxlrf+VS5ZahBfPbmZDgt joohexxlIV9AemXaVFAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1cB-006Djh-OG; Thu, 28 Apr 2022 10:43:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nk1c7-006Di0-RN for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 10:43:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 963DB1474; Thu, 28 Apr 2022 03:43:10 -0700 (PDT) Received: from [10.57.80.98] (unknown [10.57.80.98]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EEF53F774; Thu, 28 Apr 2022 03:43:07 -0700 (PDT) Message-ID: <1d1aae6e-50db-d6db-9727-62f9c2d1ca6b@arm.com> Date: Thu, 28 Apr 2022 11:43:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 04/10] arm64: dts: juno: use proper 'dma-channels/requests' properties Content-Language: en-GB To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Dinh Nguyen , Michal Simek , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Ray Jui , Scott Branden , Broadcom Kernel Team , Sylwester Nawrocki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring References: <20220427155840.596535-1-krzysztof.kozlowski@linaro.org> <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> From: Robin Murphy In-Reply-To: <20220427155840.596535-5-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_034311_979159_34FEC46F X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-04-27 16:58, Krzysztof Kozlowski wrote: > pl330 DMA controller bindings documented 'dma-channels' and > 'dma-requests' properties (without leading hash sign), so fix the DTS to > match the bindings. > > Reported-by: Rob Herring > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/arm/juno-base.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi > index 4f40a5c8f565..96ef0ddc0b2d 100644 > --- a/arch/arm64/boot/dts/arm/juno-base.dtsi > +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi > @@ -829,8 +829,8 @@ dma-controller@7ff00000 { > compatible = "arm,pl330", "arm,primecell"; > reg = <0x0 0x7ff00000 0 0x1000>; > #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <32>; > + dma-channels = <8>; > + dma-requests = <32>; BTW, this has always been wrong - Juno is configured with only 8 request interfaces. But then it's moot anyway since PL330 has an ID register for this stuff[1], so the DT properties aren't used by Linux, and shouldn't be needed in general. Thanks, Robin. [1] https://developer.arm.com/documentation/ddi0424/d/programmers-model/register-descriptions/configuration-register-0?lang=en > interrupts = , > , > , _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel