From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754896Ab1EEPJL (ORCPT ); Thu, 5 May 2011 11:09:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14807 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510Ab1EEPJH (ORCPT ); Thu, 5 May 2011 11:09:07 -0400 Date: Thu, 5 May 2011 18:08:04 +0300 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Rusty Russell , Carsten Otte , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Shirley Ma , lguest@lists.ozlabs.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Krishna Kumar , Tom Lendacky , steved@us.ibm.com, habanero@linux.vnet.ibm.com Subject: [PATCH 1/3] virtio: fix avail event support Message-ID: <1d1d5b1a8d5326dae23685587e6ab84fc6b7177e.1304605816.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mutt-Fcc: =sent User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org make valid flag false, not true, on overrun Reported-by: Tom Lendacky Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_ring.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 57bf9d5..0ea0781 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -242,7 +242,7 @@ add_head: * kicked_avail index we stored. TODO: make sure all drivers * kick at least once in 2^16 and remove this. */ if (unlikely(vq->vring.avail->idx == vq->kicked_avail)) - vq->kicked_avail_valid = true; + vq->kicked_avail_valid = false; pr_debug("Added buffer head %i to %p\n", head, vq); END_USE(vq); -- 1.7.5.53.gc233e From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: [PATCH 1/3] virtio: fix avail event support Date: Thu, 5 May 2011 18:08:04 +0300 Message-ID: <1d1d5b1a8d5326dae23685587e6ab84fc6b7177e.1304605816.git.mst@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: Cc: Rusty Russell , Carsten Otte , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Shirley Ma , lguest@lists.ozlabs.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Krishna Kumar , Tom Lendacky , steved@us.ibm.com, habanero@linux.vnet.ibm.com List-ID: make valid flag false, not true, on overrun Reported-by: Tom Lendacky Signed-off-by: Michael S. Tsirkin --- drivers/virtio/virtio_ring.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 57bf9d5..0ea0781 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -242,7 +242,7 @@ add_head: * kicked_avail index we stored. TODO: make sure all drivers * kick at least once in 2^16 and remove this. */ if (unlikely(vq->vring.avail->idx == vq->kicked_avail)) - vq->kicked_avail_valid = true; + vq->kicked_avail_valid = false; pr_debug("Added buffer head %i to %p\n", head, vq); END_USE(vq); -- 1.7.5.53.gc233e